svn commit: r1428027 - /incubator/onami/trunk/test/src/main/java/org/apache/onami/test/OnamiRunner.java

[ma...@apache.org]

Author: marcosperanza
Date: Wed Jan  2 20:56:09 2013
New Revision: 1428027

URL: http://svn.apache.org/viewvc?rev=1428027&view=rev
Log:
Replaced 'OnamiRunner' static string with '.getSimpleName()' method.

Modified:
    incubator/onami/trunk/test/src/main/java/org/apache/onami/test/OnamiRunner.java

Modified: incubator/onami/trunk/test/src/main/java/org/apache/onami/test/OnamiRunner.java
URL: http://svn.apache.org/viewvc/incubator/onami/trunk/test/src/main/java/org/apache/onami/test/OnamiRunner.java?rev=1428027&r1=1428026&r2=1428027&view=diff
==============================================================================
--- incubator/onami/trunk/test/src/main/java/org/apache/onami/test/OnamiRunner.java (original)
+++ incubator/onami/trunk/test/src/main/java/org/apache/onami/test/OnamiRunner.java Wed Jan  2 20:56:09 2013
@@ -145,7 +145,7 @@ public class OnamiRunner
         {
             if ( logger.isLoggable( Level.FINER ) )
             {
-                logger.finer( "Inizializing OnamiRunner for class: " + klass.getSimpleName() );
+                logger.finer( "Inizializing " + OnamiRunner.class.getSimpleName() + " for class: " + klass.getName() );
             }
 
             this.allModules = inizializeInjector( klass );

Re: svn commit: r1428027 - /incubator/onami/trunk/test/src/main/java/org/apache/onami/test/OnamiRunner.java

[Simone Tripodi <si...@apache.org>]

Hi again mate,

> +                logger.finer( "Inizializing " + OnamiRunner.class.getSimpleName() + " for class: " + klass.getName() );

I wouldn't include the 'OnamiRunner' class name in the sentence, since
it can be set in the logger output pattern configuration, i.e. include
the thread, the log level, the logging class, then the message.
I'd just modify the message as

logger.finer( "Injecting members to test class: " + klass.getName() );

WDYT?
best,
-Simo

http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/