[jira] [Commented] (IMPALA-9028) Impala shell should not try to reconnect when quitting

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-9028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16952479#comment-16952479 ] 

ASF subversion and git services commented on IMPALA-9028:
---------------------------------------------------------

Commit 53774770bcfdc21ca86717653da31d0e0e93419e in impala's branch refs/heads/master from Joe McDonnell
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=5377477 ]

IMPALA-9028: impala-shell should not try to reconnect if quitting

When the impala-shell is disconnected, it will try to reconnect
for any command that a user runs (as part of ImpalaShell's precmd()).
This doesn't make sense when the user is trying to quit the shell
(i.e. by typing 'quit' or 'exit' or hitting Ctrl-D).

This skips the attempt to reconnect when quitting the shell.

Testing:
 - Added test in test_shell_interactive.py
 - Verified by hand

Change-Id: I6a76bc515db609498fa8772e9f0b0c547b82c09e
Reviewed-on: http://gerrit.cloudera.org:8080/14391
Reviewed-by: Thomas Tauber-Marshall <tm...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> Impala shell should not try to reconnect when quitting
> ------------------------------------------------------
>
>                 Key: IMPALA-9028
>                 URL: https://issues.apache.org/jira/browse/IMPALA-9028
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Clients
>    Affects Versions: Impala 3.4.0
>            Reporter: Joe McDonnell
>            Assignee: Joe McDonnell
>            Priority: Major
>              Labels: shell
>
> When the impala-shell is not connected, it will try to reconnect when executing a new command (in precmd).
> [https://github.com/apache/impala/blob/master/shell/impala_shell.py#L600-L603]
> {code:java}
> if not self.imp_client.is_connected():
>    print_to_stderr("Connection lost, reconnecting...")
>    self._connect()
>    self._validate_database(immediately=True)
> {code}
> This doesn't make sense if the user is quitting the shell (by typing 'quit', 'exit', or hitting Ctrl-D). It should skip the reconnect in this case.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org