You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2017/01/03 22:46:30 UTC
Re: Review Request 54213: Supported more layers through symlink for
aufs backend.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54213/
-----------------------------------------------------------
(Updated Jan. 3, 2017, 2:46 p.m.)
Review request for mesos, Avinash sridharan, Artem Harutyunyan, Jie Yu, Qian Zhang, and Zhitao Li.
Changes
-------
Rebased.
Bugs: MESOS-6001
https://issues.apache.org/jira/browse/MESOS-6001
Repository: mesos
Description
-------
This issue is similar to MESOS-6000. We use the same solution
(using symlinks) to resolve many-layer image issue with aufs
backend.
Diffs (updated)
-----
src/slave/containerizer/mesos/provisioner/backends/aufs.cpp c92c6c7174421158b9190ed0bfb00c1c97ef0f7b
Diff: https://reviews.apache.org/r/54213/diff/
Testing
-------
make check
Tested by the new unit test `ROOT_AUFS_AufsBackendWithManyLayers` (see the following patch).
Manually tested using a 37-layer image `gilbertsong/cirros:34`. It failed before the fix, and it passed after the fix.
Thanks,
Gilbert Song
Re: Review Request 54213: Supported more layers through symlink for
aufs backend.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54213/#review162960
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/containerizer/mesos/provisioner/backends/aufs.hpp (line 44)
<https://reviews.apache.org/r/54213/#comment234338>
Ditto.
src/slave/containerizer/mesos/provisioner/backends/aufs.cpp (line 149)
<https://reviews.apache.org/r/54213/#comment234337>
indentation here should be 4
- Jie Yu
On Jan. 24, 2017, 8:34 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54213/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2017, 8:34 p.m.)
>
>
> Review request for mesos, Avinash sridharan, Artem Harutyunyan, Jie Yu, Qian Zhang, and Zhitao Li.
>
>
> Bugs: MESOS-6001
> https://issues.apache.org/jira/browse/MESOS-6001
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This issue is similar to MESOS-6000. We use the same solution
> (using symlinks) to resolve many-layer image issue with aufs
> backend.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/backends/aufs.hpp a3c924195ae5eecc1caca9cd6fc0f6dc0df0a741
> src/slave/containerizer/mesos/provisioner/backends/aufs.cpp c92c6c7174421158b9190ed0bfb00c1c97ef0f7b
>
> Diff: https://reviews.apache.org/r/54213/diff/
>
>
> Testing
> -------
>
> make check
>
> Tested by the new unit test `ROOT_AUFS_AufsBackendWithManyLayers` (see the following patch).
>
> Manually tested using a 37-layer image `gilbertsong/cirros:34`. It failed before the fix, and it passed after the fix.
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 54213: Supported more layers through symlink for
aufs backend.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54213/
-----------------------------------------------------------
(Updated Jan. 24, 2017, 12:34 p.m.)
Review request for mesos, Avinash sridharan, Artem Harutyunyan, Jie Yu, Qian Zhang, and Zhitao Li.
Bugs: MESOS-6001
https://issues.apache.org/jira/browse/MESOS-6001
Repository: mesos
Description
-------
This issue is similar to MESOS-6000. We use the same solution
(using symlinks) to resolve many-layer image issue with aufs
backend.
Diffs (updated)
-----
src/slave/containerizer/mesos/provisioner/backends/aufs.hpp a3c924195ae5eecc1caca9cd6fc0f6dc0df0a741
src/slave/containerizer/mesos/provisioner/backends/aufs.cpp c92c6c7174421158b9190ed0bfb00c1c97ef0f7b
Diff: https://reviews.apache.org/r/54213/diff/
Testing
-------
make check
Tested by the new unit test `ROOT_AUFS_AufsBackendWithManyLayers` (see the following patch).
Manually tested using a 37-layer image `gilbertsong/cirros:34`. It failed before the fix, and it passed after the fix.
Thanks,
Gilbert Song
Re: Review Request 54213: Supported more layers through symlink for
aufs backend.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54213/#review162577
-----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/backends/aufs.cpp (lines 153 - 155)
<https://reviews.apache.org/r/54213/#comment233925>
See my comments in the previous patch. Please adjust accordingly and update aufs.hpp
- Jie Yu
On Jan. 19, 2017, 12:08 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54213/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2017, 12:08 p.m.)
>
>
> Review request for mesos, Avinash sridharan, Artem Harutyunyan, Jie Yu, Qian Zhang, and Zhitao Li.
>
>
> Bugs: MESOS-6001
> https://issues.apache.org/jira/browse/MESOS-6001
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This issue is similar to MESOS-6000. We use the same solution
> (using symlinks) to resolve many-layer image issue with aufs
> backend.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/backends/aufs.cpp c92c6c7174421158b9190ed0bfb00c1c97ef0f7b
>
> Diff: https://reviews.apache.org/r/54213/diff/
>
>
> Testing
> -------
>
> make check
>
> Tested by the new unit test `ROOT_AUFS_AufsBackendWithManyLayers` (see the following patch).
>
> Manually tested using a 37-layer image `gilbertsong/cirros:34`. It failed before the fix, and it passed after the fix.
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 54213: Supported more layers through symlink for
aufs backend.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54213/
-----------------------------------------------------------
(Updated Jan. 19, 2017, 4:08 a.m.)
Review request for mesos, Avinash sridharan, Artem Harutyunyan, Jie Yu, Qian Zhang, and Zhitao Li.
Changes
-------
Rebased.
Bugs: MESOS-6001
https://issues.apache.org/jira/browse/MESOS-6001
Repository: mesos
Description
-------
This issue is similar to MESOS-6000. We use the same solution
(using symlinks) to resolve many-layer image issue with aufs
backend.
Diffs (updated)
-----
src/slave/containerizer/mesos/provisioner/backends/aufs.cpp c92c6c7174421158b9190ed0bfb00c1c97ef0f7b
Diff: https://reviews.apache.org/r/54213/diff/
Testing
-------
make check
Tested by the new unit test `ROOT_AUFS_AufsBackendWithManyLayers` (see the following patch).
Manually tested using a 37-layer image `gilbertsong/cirros:34`. It failed before the fix, and it passed after the fix.
Thanks,
Gilbert Song