You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/06 19:53:50 UTC
[GitHub] [airflow] potiuk opened a new pull request #20084: Removes InputRequired validation with azure extra
potiuk opened a new pull request #20084:
URL: https://github.com/apache/airflow/pull/20084
The change #19923 introduced (accidentally) a required validation
for an azure extra, which caused an error in the connection
UI when the connection could not be added because the field was
missing.
This failed the test_crate_connection fail.
This change removes back the validation.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #20084: Removes InputRequired validation with azure extra
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #20084:
URL: https://github.com/apache/airflow/pull/20084
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #20084: Removes InputRequired validation with azure extra
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #20084:
URL: https://github.com/apache/airflow/pull/20084#issuecomment-987151835
> I must have mixed in some other logic that came out from the Mypy work: adding that validation in the Azure Data Factory form because `Subcription ID` is actually required functionally and was thinking about adding a validation to the connection form. That's my fault it snuck in. I thought I had removed it.
Though so :) Be careful with adding this back. It WON'T work likely. Those fields are present in the connection form even if they are hidden and will block adding ANOTHER connection
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #20084: Removes InputRequired validation with azure extra
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #20084:
URL: https://github.com/apache/airflow/pull/20084#issuecomment-987134607
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #20084: Removes InputRequired validation with azure extra
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20084:
URL: https://github.com/apache/airflow/pull/20084#issuecomment-987133634
cc: @josh-fell - I wonder where the ValidationRequired came from :D . It does not seem to be needed by MyPy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #20084: Removes InputRequired validation with azure extra
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #20084:
URL: https://github.com/apache/airflow/pull/20084#issuecomment-987133634
cc: @josh-fell - I wonder where the InputRequired came from :D . It does not seem to be needed by MyPy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #20084: Removes InputRequired validation with azure extra
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #20084:
URL: https://github.com/apache/airflow/pull/20084#issuecomment-987151835
> I must have mixed in some other logic that came out from the Mypy work: adding that validation in the Azure Data Factory form because `Subcription ID` is actually required functionally and was thinking about adding a validation to the connection form. That's my fault it snuck in. I thought I had removed it.
Though so :) Be careful with adding this back. It WON'T work likely. Those fields are present in the connection form even if they are hidden and will block adding ANOTHER connection (this is what happened in the test - our test nicely caught it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell commented on pull request #20084: Removes InputRequired validation with azure extra
Posted by GitBox <gi...@apache.org>.
josh-fell commented on pull request #20084:
URL: https://github.com/apache/airflow/pull/20084#issuecomment-987142061
> cc: @josh-fell - I wonder where the InputRequired came from :D . It does not seem to be needed by MyPy.
I must have mixed in some other logic that came out from the Mypy work: adding that validation in the Azure Data Factory form because `Subcription ID` is actually required functionally and was thinking about adding a validation to the connection form. That's my fault it snuck in. I thought I had removed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #20084: Removes InputRequired validation with azure extra
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20084:
URL: https://github.com/apache/airflow/pull/20084#issuecomment-987151835
> I must have mixed in some other logic that came out from the Mypy work: adding that validation in the Azure Data Factory form because `Subcription ID` is actually required functionally and was thinking about adding a validation to the connection form. That's my fault it snuck in. I thought I had removed it.
Though so :) Be careful with adding this back. It WON'T work likely. Those fields are present in the connection form even if they are hidden.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell commented on pull request #20084: Removes InputRequired validation with azure extra
Posted by GitBox <gi...@apache.org>.
josh-fell commented on pull request #20084:
URL: https://github.com/apache/airflow/pull/20084#issuecomment-987228880
> > I must have mixed in some other logic that came out from the Mypy work: adding that validation in the Azure Data Factory form because `Subcription ID` is actually required functionally and was thinking about adding a validation to the connection form. That's my fault it snuck in. I thought I had removed it.
>
> Though so :) Be careful with adding this back. It WON'T work likely. Those fields are present in the connection form even if they are hidden and will block adding ANOTHER connection (this is what happened in the test - our test nicely caught it)
Will do, thanks for the heads up! Would be a shame if custom forms couldn't set required-field validations on these "extra" fields. Not a big deal though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org