You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2017/10/09 06:28:03 UTC
Review Request 62837: Added a test
`DefaultExecutorTest.KillMultipleTasks`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62837/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-8051
https://issues.apache.org/jira/browse/MESOS-8051
Repository: mesos
Description
-------
Added a test `DefaultExecutorTest.KillMultipleTasks`.
Diffs
-----
src/tests/default_executor_tests.cpp 2b4c643b8fb2fc8f2a5e98984ae1c267f66885d1
Diff: https://reviews.apache.org/r/62837/diff/1/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 62837: Added a test
`DefaultExecutorTest.KillMultipleTasks`.
Posted by Qian Zhang <zh...@gmail.com>.
> On Oct. 31, 2017, 8:25 a.m., Gaston Kleiman wrote:
> > src/tests/default_executor_tests.cpp
> > Lines 500-508 (patched)
> > <https://reviews.apache.org/r/62837/diff/1/?file=1849449#file1849449line500>
> >
> > Does this still work now that the DefaultExecutor sends `TASK_STARTING` updates?
Thanks for the comment! The changes to default executor for sending `TASK_STARTING` was done after I posted this patch, now I have updated the patch for receiving `TASK_STARTING` update.
> On Oct. 31, 2017, 8:25 a.m., Gaston Kleiman wrote:
> > src/tests/default_executor_tests.cpp
> > Lines 537-550 (patched)
> > <https://reviews.apache.org/r/62837/diff/1/?file=1849449#file1849449line537>
> >
> > This should use the new `createCallKill` helper, see https://reviews.apache.org/r/63419/ for examples.
Yeah, I agree. That helper was added afterwards, now I have updated this patch to use it.
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62837/#review189673
-----------------------------------------------------------
On Oct. 31, 2017, 12:53 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62837/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2017, 12:53 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-8051
> https://issues.apache.org/jira/browse/MESOS-8051
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `DefaultExecutorTest.KillMultipleTasks`.
>
>
> Diffs
> -----
>
> src/tests/default_executor_tests.cpp 5078bd4d70698f5cbd14c971fcecfd58f8467a04
>
>
> Diff: https://reviews.apache.org/r/62837/diff/2/
>
>
> Testing
> -------
>
> [ RUN ] MesosContainerizer/DefaultExecutorTest.KillMultipleTasks/0
> I1030 21:47:58.181413 22360 executor.cpp:192] Version: 1.5.0
> I1030 21:47:58.201525 22382 default_executor.cpp:191] Received SUBSCRIBED event
> I1030 21:47:58.203812 22382 default_executor.cpp:195] Subscribed executor on core-dev
> I1030 21:47:58.204406 22382 default_executor.cpp:191] Received LAUNCH_GROUP event
> I1030 21:47:58.205346 22390 default_executor.cpp:402] Setting 'MESOS_CONTAINER_IP' to: 10.0.49.2
> I1030 21:47:58.220854 22356 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:47:58.221959 22367 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:47:58.261060 22370 default_executor.cpp:640] Successfully launched tasks [ 4fee2fec-12b5-4af6-bd70-e67b4da26c00, 24695aee-aa59-4295-8ad9-19f17ad9d52b ] in child containers [ 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18, 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 ]
> I1030 21:47:58.263293 22385 default_executor.cpp:713] Waiting for child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18 of task '4fee2fec-12b5-4af6-bd70-e67b4da26c00'
> I1030 21:47:58.263546 22385 default_executor.cpp:713] Waiting for child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 of task '24695aee-aa59-4295-8ad9-19f17ad9d52b'
> I1030 21:47:58.307412 22351 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:47:58.307924 22358 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:47:58.354656 22365 default_executor.cpp:191] Received KILL event
> I1030 21:47:58.354730 22365 default_executor.cpp:1172] Received kill for task '4fee2fec-12b5-4af6-bd70-e67b4da26c00'
> I1030 21:47:58.354787 22365 default_executor.cpp:1057] Killing task 4fee2fec-12b5-4af6-bd70-e67b4da26c00 running in child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18 with SIGTERM signal
> I1030 21:47:58.354825 22365 default_executor.cpp:1079] Scheduling escalation to SIGKILL in 3secs from now
> I1030 21:47:58.355772 22365 default_executor.cpp:191] Received KILL event
> I1030 21:47:58.355819 22365 default_executor.cpp:1172] Received kill for task '24695aee-aa59-4295-8ad9-19f17ad9d52b'
> I1030 21:47:58.355947 22365 default_executor.cpp:1057] Killing task 24695aee-aa59-4295-8ad9-19f17ad9d52b running in child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 with SIGTERM signal
> I1030 21:47:58.355980 22365 default_executor.cpp:1079] Scheduling escalation to SIGKILL in 3secs from now
> I1030 21:47:58.467401 22380 default_executor.cpp:888] Child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18 of task '4fee2fec-12b5-4af6-bd70-e67b4da26c00' completed in state TASK_KILLED: Command terminated with signal Terminated
> I1030 21:47:58.467478 22380 default_executor.cpp:924] Killing task group containing tasks [ 4fee2fec-12b5-4af6-bd70-e67b4da26c00, 24695aee-aa59-4295-8ad9-19f17ad9d52b ]
> I1030 21:47:58.467888 22380 default_executor.cpp:888] Child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 of task '24695aee-aa59-4295-8ad9-19f17ad9d52b' completed in state TASK_KILLED: Command terminated with signal Terminated
> I1030 21:47:58.467934 22380 default_executor.cpp:1017] Terminating after 1secs
> [ OK ] MesosContainerizer/DefaultExecutorTest.KillMultipleTasks/0 (922 ms)
>
>
> [ RUN ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillMultipleTasks/0
> I1030 21:51:07.645311 25065 executor.cpp:192] Version: 1.5.0
> I1030 21:51:07.665602 25086 default_executor.cpp:191] Received SUBSCRIBED event
> I1030 21:51:07.667804 25086 default_executor.cpp:195] Subscribed executor on core-dev
> I1030 21:51:07.668308 25086 default_executor.cpp:191] Received LAUNCH_GROUP event
> I1030 21:51:07.669232 25093 default_executor.cpp:402] Setting 'MESOS_CONTAINER_IP' to: 10.0.49.2
> I1030 21:51:07.684146 25060 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:51:07.685752 25071 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:51:07.730559 25077 default_executor.cpp:640] Successfully launched tasks [ fce3ed1c-d93a-4b6f-8950-771a989b279b, 2e1b7db2-5f05-4474-bd5e-00c03468db71 ] in child containers [ 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.6ee13669-0de9-41b6-bde9-9f581b3e9c2e, 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.d11330e3-4f3a-4686-be5f-935ec8f44111 ]
> I1030 21:51:07.732921 25089 default_executor.cpp:713] Waiting for child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.6ee13669-0de9-41b6-bde9-9f581b3e9c2e of task 'fce3ed1c-d93a-4b6f-8950-771a989b279b'
> I1030 21:51:07.733170 25089 default_executor.cpp:713] Waiting for child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.d11330e3-4f3a-4686-be5f-935ec8f44111 of task '2e1b7db2-5f05-4474-bd5e-00c03468db71'
> I1030 21:51:07.776757 25056 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:51:07.777101 25062 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:51:07.824290 25065 default_executor.cpp:191] Received KILL event
> I1030 21:51:07.824533 25065 default_executor.cpp:1172] Received kill for task 'fce3ed1c-d93a-4b6f-8950-771a989b279b'
> I1030 21:51:07.824579 25065 default_executor.cpp:1057] Killing task fce3ed1c-d93a-4b6f-8950-771a989b279b running in child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.6ee13669-0de9-41b6-bde9-9f581b3e9c2e with SIGTERM signal
> I1030 21:51:07.824606 25065 default_executor.cpp:1079] Scheduling escalation to SIGKILL in 3secs from now
> I1030 21:51:07.825533 25065 default_executor.cpp:191] Received KILL event
> I1030 21:51:07.825597 25065 default_executor.cpp:1172] Received kill for task '2e1b7db2-5f05-4474-bd5e-00c03468db71'
> I1030 21:51:07.825647 25065 default_executor.cpp:1057] Killing task 2e1b7db2-5f05-4474-bd5e-00c03468db71 running in child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.d11330e3-4f3a-4686-be5f-935ec8f44111 with SIGTERM signal
> I1030 21:51:07.825690 25065 default_executor.cpp:1079] Scheduling escalation to SIGKILL in 3secs from now
> I1030 21:51:07.957986 25083 default_executor.cpp:888] Child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.6ee13669-0de9-41b6-bde9-9f581b3e9c2e of task 'fce3ed1c-d93a-4b6f-8950-771a989b279b' completed in state TASK_KILLED: Command terminated with signal Terminated
> I1030 21:51:07.958062 25083 default_executor.cpp:924] Killing task group containing tasks [ fce3ed1c-d93a-4b6f-8950-771a989b279b, 2e1b7db2-5f05-4474-bd5e-00c03468db71 ]
> I1030 21:51:07.958566 25083 default_executor.cpp:888] Child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.d11330e3-4f3a-4686-be5f-935ec8f44111 of task '2e1b7db2-5f05-4474-bd5e-00c03468db71' completed in state TASK_KILLED: Command terminated with signal Terminated
> I1030 21:51:07.958626 25083 default_executor.cpp:1017] Terminating after 1secs
> [ OK ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillMultipleTasks/0 (9200 ms)
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 62837: Added a test
`DefaultExecutorTest.KillMultipleTasks`.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62837/#review189673
-----------------------------------------------------------
src/tests/default_executor_tests.cpp
Lines 500-508 (patched)
<https://reviews.apache.org/r/62837/#comment266880>
Does this still work now that the DefaultExecutor sends `TASK_STARTING` updates?
src/tests/default_executor_tests.cpp
Lines 537-550 (patched)
<https://reviews.apache.org/r/62837/#comment266879>
This should use the new `createCallKill` helper, see https://reviews.apache.org/r/63419/ for examples.
- Gaston Kleiman
On Oct. 8, 2017, 11:28 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62837/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2017, 11:28 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-8051
> https://issues.apache.org/jira/browse/MESOS-8051
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `DefaultExecutorTest.KillMultipleTasks`.
>
>
> Diffs
> -----
>
> src/tests/default_executor_tests.cpp 2b4c643b8fb2fc8f2a5e98984ae1c267f66885d1
>
>
> Diff: https://reviews.apache.org/r/62837/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 62837: Added a test
`DefaultExecutorTest.KillMultipleTasks`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62837/#review187390
-----------------------------------------------------------
FAIL: The system cannot find the file specified.
Reviews applied: `['62806']`
Failed command: `C:\mesos\src\mesos-tests.exe --verbose --gtest_filter="-ContentType/MasterAPITest.EventAuthorizationFiltering/1"`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806/logs/mesos-tests-stdout.log):
```
[ RUN ] FaultToleranceTest.SchedulerReregisterAfterUnregistration
[ OK ] FaultToleranceTest.SchedulerReregisterAfterUnregistration (389 ms)
[ RUN ] FaultToleranceTest.SchedulerFailoverRetriedReregistration
[ OK ] FaultToleranceTest.SchedulerFailoverRetriedReregistration (389 ms)
[ RUN ] FaultToleranceTest.DisconnectedSchedulerLaunchLost
[ OK ] FaultToleranceTest.DisconnectedSchedulerLaunchLost (609 ms)
[ RUN ] FaultToleranceTest.DisconnectedSchedulerLaunchDropped
[ OK ] FaultToleranceTest.DisconnectedSchedulerLaunchDropped (596 ms)
[ RUN ] FaultToleranceTest.SchedulerFailoverStatusUpdate
[ OK ] FaultToleranceTest.SchedulerFailoverStatusUpdate (923 ms)
[ RUN ] FaultToleranceTest.ReregisterFrameworkExitedExecutor
[ OK ] FaultToleranceTest.ReregisterFrameworkExitedExecutor (1249 ms)
[ RUN ] FaultToleranceTest.ForwardStatusUpdateUnknownExecutor
[ OK ] FaultToleranceTest.ForwardStatusUpdateUnknownExecutor (822 ms)
[ RUN ] FaultToleranceTest.SchedulerFailoverExecutorToFrameworkMessage
[ OK ] FaultToleranceTest.SchedulerFailoverExecutorToFrameworkMessage (941 ms)
[ RUN ] FaultToleranceTest.SchedulerFailoverFrameworkToExecutorMessage
[ OK ] FaultToleranceTest.SchedulerFailoverFrameworkToExecutorMessage (1060 ms)
[ RUN ] FaultToleranceTest.IgnoreKillTaskFromUnregisteredFramework
[ OK ] FaultToleranceTest.IgnoreKillTaskFromUnregisteredFramework (939 ms)
[ RUN ] FaultToleranceTest.SchedulerExit
[ OK ] FaultToleranceTest.SchedulerExit (841 ms)
[ RUN ] FaultToleranceTest.SlaveReliableRegistration
[ OK ] FaultToleranceTest.SlaveReliableRegistration (788 ms)
[ RUN ] FaultToleranceTest.SlaveReregisterOnZKExpiration
[ OK ] FaultToleranceTest.SlaveReregisterOnZKExpiration (778 ms)
[ RUN ] FaultToleranceTest.FrameworkReregisterEmptyExecutor
[ OK ] FaultToleranceTest.FrameworkReregisterEmptyExecutor (1130 ms)
[ RUN ] FaultToleranceTest.SplitBrainMasters
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806/logs/mesos-tests-stderr.log):
```
I1006 17:26:12.991288 43216 master.cpp:8459] Removing framework ede9e20a-4e06-46fb-a22c-7e8013f03fa7-0000 (default) at scheduler-3a38ff4a-a81c-4c5b-9c40-38d63a94afd2@10.3.1.5:61771
I1006 17:26:12.991288 43216 master.cpp:3299] Deactivating framework ede9e20a-4e06-46fb-a22c-7e8013f03fa7-0000 (default) at scheduler-3a38ff4a-a81c-4c5b-9c40-38d63a94afd2@10.3.1.5:61771
I1006 17:26:12.992297 46984 hierarchical.cpp:412] Deactivated framework ede9e20a-4e06-46fb-a22c-7e8013f03fa7-0000
I1006 17:26:12.995283 43216 master.cpp:9389] Removing offer 60f5153f-ffdc-4156-8383-39cf5a6b25f8-O0
I1006 17:26:12.998283 46248 slave.cpp:869] Agent terminating
I1006 17:26:13.004289 21464 hierarchical.cpp:355] Removed framework ede9e20a-4e06-46fb-a22c-7e8013f03fa7-0000
I1006 17:26:13.007899 39284 master.cpp:1303] Agent ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 at slave(37)@10.3.1.5:61771 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I1006 17:26:13.008906 39284 master.cpp:3336] Disconnecting agent ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 at slave(37)@10.3.1.5:61771 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1006 17:26:13.008906 39284 master.cpp:3355] Deactivating agent ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 at slave(37)@10.3.1.5:61771 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1006 17:26:13.009905 46484 hierarchical.cpp:690] Agent ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 deactivated
I1006 17:26:13.038906 46248 master.cpp:1145] Master terminating
I1006 17:26:13.040907 21464 hierarchical.cpp:626] Removed agent ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0
I1006 17:26:13.151911 46248 cluster.cpp:162] Creating default 'local' authorizer
I1006 17:26:13.184912 44660 master.cpp:445] Master 8c8fa538-3ba3-4608-8e12-2ba9b5151087 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) started on 10.3.1.5:61771
I1006 17:26:13.184912 44660 master.cpp:447] Flags at startup: --acls="" --agent_ping_timeout="15secs" --agent_reregister_timeout="10mins" --allocation_interval="1secs" --allocator="HierarchicalDRF" --authenticate_agents="true" --authenticate_frameworks="true" --authenticate_http_frameworks="true" --authenticate_http_readonly="true" --authenticate_http_readwrite="true" --authenticators="crammd5" --authorizers="local" --credentials="C:\Users\mesos\AppData\Local\Temp\2\BVZ2va\credentials" --filter_gpu_resources="true" --framework_sorter="drf" --help="false" --hostname_lookup="true" --http_authenticators="basic" --http_framework_authenticators="basic" --initialize_driver_logging="true" --log_auto_initialize="true" --logbufsecs="0" --logging_level="INFO" --max_agent_ping_timeouts="5" --max_completed_frameworks="50" --max_completed_tasks_per_framework="1000" --max_unreachable_tasks_per_framework="1000" --port="5050" --quiet="false" --recovery_agent_removal_limit="100%" --registry="in_memor
y" --registry_fetch_timeout="1mins" --registry_gc_interval="15mins" --registry_max_agent_age="2weeks" --registry_max_agent_count="102400" --registry_store_timeout="100secs" --registry_strict="false" --root_submissions="true" --user_sorter="drf" --version="false" --webui_dir="/webui" --work_dir="C:\Users\mesos\AppData\Local\Temp\2\BVZ2va\master" --zk_session_timeout="10secs"
I1006 17:26:13.223922 44660 master.cpp:496] Master only allowing authenticated frameworks to register
I1006 17:26:13.223922 44660 master.cpp:502] Master only allowing authenticated agents to register
I1006 17:26:13.223922 44660 master.cpp:508] Master only allowing authenticated HTTP frameworks to register
I1006 17:26:13.223922 44660 credentials.hpp:37] Loading credentials for authentication from 'C:\Users\mesos\AppData\Local\Temp\2\BVZ2va\credentials'
I1006 17:26:13.235913 44660 master.cpp:552] Using default 'crammd5' authenticator
I1006 17:26:13.236914 44660 http.cpp:1045] Creating default 'basic' HTTP authenticator for realm 'mesos-master-readonly'
I1006 17:26:13.237915 44660 http.cpp:1045] Creating default 'basic' HTTP authenticator for realm 'mesos-master-readwrite'
I1006 17:26:13.238914 44660 http.cpp:1045] Creating default 'basic' HTTP authenticator for realm 'mesos-master-scheduler'
I1006 17:26:13.239914 44660 master.cpp:631] Authorization enabled
I1006 17:26:13.270947 45764 master.cpp:2198] Elected as the leading master!
I1006 17:26:13.270947 45764 master.cpp:1687] Recovering from registrar
I1006 17:26:13.273921 39284 registrar.cpp:391] Successfully fetched the registry (0B) in 1.97504ms
I1006 17:26:13.273921 39284 registrar.cpp:495] Applied 1 operations in 0ns; attempting to update the registry
I1006 17:26:13.275921 21464 registrar.cpp:552] Successfully updated the registry in 999936ns
I1006 17:26:13.276916 21464 registrar.cpp:424] Success```
- Mesos Reviewbot Windows
On Oct. 9, 2017, 2:28 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62837/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2017, 2:28 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-8051
> https://issues.apache.org/jira/browse/MESOS-8051
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `DefaultExecutorTest.KillMultipleTasks`.
>
>
> Diffs
> -----
>
> src/tests/default_executor_tests.cpp 2b4c643b8fb2fc8f2a5e98984ae1c267f66885d1
>
>
> Diff: https://reviews.apache.org/r/62837/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 62837: Added a test
`DefaultExecutorTest.KillMultipleTasks`.
Posted by Qian Zhang <zh...@gmail.com>.
> On Oct. 31, 2017, 8:21 a.m., Vinod Kone wrote:
> > Can you update the testing section? Hopefully you have run in this in a loop several times?
Sure, I have updated it, and yes, I have run it repeatedly (100 times) and it works well.
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62837/#review189672
-----------------------------------------------------------
On Oct. 31, 2017, 12:53 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62837/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2017, 12:53 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-8051
> https://issues.apache.org/jira/browse/MESOS-8051
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `DefaultExecutorTest.KillMultipleTasks`.
>
>
> Diffs
> -----
>
> src/tests/default_executor_tests.cpp 5078bd4d70698f5cbd14c971fcecfd58f8467a04
>
>
> Diff: https://reviews.apache.org/r/62837/diff/2/
>
>
> Testing
> -------
>
> [ RUN ] MesosContainerizer/DefaultExecutorTest.KillMultipleTasks/0
> I1030 21:47:58.181413 22360 executor.cpp:192] Version: 1.5.0
> I1030 21:47:58.201525 22382 default_executor.cpp:191] Received SUBSCRIBED event
> I1030 21:47:58.203812 22382 default_executor.cpp:195] Subscribed executor on core-dev
> I1030 21:47:58.204406 22382 default_executor.cpp:191] Received LAUNCH_GROUP event
> I1030 21:47:58.205346 22390 default_executor.cpp:402] Setting 'MESOS_CONTAINER_IP' to: 10.0.49.2
> I1030 21:47:58.220854 22356 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:47:58.221959 22367 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:47:58.261060 22370 default_executor.cpp:640] Successfully launched tasks [ 4fee2fec-12b5-4af6-bd70-e67b4da26c00, 24695aee-aa59-4295-8ad9-19f17ad9d52b ] in child containers [ 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18, 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 ]
> I1030 21:47:58.263293 22385 default_executor.cpp:713] Waiting for child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18 of task '4fee2fec-12b5-4af6-bd70-e67b4da26c00'
> I1030 21:47:58.263546 22385 default_executor.cpp:713] Waiting for child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 of task '24695aee-aa59-4295-8ad9-19f17ad9d52b'
> I1030 21:47:58.307412 22351 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:47:58.307924 22358 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:47:58.354656 22365 default_executor.cpp:191] Received KILL event
> I1030 21:47:58.354730 22365 default_executor.cpp:1172] Received kill for task '4fee2fec-12b5-4af6-bd70-e67b4da26c00'
> I1030 21:47:58.354787 22365 default_executor.cpp:1057] Killing task 4fee2fec-12b5-4af6-bd70-e67b4da26c00 running in child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18 with SIGTERM signal
> I1030 21:47:58.354825 22365 default_executor.cpp:1079] Scheduling escalation to SIGKILL in 3secs from now
> I1030 21:47:58.355772 22365 default_executor.cpp:191] Received KILL event
> I1030 21:47:58.355819 22365 default_executor.cpp:1172] Received kill for task '24695aee-aa59-4295-8ad9-19f17ad9d52b'
> I1030 21:47:58.355947 22365 default_executor.cpp:1057] Killing task 24695aee-aa59-4295-8ad9-19f17ad9d52b running in child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 with SIGTERM signal
> I1030 21:47:58.355980 22365 default_executor.cpp:1079] Scheduling escalation to SIGKILL in 3secs from now
> I1030 21:47:58.467401 22380 default_executor.cpp:888] Child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18 of task '4fee2fec-12b5-4af6-bd70-e67b4da26c00' completed in state TASK_KILLED: Command terminated with signal Terminated
> I1030 21:47:58.467478 22380 default_executor.cpp:924] Killing task group containing tasks [ 4fee2fec-12b5-4af6-bd70-e67b4da26c00, 24695aee-aa59-4295-8ad9-19f17ad9d52b ]
> I1030 21:47:58.467888 22380 default_executor.cpp:888] Child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 of task '24695aee-aa59-4295-8ad9-19f17ad9d52b' completed in state TASK_KILLED: Command terminated with signal Terminated
> I1030 21:47:58.467934 22380 default_executor.cpp:1017] Terminating after 1secs
> [ OK ] MesosContainerizer/DefaultExecutorTest.KillMultipleTasks/0 (922 ms)
>
>
> [ RUN ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillMultipleTasks/0
> I1030 21:51:07.645311 25065 executor.cpp:192] Version: 1.5.0
> I1030 21:51:07.665602 25086 default_executor.cpp:191] Received SUBSCRIBED event
> I1030 21:51:07.667804 25086 default_executor.cpp:195] Subscribed executor on core-dev
> I1030 21:51:07.668308 25086 default_executor.cpp:191] Received LAUNCH_GROUP event
> I1030 21:51:07.669232 25093 default_executor.cpp:402] Setting 'MESOS_CONTAINER_IP' to: 10.0.49.2
> I1030 21:51:07.684146 25060 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:51:07.685752 25071 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:51:07.730559 25077 default_executor.cpp:640] Successfully launched tasks [ fce3ed1c-d93a-4b6f-8950-771a989b279b, 2e1b7db2-5f05-4474-bd5e-00c03468db71 ] in child containers [ 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.6ee13669-0de9-41b6-bde9-9f581b3e9c2e, 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.d11330e3-4f3a-4686-be5f-935ec8f44111 ]
> I1030 21:51:07.732921 25089 default_executor.cpp:713] Waiting for child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.6ee13669-0de9-41b6-bde9-9f581b3e9c2e of task 'fce3ed1c-d93a-4b6f-8950-771a989b279b'
> I1030 21:51:07.733170 25089 default_executor.cpp:713] Waiting for child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.d11330e3-4f3a-4686-be5f-935ec8f44111 of task '2e1b7db2-5f05-4474-bd5e-00c03468db71'
> I1030 21:51:07.776757 25056 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:51:07.777101 25062 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:51:07.824290 25065 default_executor.cpp:191] Received KILL event
> I1030 21:51:07.824533 25065 default_executor.cpp:1172] Received kill for task 'fce3ed1c-d93a-4b6f-8950-771a989b279b'
> I1030 21:51:07.824579 25065 default_executor.cpp:1057] Killing task fce3ed1c-d93a-4b6f-8950-771a989b279b running in child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.6ee13669-0de9-41b6-bde9-9f581b3e9c2e with SIGTERM signal
> I1030 21:51:07.824606 25065 default_executor.cpp:1079] Scheduling escalation to SIGKILL in 3secs from now
> I1030 21:51:07.825533 25065 default_executor.cpp:191] Received KILL event
> I1030 21:51:07.825597 25065 default_executor.cpp:1172] Received kill for task '2e1b7db2-5f05-4474-bd5e-00c03468db71'
> I1030 21:51:07.825647 25065 default_executor.cpp:1057] Killing task 2e1b7db2-5f05-4474-bd5e-00c03468db71 running in child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.d11330e3-4f3a-4686-be5f-935ec8f44111 with SIGTERM signal
> I1030 21:51:07.825690 25065 default_executor.cpp:1079] Scheduling escalation to SIGKILL in 3secs from now
> I1030 21:51:07.957986 25083 default_executor.cpp:888] Child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.6ee13669-0de9-41b6-bde9-9f581b3e9c2e of task 'fce3ed1c-d93a-4b6f-8950-771a989b279b' completed in state TASK_KILLED: Command terminated with signal Terminated
> I1030 21:51:07.958062 25083 default_executor.cpp:924] Killing task group containing tasks [ fce3ed1c-d93a-4b6f-8950-771a989b279b, 2e1b7db2-5f05-4474-bd5e-00c03468db71 ]
> I1030 21:51:07.958566 25083 default_executor.cpp:888] Child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.d11330e3-4f3a-4686-be5f-935ec8f44111 of task '2e1b7db2-5f05-4474-bd5e-00c03468db71' completed in state TASK_KILLED: Command terminated with signal Terminated
> I1030 21:51:07.958626 25083 default_executor.cpp:1017] Terminating after 1secs
> [ OK ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillMultipleTasks/0 (9200 ms)
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 62837: Added a test
`DefaultExecutorTest.KillMultipleTasks`.
Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62837/#review189672
-----------------------------------------------------------
Ship it!
Can you update the testing section? Hopefully you have run in this in a loop several times?
- Vinod Kone
On Oct. 9, 2017, 6:28 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62837/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2017, 6:28 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-8051
> https://issues.apache.org/jira/browse/MESOS-8051
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `DefaultExecutorTest.KillMultipleTasks`.
>
>
> Diffs
> -----
>
> src/tests/default_executor_tests.cpp 2b4c643b8fb2fc8f2a5e98984ae1c267f66885d1
>
>
> Diff: https://reviews.apache.org/r/62837/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 62837: Added a test
`DefaultExecutorTest.KillMultipleTasks`.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On Nov. 1, 2017, 3 p.m., Gaston Kleiman wrote:
> > src/tests/default_executor_tests.cpp
> > Lines 538-548 (patched)
> > <https://reviews.apache.org/r/62837/diff/2/?file=1873334#file1873334line538>
> >
> > This is racy; there's no guarantee that the first `TASK_RUNNING` status update will come after the second `TASK_STARTING` update.
> >
> > The following ordering would also be possible: [`TASK_STARTING`, `TASK_RUNNING`, `TASK_STARTING`, `TASK_RUNNING`, ...]
>
> Alexander Rukletsov wrote:
> To simplify the logic here, let's introduce a matcher in our tests, something like
> ```
> MATCHER_P(TaskStateEq, state, "") { return arg.state() == state; }
> ```
> which we then can use like
> ```
> Future<TaskStatus> status;
> EXPECT_CALL(sched, statusUpdate(&driver, TaskStateEq(TASK_RUNNING)))
> .WillOnce(FutureArg<1>(&status));
> ```
> Then you can combine both task state and task id matchers to get an exact status update.
>
> Gaston Kleiman wrote:
> AlexR suggested something like this:
>
> ```
> Sequence task1;
> EXPECT_CALL(
> *scheduler,
> update(_, AllOf(TaskStatusEq(TASK_STARTING), TaskStateEq(taskInfo1))))
> .InSequence(task1)
> .WillOnce(
> DoAll(
> FutureArg<1>(&startingUpdate1),
> v1::scheduler::SendAcknowledge(frameworkId, agentId)));
>
> EXPECT_CALL(
> *scheduler,
> update(_, AllOf(TaskStatusEq(TASK_RUNNING), TaskStateEq(taskInfo1))))
> .InSequence(task1)
> .WillOnce(
> DoAll(
> FutureArg<1>(&runningUpdate1),
> v1::scheduler::SendAcknowledge(frameworkId, agentId)));
>
> Sequence task2;
> EXPECT_CALL(
> *scheduler,
> update(_, AllOf(TaskStatusEq(TASK_STARTING), TaskStateEq(taskInfo2))))
> .InSequence(task2)
> .WillOnce(
> DoAll(
> FutureArg<1>(&startingUpdate2),
> v1::scheduler::SendAcknowledge(frameworkId, agentId)));
>
> EXPECT_CALL(
> *scheduler,
> update(_, AllOf(TaskStatusEq(TASK_RUNNING), TaskStateEq(taskInfo2))))
> .InSequence(task2)
> .WillOnce(
> DoAll(
> FutureArg<1>(&runningUpdate2),
> v1::scheduler::SendAcknowledge(frameworkId, agentId)));
>
> AWAIT_READY(startingUpdate1);
> AWAIT_READY(runningUpdate1);
>
> AWAIT_READY(startingUpdate2);
> AWAIT_READY(runningUpdate2);
> ```
Parameters are mixed up : )
`AllOf(TaskStatusEq(<taskInfo>), TaskStateEq(<TASK_STATE>))`
Also feel free to refactor `TaskStatusEq` to take an id if you think it is simpler.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62837/#review189800
-----------------------------------------------------------
On Oct. 31, 2017, 4:53 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62837/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2017, 4:53 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-8051
> https://issues.apache.org/jira/browse/MESOS-8051
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `DefaultExecutorTest.KillMultipleTasks`.
>
>
> Diffs
> -----
>
> src/tests/default_executor_tests.cpp 5078bd4d70698f5cbd14c971fcecfd58f8467a04
>
>
> Diff: https://reviews.apache.org/r/62837/diff/2/
>
>
> Testing
> -------
>
> [ RUN ] MesosContainerizer/DefaultExecutorTest.KillMultipleTasks/0
> I1030 21:47:58.181413 22360 executor.cpp:192] Version: 1.5.0
> I1030 21:47:58.201525 22382 default_executor.cpp:191] Received SUBSCRIBED event
> I1030 21:47:58.203812 22382 default_executor.cpp:195] Subscribed executor on core-dev
> I1030 21:47:58.204406 22382 default_executor.cpp:191] Received LAUNCH_GROUP event
> I1030 21:47:58.205346 22390 default_executor.cpp:402] Setting 'MESOS_CONTAINER_IP' to: 10.0.49.2
> I1030 21:47:58.220854 22356 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:47:58.221959 22367 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:47:58.261060 22370 default_executor.cpp:640] Successfully launched tasks [ 4fee2fec-12b5-4af6-bd70-e67b4da26c00, 24695aee-aa59-4295-8ad9-19f17ad9d52b ] in child containers [ 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18, 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 ]
> I1030 21:47:58.263293 22385 default_executor.cpp:713] Waiting for child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18 of task '4fee2fec-12b5-4af6-bd70-e67b4da26c00'
> I1030 21:47:58.263546 22385 default_executor.cpp:713] Waiting for child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 of task '24695aee-aa59-4295-8ad9-19f17ad9d52b'
> I1030 21:47:58.307412 22351 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:47:58.307924 22358 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:47:58.354656 22365 default_executor.cpp:191] Received KILL event
> I1030 21:47:58.354730 22365 default_executor.cpp:1172] Received kill for task '4fee2fec-12b5-4af6-bd70-e67b4da26c00'
> I1030 21:47:58.354787 22365 default_executor.cpp:1057] Killing task 4fee2fec-12b5-4af6-bd70-e67b4da26c00 running in child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18 with SIGTERM signal
> I1030 21:47:58.354825 22365 default_executor.cpp:1079] Scheduling escalation to SIGKILL in 3secs from now
> I1030 21:47:58.355772 22365 default_executor.cpp:191] Received KILL event
> I1030 21:47:58.355819 22365 default_executor.cpp:1172] Received kill for task '24695aee-aa59-4295-8ad9-19f17ad9d52b'
> I1030 21:47:58.355947 22365 default_executor.cpp:1057] Killing task 24695aee-aa59-4295-8ad9-19f17ad9d52b running in child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 with SIGTERM signal
> I1030 21:47:58.355980 22365 default_executor.cpp:1079] Scheduling escalation to SIGKILL in 3secs from now
> I1030 21:47:58.467401 22380 default_executor.cpp:888] Child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18 of task '4fee2fec-12b5-4af6-bd70-e67b4da26c00' completed in state TASK_KILLED: Command terminated with signal Terminated
> I1030 21:47:58.467478 22380 default_executor.cpp:924] Killing task group containing tasks [ 4fee2fec-12b5-4af6-bd70-e67b4da26c00, 24695aee-aa59-4295-8ad9-19f17ad9d52b ]
> I1030 21:47:58.467888 22380 default_executor.cpp:888] Child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 of task '24695aee-aa59-4295-8ad9-19f17ad9d52b' completed in state TASK_KILLED: Command terminated with signal Terminated
> I1030 21:47:58.467934 22380 default_executor.cpp:1017] Terminating after 1secs
> [ OK ] MesosContainerizer/DefaultExecutorTest.KillMultipleTasks/0 (922 ms)
>
>
> [ RUN ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillMultipleTasks/0
> I1030 21:51:07.645311 25065 executor.cpp:192] Version: 1.5.0
> I1030 21:51:07.665602 25086 default_executor.cpp:191] Received SUBSCRIBED event
> I1030 21:51:07.667804 25086 default_executor.cpp:195] Subscribed executor on core-dev
> I1030 21:51:07.668308 25086 default_executor.cpp:191] Received LAUNCH_GROUP event
> I1030 21:51:07.669232 25093 default_executor.cpp:402] Setting 'MESOS_CONTAINER_IP' to: 10.0.49.2
> I1030 21:51:07.684146 25060 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:51:07.685752 25071 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:51:07.730559 25077 default_executor.cpp:640] Successfully launched tasks [ fce3ed1c-d93a-4b6f-8950-771a989b279b, 2e1b7db2-5f05-4474-bd5e-00c03468db71 ] in child containers [ 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.6ee13669-0de9-41b6-bde9-9f581b3e9c2e, 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.d11330e3-4f3a-4686-be5f-935ec8f44111 ]
> I1030 21:51:07.732921 25089 default_executor.cpp:713] Waiting for child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.6ee13669-0de9-41b6-bde9-9f581b3e9c2e of task 'fce3ed1c-d93a-4b6f-8950-771a989b279b'
> I1030 21:51:07.733170 25089 default_executor.cpp:713] Waiting for child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.d11330e3-4f3a-4686-be5f-935ec8f44111 of task '2e1b7db2-5f05-4474-bd5e-00c03468db71'
> I1030 21:51:07.776757 25056 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:51:07.777101 25062 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:51:07.824290 25065 default_executor.cpp:191] Received KILL event
> I1030 21:51:07.824533 25065 default_executor.cpp:1172] Received kill for task 'fce3ed1c-d93a-4b6f-8950-771a989b279b'
> I1030 21:51:07.824579 25065 default_executor.cpp:1057] Killing task fce3ed1c-d93a-4b6f-8950-771a989b279b running in child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.6ee13669-0de9-41b6-bde9-9f581b3e9c2e with SIGTERM signal
> I1030 21:51:07.824606 25065 default_executor.cpp:1079] Scheduling escalation to SIGKILL in 3secs from now
> I1030 21:51:07.825533 25065 default_executor.cpp:191] Received KILL event
> I1030 21:51:07.825597 25065 default_executor.cpp:1172] Received kill for task '2e1b7db2-5f05-4474-bd5e-00c03468db71'
> I1030 21:51:07.825647 25065 default_executor.cpp:1057] Killing task 2e1b7db2-5f05-4474-bd5e-00c03468db71 running in child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.d11330e3-4f3a-4686-be5f-935ec8f44111 with SIGTERM signal
> I1030 21:51:07.825690 25065 default_executor.cpp:1079] Scheduling escalation to SIGKILL in 3secs from now
> I1030 21:51:07.957986 25083 default_executor.cpp:888] Child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.6ee13669-0de9-41b6-bde9-9f581b3e9c2e of task 'fce3ed1c-d93a-4b6f-8950-771a989b279b' completed in state TASK_KILLED: Command terminated with signal Terminated
> I1030 21:51:07.958062 25083 default_executor.cpp:924] Killing task group containing tasks [ fce3ed1c-d93a-4b6f-8950-771a989b279b, 2e1b7db2-5f05-4474-bd5e-00c03468db71 ]
> I1030 21:51:07.958566 25083 default_executor.cpp:888] Child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.d11330e3-4f3a-4686-be5f-935ec8f44111 of task '2e1b7db2-5f05-4474-bd5e-00c03468db71' completed in state TASK_KILLED: Command terminated with signal Terminated
> I1030 21:51:07.958626 25083 default_executor.cpp:1017] Terminating after 1secs
> [ OK ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillMultipleTasks/0 (9200 ms)
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 62837: Added a test
`DefaultExecutorTest.KillMultipleTasks`.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On Nov. 1, 2017, 3 p.m., Gaston Kleiman wrote:
> > src/tests/default_executor_tests.cpp
> > Lines 538-548 (patched)
> > <https://reviews.apache.org/r/62837/diff/2/?file=1873334#file1873334line538>
> >
> > This is racy; there's no guarantee that the first `TASK_RUNNING` status update will come after the second `TASK_STARTING` update.
> >
> > The following ordering would also be possible: [`TASK_STARTING`, `TASK_RUNNING`, `TASK_STARTING`, `TASK_RUNNING`, ...]
To simplify the logic here, let's introduce a matcher in our tests, something like
```
MATCHER_P(TaskStateEq, state, "") { return arg.state() == state; }
```
which we then can use like
```
Future<TaskStatus> status;
EXPECT_CALL(sched, statusUpdate(&driver, TaskStateEq(TASK_RUNNING)))
.WillOnce(FutureArg<1>(&status));
```
Then you can combine both task state and task id matchers to get an exact status update.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62837/#review189800
-----------------------------------------------------------
On Oct. 31, 2017, 4:53 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62837/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2017, 4:53 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-8051
> https://issues.apache.org/jira/browse/MESOS-8051
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `DefaultExecutorTest.KillMultipleTasks`.
>
>
> Diffs
> -----
>
> src/tests/default_executor_tests.cpp 5078bd4d70698f5cbd14c971fcecfd58f8467a04
>
>
> Diff: https://reviews.apache.org/r/62837/diff/2/
>
>
> Testing
> -------
>
> [ RUN ] MesosContainerizer/DefaultExecutorTest.KillMultipleTasks/0
> I1030 21:47:58.181413 22360 executor.cpp:192] Version: 1.5.0
> I1030 21:47:58.201525 22382 default_executor.cpp:191] Received SUBSCRIBED event
> I1030 21:47:58.203812 22382 default_executor.cpp:195] Subscribed executor on core-dev
> I1030 21:47:58.204406 22382 default_executor.cpp:191] Received LAUNCH_GROUP event
> I1030 21:47:58.205346 22390 default_executor.cpp:402] Setting 'MESOS_CONTAINER_IP' to: 10.0.49.2
> I1030 21:47:58.220854 22356 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:47:58.221959 22367 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:47:58.261060 22370 default_executor.cpp:640] Successfully launched tasks [ 4fee2fec-12b5-4af6-bd70-e67b4da26c00, 24695aee-aa59-4295-8ad9-19f17ad9d52b ] in child containers [ 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18, 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 ]
> I1030 21:47:58.263293 22385 default_executor.cpp:713] Waiting for child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18 of task '4fee2fec-12b5-4af6-bd70-e67b4da26c00'
> I1030 21:47:58.263546 22385 default_executor.cpp:713] Waiting for child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 of task '24695aee-aa59-4295-8ad9-19f17ad9d52b'
> I1030 21:47:58.307412 22351 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:47:58.307924 22358 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:47:58.354656 22365 default_executor.cpp:191] Received KILL event
> I1030 21:47:58.354730 22365 default_executor.cpp:1172] Received kill for task '4fee2fec-12b5-4af6-bd70-e67b4da26c00'
> I1030 21:47:58.354787 22365 default_executor.cpp:1057] Killing task 4fee2fec-12b5-4af6-bd70-e67b4da26c00 running in child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18 with SIGTERM signal
> I1030 21:47:58.354825 22365 default_executor.cpp:1079] Scheduling escalation to SIGKILL in 3secs from now
> I1030 21:47:58.355772 22365 default_executor.cpp:191] Received KILL event
> I1030 21:47:58.355819 22365 default_executor.cpp:1172] Received kill for task '24695aee-aa59-4295-8ad9-19f17ad9d52b'
> I1030 21:47:58.355947 22365 default_executor.cpp:1057] Killing task 24695aee-aa59-4295-8ad9-19f17ad9d52b running in child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 with SIGTERM signal
> I1030 21:47:58.355980 22365 default_executor.cpp:1079] Scheduling escalation to SIGKILL in 3secs from now
> I1030 21:47:58.467401 22380 default_executor.cpp:888] Child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18 of task '4fee2fec-12b5-4af6-bd70-e67b4da26c00' completed in state TASK_KILLED: Command terminated with signal Terminated
> I1030 21:47:58.467478 22380 default_executor.cpp:924] Killing task group containing tasks [ 4fee2fec-12b5-4af6-bd70-e67b4da26c00, 24695aee-aa59-4295-8ad9-19f17ad9d52b ]
> I1030 21:47:58.467888 22380 default_executor.cpp:888] Child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 of task '24695aee-aa59-4295-8ad9-19f17ad9d52b' completed in state TASK_KILLED: Command terminated with signal Terminated
> I1030 21:47:58.467934 22380 default_executor.cpp:1017] Terminating after 1secs
> [ OK ] MesosContainerizer/DefaultExecutorTest.KillMultipleTasks/0 (922 ms)
>
>
> [ RUN ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillMultipleTasks/0
> I1030 21:51:07.645311 25065 executor.cpp:192] Version: 1.5.0
> I1030 21:51:07.665602 25086 default_executor.cpp:191] Received SUBSCRIBED event
> I1030 21:51:07.667804 25086 default_executor.cpp:195] Subscribed executor on core-dev
> I1030 21:51:07.668308 25086 default_executor.cpp:191] Received LAUNCH_GROUP event
> I1030 21:51:07.669232 25093 default_executor.cpp:402] Setting 'MESOS_CONTAINER_IP' to: 10.0.49.2
> I1030 21:51:07.684146 25060 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:51:07.685752 25071 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:51:07.730559 25077 default_executor.cpp:640] Successfully launched tasks [ fce3ed1c-d93a-4b6f-8950-771a989b279b, 2e1b7db2-5f05-4474-bd5e-00c03468db71 ] in child containers [ 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.6ee13669-0de9-41b6-bde9-9f581b3e9c2e, 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.d11330e3-4f3a-4686-be5f-935ec8f44111 ]
> I1030 21:51:07.732921 25089 default_executor.cpp:713] Waiting for child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.6ee13669-0de9-41b6-bde9-9f581b3e9c2e of task 'fce3ed1c-d93a-4b6f-8950-771a989b279b'
> I1030 21:51:07.733170 25089 default_executor.cpp:713] Waiting for child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.d11330e3-4f3a-4686-be5f-935ec8f44111 of task '2e1b7db2-5f05-4474-bd5e-00c03468db71'
> I1030 21:51:07.776757 25056 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:51:07.777101 25062 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:51:07.824290 25065 default_executor.cpp:191] Received KILL event
> I1030 21:51:07.824533 25065 default_executor.cpp:1172] Received kill for task 'fce3ed1c-d93a-4b6f-8950-771a989b279b'
> I1030 21:51:07.824579 25065 default_executor.cpp:1057] Killing task fce3ed1c-d93a-4b6f-8950-771a989b279b running in child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.6ee13669-0de9-41b6-bde9-9f581b3e9c2e with SIGTERM signal
> I1030 21:51:07.824606 25065 default_executor.cpp:1079] Scheduling escalation to SIGKILL in 3secs from now
> I1030 21:51:07.825533 25065 default_executor.cpp:191] Received KILL event
> I1030 21:51:07.825597 25065 default_executor.cpp:1172] Received kill for task '2e1b7db2-5f05-4474-bd5e-00c03468db71'
> I1030 21:51:07.825647 25065 default_executor.cpp:1057] Killing task 2e1b7db2-5f05-4474-bd5e-00c03468db71 running in child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.d11330e3-4f3a-4686-be5f-935ec8f44111 with SIGTERM signal
> I1030 21:51:07.825690 25065 default_executor.cpp:1079] Scheduling escalation to SIGKILL in 3secs from now
> I1030 21:51:07.957986 25083 default_executor.cpp:888] Child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.6ee13669-0de9-41b6-bde9-9f581b3e9c2e of task 'fce3ed1c-d93a-4b6f-8950-771a989b279b' completed in state TASK_KILLED: Command terminated with signal Terminated
> I1030 21:51:07.958062 25083 default_executor.cpp:924] Killing task group containing tasks [ fce3ed1c-d93a-4b6f-8950-771a989b279b, 2e1b7db2-5f05-4474-bd5e-00c03468db71 ]
> I1030 21:51:07.958566 25083 default_executor.cpp:888] Child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.d11330e3-4f3a-4686-be5f-935ec8f44111 of task '2e1b7db2-5f05-4474-bd5e-00c03468db71' completed in state TASK_KILLED: Command terminated with signal Terminated
> I1030 21:51:07.958626 25083 default_executor.cpp:1017] Terminating after 1secs
> [ OK ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillMultipleTasks/0 (9200 ms)
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 62837: Added a test
`DefaultExecutorTest.KillMultipleTasks`.
Posted by Qian Zhang <zh...@gmail.com>.
> On Nov. 1, 2017, 11 p.m., Gaston Kleiman wrote:
> > src/tests/default_executor_tests.cpp
> > Lines 538-548 (patched)
> > <https://reviews.apache.org/r/62837/diff/2/?file=1873334#file1873334line538>
> >
> > This is racy; there's no guarantee that the first `TASK_RUNNING` status update will come after the second `TASK_STARTING` update.
> >
> > The following ordering would also be possible: [`TASK_STARTING`, `TASK_RUNNING`, `TASK_STARTING`, `TASK_RUNNING`, ...]
>
> Alexander Rukletsov wrote:
> To simplify the logic here, let's introduce a matcher in our tests, something like
> ```
> MATCHER_P(TaskStateEq, state, "") { return arg.state() == state; }
> ```
> which we then can use like
> ```
> Future<TaskStatus> status;
> EXPECT_CALL(sched, statusUpdate(&driver, TaskStateEq(TASK_RUNNING)))
> .WillOnce(FutureArg<1>(&status));
> ```
> Then you can combine both task state and task id matchers to get an exact status update.
>
> Gaston Kleiman wrote:
> AlexR suggested something like this:
>
> ```
> Sequence task1;
> EXPECT_CALL(
> *scheduler,
> update(_, AllOf(TaskStatusEq(TASK_STARTING), TaskStateEq(taskInfo1))))
> .InSequence(task1)
> .WillOnce(
> DoAll(
> FutureArg<1>(&startingUpdate1),
> v1::scheduler::SendAcknowledge(frameworkId, agentId)));
>
> EXPECT_CALL(
> *scheduler,
> update(_, AllOf(TaskStatusEq(TASK_RUNNING), TaskStateEq(taskInfo1))))
> .InSequence(task1)
> .WillOnce(
> DoAll(
> FutureArg<1>(&runningUpdate1),
> v1::scheduler::SendAcknowledge(frameworkId, agentId)));
>
> Sequence task2;
> EXPECT_CALL(
> *scheduler,
> update(_, AllOf(TaskStatusEq(TASK_STARTING), TaskStateEq(taskInfo2))))
> .InSequence(task2)
> .WillOnce(
> DoAll(
> FutureArg<1>(&startingUpdate2),
> v1::scheduler::SendAcknowledge(frameworkId, agentId)));
>
> EXPECT_CALL(
> *scheduler,
> update(_, AllOf(TaskStatusEq(TASK_RUNNING), TaskStateEq(taskInfo2))))
> .InSequence(task2)
> .WillOnce(
> DoAll(
> FutureArg<1>(&runningUpdate2),
> v1::scheduler::SendAcknowledge(frameworkId, agentId)));
>
> AWAIT_READY(startingUpdate1);
> AWAIT_READY(runningUpdate1);
>
> AWAIT_READY(startingUpdate2);
> AWAIT_READY(runningUpdate2);
> ```
>
> Alexander Rukletsov wrote:
> Parameters are mixed up : )
> `AllOf(TaskStatusEq(<taskInfo>), TaskStateEq(<TASK_STATE>))`
> Also feel free to refactor `TaskStatusEq` to take an id if you think it is simpler.
>
> Qian Zhang wrote:
> So I think we also have this race for the test `DefaultExecutorTest.KillTaskGroupOnTaskFailure`? See the code here: https://github.com/apache/mesos/blob/master/src/tests/default_executor_tests.cpp#L649:L670
>
> And it seems the test `DefaultExecutorTest.KillTask` (https://github.com/apache/mesos/blob/master/src/tests/default_executor_tests.cpp#L301:L355) handles such race, so what about we follow that way?
>
> Gaston Kleiman wrote:
> The `TASK_STARTING` handling in https://github.com/apache/mesos/blob/master/src/tests/default_executor_tests.cpp#L301:L355 is a recent change, and I must say that I am not very happy with it.
>
> It has the following flaws:
>
> - It doesn't check the task IDs of the updates.
> - It only checks two of the four expected updates, so it doesn't ensure that tasks correctly transition from `TASK_STARTING` to `TASK_RUNNING`.
>
> I'd prefer to follow AlexR's suggestion or what we do in `DefaultExecutorTest.CommitSuicideOnKillTask`: https://github.com/apache/mesos/blob/11538e4179217f0cd891f848b1221ad13b88a50a/src/tests/default_executor_tests.cpp#L1124-L1175
Agree, let's go with AlexR's suggestion. I posted a patch for it here: https://reviews.apache.org/r/63577/.
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62837/#review189800
-----------------------------------------------------------
On Oct. 31, 2017, 12:53 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62837/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2017, 12:53 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-8051
> https://issues.apache.org/jira/browse/MESOS-8051
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `DefaultExecutorTest.KillMultipleTasks`.
>
>
> Diffs
> -----
>
> src/tests/default_executor_tests.cpp 5078bd4d70698f5cbd14c971fcecfd58f8467a04
>
>
> Diff: https://reviews.apache.org/r/62837/diff/2/
>
>
> Testing
> -------
>
> [ RUN ] MesosContainerizer/DefaultExecutorTest.KillMultipleTasks/0
> I1030 21:47:58.181413 22360 executor.cpp:192] Version: 1.5.0
> I1030 21:47:58.201525 22382 default_executor.cpp:191] Received SUBSCRIBED event
> I1030 21:47:58.203812 22382 default_executor.cpp:195] Subscribed executor on core-dev
> I1030 21:47:58.204406 22382 default_executor.cpp:191] Received LAUNCH_GROUP event
> I1030 21:47:58.205346 22390 default_executor.cpp:402] Setting 'MESOS_CONTAINER_IP' to: 10.0.49.2
> I1030 21:47:58.220854 22356 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:47:58.221959 22367 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:47:58.261060 22370 default_executor.cpp:640] Successfully launched tasks [ 4fee2fec-12b5-4af6-bd70-e67b4da26c00, 24695aee-aa59-4295-8ad9-19f17ad9d52b ] in child containers [ 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18, 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 ]
> I1030 21:47:58.263293 22385 default_executor.cpp:713] Waiting for child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18 of task '4fee2fec-12b5-4af6-bd70-e67b4da26c00'
> I1030 21:47:58.263546 22385 default_executor.cpp:713] Waiting for child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 of task '24695aee-aa59-4295-8ad9-19f17ad9d52b'
> I1030 21:47:58.307412 22351 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:47:58.307924 22358 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:47:58.354656 22365 default_executor.cpp:191] Received KILL event
> I1030 21:47:58.354730 22365 default_executor.cpp:1172] Received kill for task '4fee2fec-12b5-4af6-bd70-e67b4da26c00'
> I1030 21:47:58.354787 22365 default_executor.cpp:1057] Killing task 4fee2fec-12b5-4af6-bd70-e67b4da26c00 running in child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18 with SIGTERM signal
> I1030 21:47:58.354825 22365 default_executor.cpp:1079] Scheduling escalation to SIGKILL in 3secs from now
> I1030 21:47:58.355772 22365 default_executor.cpp:191] Received KILL event
> I1030 21:47:58.355819 22365 default_executor.cpp:1172] Received kill for task '24695aee-aa59-4295-8ad9-19f17ad9d52b'
> I1030 21:47:58.355947 22365 default_executor.cpp:1057] Killing task 24695aee-aa59-4295-8ad9-19f17ad9d52b running in child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 with SIGTERM signal
> I1030 21:47:58.355980 22365 default_executor.cpp:1079] Scheduling escalation to SIGKILL in 3secs from now
> I1030 21:47:58.467401 22380 default_executor.cpp:888] Child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18 of task '4fee2fec-12b5-4af6-bd70-e67b4da26c00' completed in state TASK_KILLED: Command terminated with signal Terminated
> I1030 21:47:58.467478 22380 default_executor.cpp:924] Killing task group containing tasks [ 4fee2fec-12b5-4af6-bd70-e67b4da26c00, 24695aee-aa59-4295-8ad9-19f17ad9d52b ]
> I1030 21:47:58.467888 22380 default_executor.cpp:888] Child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 of task '24695aee-aa59-4295-8ad9-19f17ad9d52b' completed in state TASK_KILLED: Command terminated with signal Terminated
> I1030 21:47:58.467934 22380 default_executor.cpp:1017] Terminating after 1secs
> [ OK ] MesosContainerizer/DefaultExecutorTest.KillMultipleTasks/0 (922 ms)
>
>
> [ RUN ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillMultipleTasks/0
> I1030 21:51:07.645311 25065 executor.cpp:192] Version: 1.5.0
> I1030 21:51:07.665602 25086 default_executor.cpp:191] Received SUBSCRIBED event
> I1030 21:51:07.667804 25086 default_executor.cpp:195] Subscribed executor on core-dev
> I1030 21:51:07.668308 25086 default_executor.cpp:191] Received LAUNCH_GROUP event
> I1030 21:51:07.669232 25093 default_executor.cpp:402] Setting 'MESOS_CONTAINER_IP' to: 10.0.49.2
> I1030 21:51:07.684146 25060 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:51:07.685752 25071 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:51:07.730559 25077 default_executor.cpp:640] Successfully launched tasks [ fce3ed1c-d93a-4b6f-8950-771a989b279b, 2e1b7db2-5f05-4474-bd5e-00c03468db71 ] in child containers [ 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.6ee13669-0de9-41b6-bde9-9f581b3e9c2e, 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.d11330e3-4f3a-4686-be5f-935ec8f44111 ]
> I1030 21:51:07.732921 25089 default_executor.cpp:713] Waiting for child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.6ee13669-0de9-41b6-bde9-9f581b3e9c2e of task 'fce3ed1c-d93a-4b6f-8950-771a989b279b'
> I1030 21:51:07.733170 25089 default_executor.cpp:713] Waiting for child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.d11330e3-4f3a-4686-be5f-935ec8f44111 of task '2e1b7db2-5f05-4474-bd5e-00c03468db71'
> I1030 21:51:07.776757 25056 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:51:07.777101 25062 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:51:07.824290 25065 default_executor.cpp:191] Received KILL event
> I1030 21:51:07.824533 25065 default_executor.cpp:1172] Received kill for task 'fce3ed1c-d93a-4b6f-8950-771a989b279b'
> I1030 21:51:07.824579 25065 default_executor.cpp:1057] Killing task fce3ed1c-d93a-4b6f-8950-771a989b279b running in child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.6ee13669-0de9-41b6-bde9-9f581b3e9c2e with SIGTERM signal
> I1030 21:51:07.824606 25065 default_executor.cpp:1079] Scheduling escalation to SIGKILL in 3secs from now
> I1030 21:51:07.825533 25065 default_executor.cpp:191] Received KILL event
> I1030 21:51:07.825597 25065 default_executor.cpp:1172] Received kill for task '2e1b7db2-5f05-4474-bd5e-00c03468db71'
> I1030 21:51:07.825647 25065 default_executor.cpp:1057] Killing task 2e1b7db2-5f05-4474-bd5e-00c03468db71 running in child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.d11330e3-4f3a-4686-be5f-935ec8f44111 with SIGTERM signal
> I1030 21:51:07.825690 25065 default_executor.cpp:1079] Scheduling escalation to SIGKILL in 3secs from now
> I1030 21:51:07.957986 25083 default_executor.cpp:888] Child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.6ee13669-0de9-41b6-bde9-9f581b3e9c2e of task 'fce3ed1c-d93a-4b6f-8950-771a989b279b' completed in state TASK_KILLED: Command terminated with signal Terminated
> I1030 21:51:07.958062 25083 default_executor.cpp:924] Killing task group containing tasks [ fce3ed1c-d93a-4b6f-8950-771a989b279b, 2e1b7db2-5f05-4474-bd5e-00c03468db71 ]
> I1030 21:51:07.958566 25083 default_executor.cpp:888] Child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.d11330e3-4f3a-4686-be5f-935ec8f44111 of task '2e1b7db2-5f05-4474-bd5e-00c03468db71' completed in state TASK_KILLED: Command terminated with signal Terminated
> I1030 21:51:07.958626 25083 default_executor.cpp:1017] Terminating after 1secs
> [ OK ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillMultipleTasks/0 (9200 ms)
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 62837: Added a test
`DefaultExecutorTest.KillMultipleTasks`.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
> On Nov. 1, 2017, 8 a.m., Gaston Kleiman wrote:
> > src/tests/default_executor_tests.cpp
> > Lines 538-548 (patched)
> > <https://reviews.apache.org/r/62837/diff/2/?file=1873334#file1873334line538>
> >
> > This is racy; there's no guarantee that the first `TASK_RUNNING` status update will come after the second `TASK_STARTING` update.
> >
> > The following ordering would also be possible: [`TASK_STARTING`, `TASK_RUNNING`, `TASK_STARTING`, `TASK_RUNNING`, ...]
>
> Alexander Rukletsov wrote:
> To simplify the logic here, let's introduce a matcher in our tests, something like
> ```
> MATCHER_P(TaskStateEq, state, "") { return arg.state() == state; }
> ```
> which we then can use like
> ```
> Future<TaskStatus> status;
> EXPECT_CALL(sched, statusUpdate(&driver, TaskStateEq(TASK_RUNNING)))
> .WillOnce(FutureArg<1>(&status));
> ```
> Then you can combine both task state and task id matchers to get an exact status update.
AlexR suggested something like this:
```
Sequence task1;
EXPECT_CALL(
*scheduler,
update(_, AllOf(TaskStatusEq(TASK_STARTING), TaskStateEq(taskInfo1))))
.InSequence(task1)
.WillOnce(
DoAll(
FutureArg<1>(&startingUpdate1),
v1::scheduler::SendAcknowledge(frameworkId, agentId)));
EXPECT_CALL(
*scheduler,
update(_, AllOf(TaskStatusEq(TASK_RUNNING), TaskStateEq(taskInfo1))))
.InSequence(task1)
.WillOnce(
DoAll(
FutureArg<1>(&runningUpdate1),
v1::scheduler::SendAcknowledge(frameworkId, agentId)));
Sequence task2;
EXPECT_CALL(
*scheduler,
update(_, AllOf(TaskStatusEq(TASK_STARTING), TaskStateEq(taskInfo2))))
.InSequence(task2)
.WillOnce(
DoAll(
FutureArg<1>(&startingUpdate2),
v1::scheduler::SendAcknowledge(frameworkId, agentId)));
EXPECT_CALL(
*scheduler,
update(_, AllOf(TaskStatusEq(TASK_RUNNING), TaskStateEq(taskInfo2))))
.InSequence(task2)
.WillOnce(
DoAll(
FutureArg<1>(&runningUpdate2),
v1::scheduler::SendAcknowledge(frameworkId, agentId)));
AWAIT_READY(startingUpdate1);
AWAIT_READY(runningUpdate1);
AWAIT_READY(startingUpdate2);
AWAIT_READY(runningUpdate2);
```
- Gaston
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62837/#review189800
-----------------------------------------------------------
On Oct. 30, 2017, 9:53 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62837/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2017, 9:53 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-8051
> https://issues.apache.org/jira/browse/MESOS-8051
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `DefaultExecutorTest.KillMultipleTasks`.
>
>
> Diffs
> -----
>
> src/tests/default_executor_tests.cpp 5078bd4d70698f5cbd14c971fcecfd58f8467a04
>
>
> Diff: https://reviews.apache.org/r/62837/diff/2/
>
>
> Testing
> -------
>
> [ RUN ] MesosContainerizer/DefaultExecutorTest.KillMultipleTasks/0
> I1030 21:47:58.181413 22360 executor.cpp:192] Version: 1.5.0
> I1030 21:47:58.201525 22382 default_executor.cpp:191] Received SUBSCRIBED event
> I1030 21:47:58.203812 22382 default_executor.cpp:195] Subscribed executor on core-dev
> I1030 21:47:58.204406 22382 default_executor.cpp:191] Received LAUNCH_GROUP event
> I1030 21:47:58.205346 22390 default_executor.cpp:402] Setting 'MESOS_CONTAINER_IP' to: 10.0.49.2
> I1030 21:47:58.220854 22356 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:47:58.221959 22367 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:47:58.261060 22370 default_executor.cpp:640] Successfully launched tasks [ 4fee2fec-12b5-4af6-bd70-e67b4da26c00, 24695aee-aa59-4295-8ad9-19f17ad9d52b ] in child containers [ 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18, 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 ]
> I1030 21:47:58.263293 22385 default_executor.cpp:713] Waiting for child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18 of task '4fee2fec-12b5-4af6-bd70-e67b4da26c00'
> I1030 21:47:58.263546 22385 default_executor.cpp:713] Waiting for child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 of task '24695aee-aa59-4295-8ad9-19f17ad9d52b'
> I1030 21:47:58.307412 22351 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:47:58.307924 22358 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:47:58.354656 22365 default_executor.cpp:191] Received KILL event
> I1030 21:47:58.354730 22365 default_executor.cpp:1172] Received kill for task '4fee2fec-12b5-4af6-bd70-e67b4da26c00'
> I1030 21:47:58.354787 22365 default_executor.cpp:1057] Killing task 4fee2fec-12b5-4af6-bd70-e67b4da26c00 running in child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18 with SIGTERM signal
> I1030 21:47:58.354825 22365 default_executor.cpp:1079] Scheduling escalation to SIGKILL in 3secs from now
> I1030 21:47:58.355772 22365 default_executor.cpp:191] Received KILL event
> I1030 21:47:58.355819 22365 default_executor.cpp:1172] Received kill for task '24695aee-aa59-4295-8ad9-19f17ad9d52b'
> I1030 21:47:58.355947 22365 default_executor.cpp:1057] Killing task 24695aee-aa59-4295-8ad9-19f17ad9d52b running in child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 with SIGTERM signal
> I1030 21:47:58.355980 22365 default_executor.cpp:1079] Scheduling escalation to SIGKILL in 3secs from now
> I1030 21:47:58.467401 22380 default_executor.cpp:888] Child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18 of task '4fee2fec-12b5-4af6-bd70-e67b4da26c00' completed in state TASK_KILLED: Command terminated with signal Terminated
> I1030 21:47:58.467478 22380 default_executor.cpp:924] Killing task group containing tasks [ 4fee2fec-12b5-4af6-bd70-e67b4da26c00, 24695aee-aa59-4295-8ad9-19f17ad9d52b ]
> I1030 21:47:58.467888 22380 default_executor.cpp:888] Child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 of task '24695aee-aa59-4295-8ad9-19f17ad9d52b' completed in state TASK_KILLED: Command terminated with signal Terminated
> I1030 21:47:58.467934 22380 default_executor.cpp:1017] Terminating after 1secs
> [ OK ] MesosContainerizer/DefaultExecutorTest.KillMultipleTasks/0 (922 ms)
>
>
> [ RUN ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillMultipleTasks/0
> I1030 21:51:07.645311 25065 executor.cpp:192] Version: 1.5.0
> I1030 21:51:07.665602 25086 default_executor.cpp:191] Received SUBSCRIBED event
> I1030 21:51:07.667804 25086 default_executor.cpp:195] Subscribed executor on core-dev
> I1030 21:51:07.668308 25086 default_executor.cpp:191] Received LAUNCH_GROUP event
> I1030 21:51:07.669232 25093 default_executor.cpp:402] Setting 'MESOS_CONTAINER_IP' to: 10.0.49.2
> I1030 21:51:07.684146 25060 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:51:07.685752 25071 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:51:07.730559 25077 default_executor.cpp:640] Successfully launched tasks [ fce3ed1c-d93a-4b6f-8950-771a989b279b, 2e1b7db2-5f05-4474-bd5e-00c03468db71 ] in child containers [ 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.6ee13669-0de9-41b6-bde9-9f581b3e9c2e, 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.d11330e3-4f3a-4686-be5f-935ec8f44111 ]
> I1030 21:51:07.732921 25089 default_executor.cpp:713] Waiting for child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.6ee13669-0de9-41b6-bde9-9f581b3e9c2e of task 'fce3ed1c-d93a-4b6f-8950-771a989b279b'
> I1030 21:51:07.733170 25089 default_executor.cpp:713] Waiting for child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.d11330e3-4f3a-4686-be5f-935ec8f44111 of task '2e1b7db2-5f05-4474-bd5e-00c03468db71'
> I1030 21:51:07.776757 25056 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:51:07.777101 25062 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:51:07.824290 25065 default_executor.cpp:191] Received KILL event
> I1030 21:51:07.824533 25065 default_executor.cpp:1172] Received kill for task 'fce3ed1c-d93a-4b6f-8950-771a989b279b'
> I1030 21:51:07.824579 25065 default_executor.cpp:1057] Killing task fce3ed1c-d93a-4b6f-8950-771a989b279b running in child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.6ee13669-0de9-41b6-bde9-9f581b3e9c2e with SIGTERM signal
> I1030 21:51:07.824606 25065 default_executor.cpp:1079] Scheduling escalation to SIGKILL in 3secs from now
> I1030 21:51:07.825533 25065 default_executor.cpp:191] Received KILL event
> I1030 21:51:07.825597 25065 default_executor.cpp:1172] Received kill for task '2e1b7db2-5f05-4474-bd5e-00c03468db71'
> I1030 21:51:07.825647 25065 default_executor.cpp:1057] Killing task 2e1b7db2-5f05-4474-bd5e-00c03468db71 running in child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.d11330e3-4f3a-4686-be5f-935ec8f44111 with SIGTERM signal
> I1030 21:51:07.825690 25065 default_executor.cpp:1079] Scheduling escalation to SIGKILL in 3secs from now
> I1030 21:51:07.957986 25083 default_executor.cpp:888] Child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.6ee13669-0de9-41b6-bde9-9f581b3e9c2e of task 'fce3ed1c-d93a-4b6f-8950-771a989b279b' completed in state TASK_KILLED: Command terminated with signal Terminated
> I1030 21:51:07.958062 25083 default_executor.cpp:924] Killing task group containing tasks [ fce3ed1c-d93a-4b6f-8950-771a989b279b, 2e1b7db2-5f05-4474-bd5e-00c03468db71 ]
> I1030 21:51:07.958566 25083 default_executor.cpp:888] Child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.d11330e3-4f3a-4686-be5f-935ec8f44111 of task '2e1b7db2-5f05-4474-bd5e-00c03468db71' completed in state TASK_KILLED: Command terminated with signal Terminated
> I1030 21:51:07.958626 25083 default_executor.cpp:1017] Terminating after 1secs
> [ OK ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillMultipleTasks/0 (9200 ms)
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 62837: Added a test
`DefaultExecutorTest.KillMultipleTasks`.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
> On Nov. 1, 2017, 8 a.m., Gaston Kleiman wrote:
> > src/tests/default_executor_tests.cpp
> > Lines 538-548 (patched)
> > <https://reviews.apache.org/r/62837/diff/2/?file=1873334#file1873334line538>
> >
> > This is racy; there's no guarantee that the first `TASK_RUNNING` status update will come after the second `TASK_STARTING` update.
> >
> > The following ordering would also be possible: [`TASK_STARTING`, `TASK_RUNNING`, `TASK_STARTING`, `TASK_RUNNING`, ...]
>
> Alexander Rukletsov wrote:
> To simplify the logic here, let's introduce a matcher in our tests, something like
> ```
> MATCHER_P(TaskStateEq, state, "") { return arg.state() == state; }
> ```
> which we then can use like
> ```
> Future<TaskStatus> status;
> EXPECT_CALL(sched, statusUpdate(&driver, TaskStateEq(TASK_RUNNING)))
> .WillOnce(FutureArg<1>(&status));
> ```
> Then you can combine both task state and task id matchers to get an exact status update.
>
> Gaston Kleiman wrote:
> AlexR suggested something like this:
>
> ```
> Sequence task1;
> EXPECT_CALL(
> *scheduler,
> update(_, AllOf(TaskStatusEq(TASK_STARTING), TaskStateEq(taskInfo1))))
> .InSequence(task1)
> .WillOnce(
> DoAll(
> FutureArg<1>(&startingUpdate1),
> v1::scheduler::SendAcknowledge(frameworkId, agentId)));
>
> EXPECT_CALL(
> *scheduler,
> update(_, AllOf(TaskStatusEq(TASK_RUNNING), TaskStateEq(taskInfo1))))
> .InSequence(task1)
> .WillOnce(
> DoAll(
> FutureArg<1>(&runningUpdate1),
> v1::scheduler::SendAcknowledge(frameworkId, agentId)));
>
> Sequence task2;
> EXPECT_CALL(
> *scheduler,
> update(_, AllOf(TaskStatusEq(TASK_STARTING), TaskStateEq(taskInfo2))))
> .InSequence(task2)
> .WillOnce(
> DoAll(
> FutureArg<1>(&startingUpdate2),
> v1::scheduler::SendAcknowledge(frameworkId, agentId)));
>
> EXPECT_CALL(
> *scheduler,
> update(_, AllOf(TaskStatusEq(TASK_RUNNING), TaskStateEq(taskInfo2))))
> .InSequence(task2)
> .WillOnce(
> DoAll(
> FutureArg<1>(&runningUpdate2),
> v1::scheduler::SendAcknowledge(frameworkId, agentId)));
>
> AWAIT_READY(startingUpdate1);
> AWAIT_READY(runningUpdate1);
>
> AWAIT_READY(startingUpdate2);
> AWAIT_READY(runningUpdate2);
> ```
>
> Alexander Rukletsov wrote:
> Parameters are mixed up : )
> `AllOf(TaskStatusEq(<taskInfo>), TaskStateEq(<TASK_STATE>))`
> Also feel free to refactor `TaskStatusEq` to take an id if you think it is simpler.
>
> Qian Zhang wrote:
> So I think we also have this race for the test `DefaultExecutorTest.KillTaskGroupOnTaskFailure`? See the code here: https://github.com/apache/mesos/blob/master/src/tests/default_executor_tests.cpp#L649:L670
>
> And it seems the test `DefaultExecutorTest.KillTask` (https://github.com/apache/mesos/blob/master/src/tests/default_executor_tests.cpp#L301:L355) handles such race, so what about we follow that way?
The `TASK_STARTING` handling in https://github.com/apache/mesos/blob/master/src/tests/default_executor_tests.cpp#L301:L355 is a recent change, and I must say that I am not very happy with it.
It has the following flaws:
- It doesn't check the task IDs of the updates.
- It only checks two of the four expected updates, so it doesn't ensure that tasks correctly transition from `TASK_STARTING` to `TASK_RUNNING`.
I'd prefer to follow AlexR's suggestion or what we do in `DefaultExecutorTest.CommitSuicideOnKillTask`: https://github.com/apache/mesos/blob/11538e4179217f0cd891f848b1221ad13b88a50a/src/tests/default_executor_tests.cpp#L1124-L1175
- Gaston
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62837/#review189800
-----------------------------------------------------------
On Oct. 30, 2017, 9:53 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62837/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2017, 9:53 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-8051
> https://issues.apache.org/jira/browse/MESOS-8051
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `DefaultExecutorTest.KillMultipleTasks`.
>
>
> Diffs
> -----
>
> src/tests/default_executor_tests.cpp 5078bd4d70698f5cbd14c971fcecfd58f8467a04
>
>
> Diff: https://reviews.apache.org/r/62837/diff/2/
>
>
> Testing
> -------
>
> [ RUN ] MesosContainerizer/DefaultExecutorTest.KillMultipleTasks/0
> I1030 21:47:58.181413 22360 executor.cpp:192] Version: 1.5.0
> I1030 21:47:58.201525 22382 default_executor.cpp:191] Received SUBSCRIBED event
> I1030 21:47:58.203812 22382 default_executor.cpp:195] Subscribed executor on core-dev
> I1030 21:47:58.204406 22382 default_executor.cpp:191] Received LAUNCH_GROUP event
> I1030 21:47:58.205346 22390 default_executor.cpp:402] Setting 'MESOS_CONTAINER_IP' to: 10.0.49.2
> I1030 21:47:58.220854 22356 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:47:58.221959 22367 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:47:58.261060 22370 default_executor.cpp:640] Successfully launched tasks [ 4fee2fec-12b5-4af6-bd70-e67b4da26c00, 24695aee-aa59-4295-8ad9-19f17ad9d52b ] in child containers [ 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18, 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 ]
> I1030 21:47:58.263293 22385 default_executor.cpp:713] Waiting for child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18 of task '4fee2fec-12b5-4af6-bd70-e67b4da26c00'
> I1030 21:47:58.263546 22385 default_executor.cpp:713] Waiting for child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 of task '24695aee-aa59-4295-8ad9-19f17ad9d52b'
> I1030 21:47:58.307412 22351 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:47:58.307924 22358 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:47:58.354656 22365 default_executor.cpp:191] Received KILL event
> I1030 21:47:58.354730 22365 default_executor.cpp:1172] Received kill for task '4fee2fec-12b5-4af6-bd70-e67b4da26c00'
> I1030 21:47:58.354787 22365 default_executor.cpp:1057] Killing task 4fee2fec-12b5-4af6-bd70-e67b4da26c00 running in child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18 with SIGTERM signal
> I1030 21:47:58.354825 22365 default_executor.cpp:1079] Scheduling escalation to SIGKILL in 3secs from now
> I1030 21:47:58.355772 22365 default_executor.cpp:191] Received KILL event
> I1030 21:47:58.355819 22365 default_executor.cpp:1172] Received kill for task '24695aee-aa59-4295-8ad9-19f17ad9d52b'
> I1030 21:47:58.355947 22365 default_executor.cpp:1057] Killing task 24695aee-aa59-4295-8ad9-19f17ad9d52b running in child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 with SIGTERM signal
> I1030 21:47:58.355980 22365 default_executor.cpp:1079] Scheduling escalation to SIGKILL in 3secs from now
> I1030 21:47:58.467401 22380 default_executor.cpp:888] Child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18 of task '4fee2fec-12b5-4af6-bd70-e67b4da26c00' completed in state TASK_KILLED: Command terminated with signal Terminated
> I1030 21:47:58.467478 22380 default_executor.cpp:924] Killing task group containing tasks [ 4fee2fec-12b5-4af6-bd70-e67b4da26c00, 24695aee-aa59-4295-8ad9-19f17ad9d52b ]
> I1030 21:47:58.467888 22380 default_executor.cpp:888] Child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 of task '24695aee-aa59-4295-8ad9-19f17ad9d52b' completed in state TASK_KILLED: Command terminated with signal Terminated
> I1030 21:47:58.467934 22380 default_executor.cpp:1017] Terminating after 1secs
> [ OK ] MesosContainerizer/DefaultExecutorTest.KillMultipleTasks/0 (922 ms)
>
>
> [ RUN ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillMultipleTasks/0
> I1030 21:51:07.645311 25065 executor.cpp:192] Version: 1.5.0
> I1030 21:51:07.665602 25086 default_executor.cpp:191] Received SUBSCRIBED event
> I1030 21:51:07.667804 25086 default_executor.cpp:195] Subscribed executor on core-dev
> I1030 21:51:07.668308 25086 default_executor.cpp:191] Received LAUNCH_GROUP event
> I1030 21:51:07.669232 25093 default_executor.cpp:402] Setting 'MESOS_CONTAINER_IP' to: 10.0.49.2
> I1030 21:51:07.684146 25060 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:51:07.685752 25071 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:51:07.730559 25077 default_executor.cpp:640] Successfully launched tasks [ fce3ed1c-d93a-4b6f-8950-771a989b279b, 2e1b7db2-5f05-4474-bd5e-00c03468db71 ] in child containers [ 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.6ee13669-0de9-41b6-bde9-9f581b3e9c2e, 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.d11330e3-4f3a-4686-be5f-935ec8f44111 ]
> I1030 21:51:07.732921 25089 default_executor.cpp:713] Waiting for child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.6ee13669-0de9-41b6-bde9-9f581b3e9c2e of task 'fce3ed1c-d93a-4b6f-8950-771a989b279b'
> I1030 21:51:07.733170 25089 default_executor.cpp:713] Waiting for child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.d11330e3-4f3a-4686-be5f-935ec8f44111 of task '2e1b7db2-5f05-4474-bd5e-00c03468db71'
> I1030 21:51:07.776757 25056 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:51:07.777101 25062 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:51:07.824290 25065 default_executor.cpp:191] Received KILL event
> I1030 21:51:07.824533 25065 default_executor.cpp:1172] Received kill for task 'fce3ed1c-d93a-4b6f-8950-771a989b279b'
> I1030 21:51:07.824579 25065 default_executor.cpp:1057] Killing task fce3ed1c-d93a-4b6f-8950-771a989b279b running in child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.6ee13669-0de9-41b6-bde9-9f581b3e9c2e with SIGTERM signal
> I1030 21:51:07.824606 25065 default_executor.cpp:1079] Scheduling escalation to SIGKILL in 3secs from now
> I1030 21:51:07.825533 25065 default_executor.cpp:191] Received KILL event
> I1030 21:51:07.825597 25065 default_executor.cpp:1172] Received kill for task '2e1b7db2-5f05-4474-bd5e-00c03468db71'
> I1030 21:51:07.825647 25065 default_executor.cpp:1057] Killing task 2e1b7db2-5f05-4474-bd5e-00c03468db71 running in child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.d11330e3-4f3a-4686-be5f-935ec8f44111 with SIGTERM signal
> I1030 21:51:07.825690 25065 default_executor.cpp:1079] Scheduling escalation to SIGKILL in 3secs from now
> I1030 21:51:07.957986 25083 default_executor.cpp:888] Child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.6ee13669-0de9-41b6-bde9-9f581b3e9c2e of task 'fce3ed1c-d93a-4b6f-8950-771a989b279b' completed in state TASK_KILLED: Command terminated with signal Terminated
> I1030 21:51:07.958062 25083 default_executor.cpp:924] Killing task group containing tasks [ fce3ed1c-d93a-4b6f-8950-771a989b279b, 2e1b7db2-5f05-4474-bd5e-00c03468db71 ]
> I1030 21:51:07.958566 25083 default_executor.cpp:888] Child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.d11330e3-4f3a-4686-be5f-935ec8f44111 of task '2e1b7db2-5f05-4474-bd5e-00c03468db71' completed in state TASK_KILLED: Command terminated with signal Terminated
> I1030 21:51:07.958626 25083 default_executor.cpp:1017] Terminating after 1secs
> [ OK ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillMultipleTasks/0 (9200 ms)
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 62837: Added a test
`DefaultExecutorTest.KillMultipleTasks`.
Posted by Qian Zhang <zh...@gmail.com>.
> On Nov. 1, 2017, 11 p.m., Gaston Kleiman wrote:
> > src/tests/default_executor_tests.cpp
> > Lines 538-548 (patched)
> > <https://reviews.apache.org/r/62837/diff/2/?file=1873334#file1873334line538>
> >
> > This is racy; there's no guarantee that the first `TASK_RUNNING` status update will come after the second `TASK_STARTING` update.
> >
> > The following ordering would also be possible: [`TASK_STARTING`, `TASK_RUNNING`, `TASK_STARTING`, `TASK_RUNNING`, ...]
>
> Alexander Rukletsov wrote:
> To simplify the logic here, let's introduce a matcher in our tests, something like
> ```
> MATCHER_P(TaskStateEq, state, "") { return arg.state() == state; }
> ```
> which we then can use like
> ```
> Future<TaskStatus> status;
> EXPECT_CALL(sched, statusUpdate(&driver, TaskStateEq(TASK_RUNNING)))
> .WillOnce(FutureArg<1>(&status));
> ```
> Then you can combine both task state and task id matchers to get an exact status update.
>
> Gaston Kleiman wrote:
> AlexR suggested something like this:
>
> ```
> Sequence task1;
> EXPECT_CALL(
> *scheduler,
> update(_, AllOf(TaskStatusEq(TASK_STARTING), TaskStateEq(taskInfo1))))
> .InSequence(task1)
> .WillOnce(
> DoAll(
> FutureArg<1>(&startingUpdate1),
> v1::scheduler::SendAcknowledge(frameworkId, agentId)));
>
> EXPECT_CALL(
> *scheduler,
> update(_, AllOf(TaskStatusEq(TASK_RUNNING), TaskStateEq(taskInfo1))))
> .InSequence(task1)
> .WillOnce(
> DoAll(
> FutureArg<1>(&runningUpdate1),
> v1::scheduler::SendAcknowledge(frameworkId, agentId)));
>
> Sequence task2;
> EXPECT_CALL(
> *scheduler,
> update(_, AllOf(TaskStatusEq(TASK_STARTING), TaskStateEq(taskInfo2))))
> .InSequence(task2)
> .WillOnce(
> DoAll(
> FutureArg<1>(&startingUpdate2),
> v1::scheduler::SendAcknowledge(frameworkId, agentId)));
>
> EXPECT_CALL(
> *scheduler,
> update(_, AllOf(TaskStatusEq(TASK_RUNNING), TaskStateEq(taskInfo2))))
> .InSequence(task2)
> .WillOnce(
> DoAll(
> FutureArg<1>(&runningUpdate2),
> v1::scheduler::SendAcknowledge(frameworkId, agentId)));
>
> AWAIT_READY(startingUpdate1);
> AWAIT_READY(runningUpdate1);
>
> AWAIT_READY(startingUpdate2);
> AWAIT_READY(runningUpdate2);
> ```
>
> Alexander Rukletsov wrote:
> Parameters are mixed up : )
> `AllOf(TaskStatusEq(<taskInfo>), TaskStateEq(<TASK_STATE>))`
> Also feel free to refactor `TaskStatusEq` to take an id if you think it is simpler.
So I think we also have this race for the test `DefaultExecutorTest.KillTaskGroupOnTaskFailure`? See the code here: https://github.com/apache/mesos/blob/master/src/tests/default_executor_tests.cpp#L649:L670
And it seems the test `DefaultExecutorTest.KillTask` (https://github.com/apache/mesos/blob/master/src/tests/default_executor_tests.cpp#L301:L355) handles such race, so what about we follow that way?
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62837/#review189800
-----------------------------------------------------------
On Oct. 31, 2017, 12:53 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62837/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2017, 12:53 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-8051
> https://issues.apache.org/jira/browse/MESOS-8051
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `DefaultExecutorTest.KillMultipleTasks`.
>
>
> Diffs
> -----
>
> src/tests/default_executor_tests.cpp 5078bd4d70698f5cbd14c971fcecfd58f8467a04
>
>
> Diff: https://reviews.apache.org/r/62837/diff/2/
>
>
> Testing
> -------
>
> [ RUN ] MesosContainerizer/DefaultExecutorTest.KillMultipleTasks/0
> I1030 21:47:58.181413 22360 executor.cpp:192] Version: 1.5.0
> I1030 21:47:58.201525 22382 default_executor.cpp:191] Received SUBSCRIBED event
> I1030 21:47:58.203812 22382 default_executor.cpp:195] Subscribed executor on core-dev
> I1030 21:47:58.204406 22382 default_executor.cpp:191] Received LAUNCH_GROUP event
> I1030 21:47:58.205346 22390 default_executor.cpp:402] Setting 'MESOS_CONTAINER_IP' to: 10.0.49.2
> I1030 21:47:58.220854 22356 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:47:58.221959 22367 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:47:58.261060 22370 default_executor.cpp:640] Successfully launched tasks [ 4fee2fec-12b5-4af6-bd70-e67b4da26c00, 24695aee-aa59-4295-8ad9-19f17ad9d52b ] in child containers [ 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18, 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 ]
> I1030 21:47:58.263293 22385 default_executor.cpp:713] Waiting for child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18 of task '4fee2fec-12b5-4af6-bd70-e67b4da26c00'
> I1030 21:47:58.263546 22385 default_executor.cpp:713] Waiting for child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 of task '24695aee-aa59-4295-8ad9-19f17ad9d52b'
> I1030 21:47:58.307412 22351 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:47:58.307924 22358 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:47:58.354656 22365 default_executor.cpp:191] Received KILL event
> I1030 21:47:58.354730 22365 default_executor.cpp:1172] Received kill for task '4fee2fec-12b5-4af6-bd70-e67b4da26c00'
> I1030 21:47:58.354787 22365 default_executor.cpp:1057] Killing task 4fee2fec-12b5-4af6-bd70-e67b4da26c00 running in child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18 with SIGTERM signal
> I1030 21:47:58.354825 22365 default_executor.cpp:1079] Scheduling escalation to SIGKILL in 3secs from now
> I1030 21:47:58.355772 22365 default_executor.cpp:191] Received KILL event
> I1030 21:47:58.355819 22365 default_executor.cpp:1172] Received kill for task '24695aee-aa59-4295-8ad9-19f17ad9d52b'
> I1030 21:47:58.355947 22365 default_executor.cpp:1057] Killing task 24695aee-aa59-4295-8ad9-19f17ad9d52b running in child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 with SIGTERM signal
> I1030 21:47:58.355980 22365 default_executor.cpp:1079] Scheduling escalation to SIGKILL in 3secs from now
> I1030 21:47:58.467401 22380 default_executor.cpp:888] Child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18 of task '4fee2fec-12b5-4af6-bd70-e67b4da26c00' completed in state TASK_KILLED: Command terminated with signal Terminated
> I1030 21:47:58.467478 22380 default_executor.cpp:924] Killing task group containing tasks [ 4fee2fec-12b5-4af6-bd70-e67b4da26c00, 24695aee-aa59-4295-8ad9-19f17ad9d52b ]
> I1030 21:47:58.467888 22380 default_executor.cpp:888] Child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 of task '24695aee-aa59-4295-8ad9-19f17ad9d52b' completed in state TASK_KILLED: Command terminated with signal Terminated
> I1030 21:47:58.467934 22380 default_executor.cpp:1017] Terminating after 1secs
> [ OK ] MesosContainerizer/DefaultExecutorTest.KillMultipleTasks/0 (922 ms)
>
>
> [ RUN ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillMultipleTasks/0
> I1030 21:51:07.645311 25065 executor.cpp:192] Version: 1.5.0
> I1030 21:51:07.665602 25086 default_executor.cpp:191] Received SUBSCRIBED event
> I1030 21:51:07.667804 25086 default_executor.cpp:195] Subscribed executor on core-dev
> I1030 21:51:07.668308 25086 default_executor.cpp:191] Received LAUNCH_GROUP event
> I1030 21:51:07.669232 25093 default_executor.cpp:402] Setting 'MESOS_CONTAINER_IP' to: 10.0.49.2
> I1030 21:51:07.684146 25060 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:51:07.685752 25071 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:51:07.730559 25077 default_executor.cpp:640] Successfully launched tasks [ fce3ed1c-d93a-4b6f-8950-771a989b279b, 2e1b7db2-5f05-4474-bd5e-00c03468db71 ] in child containers [ 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.6ee13669-0de9-41b6-bde9-9f581b3e9c2e, 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.d11330e3-4f3a-4686-be5f-935ec8f44111 ]
> I1030 21:51:07.732921 25089 default_executor.cpp:713] Waiting for child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.6ee13669-0de9-41b6-bde9-9f581b3e9c2e of task 'fce3ed1c-d93a-4b6f-8950-771a989b279b'
> I1030 21:51:07.733170 25089 default_executor.cpp:713] Waiting for child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.d11330e3-4f3a-4686-be5f-935ec8f44111 of task '2e1b7db2-5f05-4474-bd5e-00c03468db71'
> I1030 21:51:07.776757 25056 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:51:07.777101 25062 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:51:07.824290 25065 default_executor.cpp:191] Received KILL event
> I1030 21:51:07.824533 25065 default_executor.cpp:1172] Received kill for task 'fce3ed1c-d93a-4b6f-8950-771a989b279b'
> I1030 21:51:07.824579 25065 default_executor.cpp:1057] Killing task fce3ed1c-d93a-4b6f-8950-771a989b279b running in child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.6ee13669-0de9-41b6-bde9-9f581b3e9c2e with SIGTERM signal
> I1030 21:51:07.824606 25065 default_executor.cpp:1079] Scheduling escalation to SIGKILL in 3secs from now
> I1030 21:51:07.825533 25065 default_executor.cpp:191] Received KILL event
> I1030 21:51:07.825597 25065 default_executor.cpp:1172] Received kill for task '2e1b7db2-5f05-4474-bd5e-00c03468db71'
> I1030 21:51:07.825647 25065 default_executor.cpp:1057] Killing task 2e1b7db2-5f05-4474-bd5e-00c03468db71 running in child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.d11330e3-4f3a-4686-be5f-935ec8f44111 with SIGTERM signal
> I1030 21:51:07.825690 25065 default_executor.cpp:1079] Scheduling escalation to SIGKILL in 3secs from now
> I1030 21:51:07.957986 25083 default_executor.cpp:888] Child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.6ee13669-0de9-41b6-bde9-9f581b3e9c2e of task 'fce3ed1c-d93a-4b6f-8950-771a989b279b' completed in state TASK_KILLED: Command terminated with signal Terminated
> I1030 21:51:07.958062 25083 default_executor.cpp:924] Killing task group containing tasks [ fce3ed1c-d93a-4b6f-8950-771a989b279b, 2e1b7db2-5f05-4474-bd5e-00c03468db71 ]
> I1030 21:51:07.958566 25083 default_executor.cpp:888] Child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.d11330e3-4f3a-4686-be5f-935ec8f44111 of task '2e1b7db2-5f05-4474-bd5e-00c03468db71' completed in state TASK_KILLED: Command terminated with signal Terminated
> I1030 21:51:07.958626 25083 default_executor.cpp:1017] Terminating after 1secs
> [ OK ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillMultipleTasks/0 (9200 ms)
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 62837: Added a test
`DefaultExecutorTest.KillMultipleTasks`.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62837/#review189800
-----------------------------------------------------------
src/tests/default_executor_tests.cpp
Lines 538-548 (patched)
<https://reviews.apache.org/r/62837/#comment267009>
This is racy; there's no guarantee that the first `TASK_RUNNING` status update will come after the second `TASK_STARTING` update.
The following ordering would also be possible: [`TASK_STARTING`, `TASK_RUNNING`, `TASK_STARTING`, `TASK_RUNNING`, ...]
- Gaston Kleiman
On Oct. 30, 2017, 9:53 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62837/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2017, 9:53 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-8051
> https://issues.apache.org/jira/browse/MESOS-8051
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `DefaultExecutorTest.KillMultipleTasks`.
>
>
> Diffs
> -----
>
> src/tests/default_executor_tests.cpp 5078bd4d70698f5cbd14c971fcecfd58f8467a04
>
>
> Diff: https://reviews.apache.org/r/62837/diff/2/
>
>
> Testing
> -------
>
> [ RUN ] MesosContainerizer/DefaultExecutorTest.KillMultipleTasks/0
> I1030 21:47:58.181413 22360 executor.cpp:192] Version: 1.5.0
> I1030 21:47:58.201525 22382 default_executor.cpp:191] Received SUBSCRIBED event
> I1030 21:47:58.203812 22382 default_executor.cpp:195] Subscribed executor on core-dev
> I1030 21:47:58.204406 22382 default_executor.cpp:191] Received LAUNCH_GROUP event
> I1030 21:47:58.205346 22390 default_executor.cpp:402] Setting 'MESOS_CONTAINER_IP' to: 10.0.49.2
> I1030 21:47:58.220854 22356 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:47:58.221959 22367 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:47:58.261060 22370 default_executor.cpp:640] Successfully launched tasks [ 4fee2fec-12b5-4af6-bd70-e67b4da26c00, 24695aee-aa59-4295-8ad9-19f17ad9d52b ] in child containers [ 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18, 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 ]
> I1030 21:47:58.263293 22385 default_executor.cpp:713] Waiting for child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18 of task '4fee2fec-12b5-4af6-bd70-e67b4da26c00'
> I1030 21:47:58.263546 22385 default_executor.cpp:713] Waiting for child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 of task '24695aee-aa59-4295-8ad9-19f17ad9d52b'
> I1030 21:47:58.307412 22351 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:47:58.307924 22358 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:47:58.354656 22365 default_executor.cpp:191] Received KILL event
> I1030 21:47:58.354730 22365 default_executor.cpp:1172] Received kill for task '4fee2fec-12b5-4af6-bd70-e67b4da26c00'
> I1030 21:47:58.354787 22365 default_executor.cpp:1057] Killing task 4fee2fec-12b5-4af6-bd70-e67b4da26c00 running in child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18 with SIGTERM signal
> I1030 21:47:58.354825 22365 default_executor.cpp:1079] Scheduling escalation to SIGKILL in 3secs from now
> I1030 21:47:58.355772 22365 default_executor.cpp:191] Received KILL event
> I1030 21:47:58.355819 22365 default_executor.cpp:1172] Received kill for task '24695aee-aa59-4295-8ad9-19f17ad9d52b'
> I1030 21:47:58.355947 22365 default_executor.cpp:1057] Killing task 24695aee-aa59-4295-8ad9-19f17ad9d52b running in child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 with SIGTERM signal
> I1030 21:47:58.355980 22365 default_executor.cpp:1079] Scheduling escalation to SIGKILL in 3secs from now
> I1030 21:47:58.467401 22380 default_executor.cpp:888] Child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18 of task '4fee2fec-12b5-4af6-bd70-e67b4da26c00' completed in state TASK_KILLED: Command terminated with signal Terminated
> I1030 21:47:58.467478 22380 default_executor.cpp:924] Killing task group containing tasks [ 4fee2fec-12b5-4af6-bd70-e67b4da26c00, 24695aee-aa59-4295-8ad9-19f17ad9d52b ]
> I1030 21:47:58.467888 22380 default_executor.cpp:888] Child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 of task '24695aee-aa59-4295-8ad9-19f17ad9d52b' completed in state TASK_KILLED: Command terminated with signal Terminated
> I1030 21:47:58.467934 22380 default_executor.cpp:1017] Terminating after 1secs
> [ OK ] MesosContainerizer/DefaultExecutorTest.KillMultipleTasks/0 (922 ms)
>
>
> [ RUN ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillMultipleTasks/0
> I1030 21:51:07.645311 25065 executor.cpp:192] Version: 1.5.0
> I1030 21:51:07.665602 25086 default_executor.cpp:191] Received SUBSCRIBED event
> I1030 21:51:07.667804 25086 default_executor.cpp:195] Subscribed executor on core-dev
> I1030 21:51:07.668308 25086 default_executor.cpp:191] Received LAUNCH_GROUP event
> I1030 21:51:07.669232 25093 default_executor.cpp:402] Setting 'MESOS_CONTAINER_IP' to: 10.0.49.2
> I1030 21:51:07.684146 25060 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:51:07.685752 25071 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:51:07.730559 25077 default_executor.cpp:640] Successfully launched tasks [ fce3ed1c-d93a-4b6f-8950-771a989b279b, 2e1b7db2-5f05-4474-bd5e-00c03468db71 ] in child containers [ 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.6ee13669-0de9-41b6-bde9-9f581b3e9c2e, 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.d11330e3-4f3a-4686-be5f-935ec8f44111 ]
> I1030 21:51:07.732921 25089 default_executor.cpp:713] Waiting for child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.6ee13669-0de9-41b6-bde9-9f581b3e9c2e of task 'fce3ed1c-d93a-4b6f-8950-771a989b279b'
> I1030 21:51:07.733170 25089 default_executor.cpp:713] Waiting for child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.d11330e3-4f3a-4686-be5f-935ec8f44111 of task '2e1b7db2-5f05-4474-bd5e-00c03468db71'
> I1030 21:51:07.776757 25056 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:51:07.777101 25062 default_executor.cpp:191] Received ACKNOWLEDGED event
> I1030 21:51:07.824290 25065 default_executor.cpp:191] Received KILL event
> I1030 21:51:07.824533 25065 default_executor.cpp:1172] Received kill for task 'fce3ed1c-d93a-4b6f-8950-771a989b279b'
> I1030 21:51:07.824579 25065 default_executor.cpp:1057] Killing task fce3ed1c-d93a-4b6f-8950-771a989b279b running in child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.6ee13669-0de9-41b6-bde9-9f581b3e9c2e with SIGTERM signal
> I1030 21:51:07.824606 25065 default_executor.cpp:1079] Scheduling escalation to SIGKILL in 3secs from now
> I1030 21:51:07.825533 25065 default_executor.cpp:191] Received KILL event
> I1030 21:51:07.825597 25065 default_executor.cpp:1172] Received kill for task '2e1b7db2-5f05-4474-bd5e-00c03468db71'
> I1030 21:51:07.825647 25065 default_executor.cpp:1057] Killing task 2e1b7db2-5f05-4474-bd5e-00c03468db71 running in child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.d11330e3-4f3a-4686-be5f-935ec8f44111 with SIGTERM signal
> I1030 21:51:07.825690 25065 default_executor.cpp:1079] Scheduling escalation to SIGKILL in 3secs from now
> I1030 21:51:07.957986 25083 default_executor.cpp:888] Child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.6ee13669-0de9-41b6-bde9-9f581b3e9c2e of task 'fce3ed1c-d93a-4b6f-8950-771a989b279b' completed in state TASK_KILLED: Command terminated with signal Terminated
> I1030 21:51:07.958062 25083 default_executor.cpp:924] Killing task group containing tasks [ fce3ed1c-d93a-4b6f-8950-771a989b279b, 2e1b7db2-5f05-4474-bd5e-00c03468db71 ]
> I1030 21:51:07.958566 25083 default_executor.cpp:888] Child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.d11330e3-4f3a-4686-be5f-935ec8f44111 of task '2e1b7db2-5f05-4474-bd5e-00c03468db71' completed in state TASK_KILLED: Command terminated with signal Terminated
> I1030 21:51:07.958626 25083 default_executor.cpp:1017] Terminating after 1secs
> [ OK ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillMultipleTasks/0 (9200 ms)
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 62837: Added a test
`DefaultExecutorTest.KillMultipleTasks`.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62837/
-----------------------------------------------------------
(Updated Oct. 31, 2017, 12:53 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Addressed review comments and updated testing section.
Bugs: MESOS-8051
https://issues.apache.org/jira/browse/MESOS-8051
Repository: mesos
Description
-------
Added a test `DefaultExecutorTest.KillMultipleTasks`.
Diffs (updated)
-----
src/tests/default_executor_tests.cpp 5078bd4d70698f5cbd14c971fcecfd58f8467a04
Diff: https://reviews.apache.org/r/62837/diff/2/
Changes: https://reviews.apache.org/r/62837/diff/1-2/
Testing (updated)
-------
[ RUN ] MesosContainerizer/DefaultExecutorTest.KillMultipleTasks/0
I1030 21:47:58.181413 22360 executor.cpp:192] Version: 1.5.0
I1030 21:47:58.201525 22382 default_executor.cpp:191] Received SUBSCRIBED event
I1030 21:47:58.203812 22382 default_executor.cpp:195] Subscribed executor on core-dev
I1030 21:47:58.204406 22382 default_executor.cpp:191] Received LAUNCH_GROUP event
I1030 21:47:58.205346 22390 default_executor.cpp:402] Setting 'MESOS_CONTAINER_IP' to: 10.0.49.2
I1030 21:47:58.220854 22356 default_executor.cpp:191] Received ACKNOWLEDGED event
I1030 21:47:58.221959 22367 default_executor.cpp:191] Received ACKNOWLEDGED event
I1030 21:47:58.261060 22370 default_executor.cpp:640] Successfully launched tasks [ 4fee2fec-12b5-4af6-bd70-e67b4da26c00, 24695aee-aa59-4295-8ad9-19f17ad9d52b ] in child containers [ 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18, 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 ]
I1030 21:47:58.263293 22385 default_executor.cpp:713] Waiting for child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18 of task '4fee2fec-12b5-4af6-bd70-e67b4da26c00'
I1030 21:47:58.263546 22385 default_executor.cpp:713] Waiting for child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 of task '24695aee-aa59-4295-8ad9-19f17ad9d52b'
I1030 21:47:58.307412 22351 default_executor.cpp:191] Received ACKNOWLEDGED event
I1030 21:47:58.307924 22358 default_executor.cpp:191] Received ACKNOWLEDGED event
I1030 21:47:58.354656 22365 default_executor.cpp:191] Received KILL event
I1030 21:47:58.354730 22365 default_executor.cpp:1172] Received kill for task '4fee2fec-12b5-4af6-bd70-e67b4da26c00'
I1030 21:47:58.354787 22365 default_executor.cpp:1057] Killing task 4fee2fec-12b5-4af6-bd70-e67b4da26c00 running in child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18 with SIGTERM signal
I1030 21:47:58.354825 22365 default_executor.cpp:1079] Scheduling escalation to SIGKILL in 3secs from now
I1030 21:47:58.355772 22365 default_executor.cpp:191] Received KILL event
I1030 21:47:58.355819 22365 default_executor.cpp:1172] Received kill for task '24695aee-aa59-4295-8ad9-19f17ad9d52b'
I1030 21:47:58.355947 22365 default_executor.cpp:1057] Killing task 24695aee-aa59-4295-8ad9-19f17ad9d52b running in child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 with SIGTERM signal
I1030 21:47:58.355980 22365 default_executor.cpp:1079] Scheduling escalation to SIGKILL in 3secs from now
I1030 21:47:58.467401 22380 default_executor.cpp:888] Child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18 of task '4fee2fec-12b5-4af6-bd70-e67b4da26c00' completed in state TASK_KILLED: Command terminated with signal Terminated
I1030 21:47:58.467478 22380 default_executor.cpp:924] Killing task group containing tasks [ 4fee2fec-12b5-4af6-bd70-e67b4da26c00, 24695aee-aa59-4295-8ad9-19f17ad9d52b ]
I1030 21:47:58.467888 22380 default_executor.cpp:888] Child container 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 of task '24695aee-aa59-4295-8ad9-19f17ad9d52b' completed in state TASK_KILLED: Command terminated with signal Terminated
I1030 21:47:58.467934 22380 default_executor.cpp:1017] Terminating after 1secs
[ OK ] MesosContainerizer/DefaultExecutorTest.KillMultipleTasks/0 (922 ms)
[ RUN ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillMultipleTasks/0
I1030 21:51:07.645311 25065 executor.cpp:192] Version: 1.5.0
I1030 21:51:07.665602 25086 default_executor.cpp:191] Received SUBSCRIBED event
I1030 21:51:07.667804 25086 default_executor.cpp:195] Subscribed executor on core-dev
I1030 21:51:07.668308 25086 default_executor.cpp:191] Received LAUNCH_GROUP event
I1030 21:51:07.669232 25093 default_executor.cpp:402] Setting 'MESOS_CONTAINER_IP' to: 10.0.49.2
I1030 21:51:07.684146 25060 default_executor.cpp:191] Received ACKNOWLEDGED event
I1030 21:51:07.685752 25071 default_executor.cpp:191] Received ACKNOWLEDGED event
I1030 21:51:07.730559 25077 default_executor.cpp:640] Successfully launched tasks [ fce3ed1c-d93a-4b6f-8950-771a989b279b, 2e1b7db2-5f05-4474-bd5e-00c03468db71 ] in child containers [ 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.6ee13669-0de9-41b6-bde9-9f581b3e9c2e, 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.d11330e3-4f3a-4686-be5f-935ec8f44111 ]
I1030 21:51:07.732921 25089 default_executor.cpp:713] Waiting for child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.6ee13669-0de9-41b6-bde9-9f581b3e9c2e of task 'fce3ed1c-d93a-4b6f-8950-771a989b279b'
I1030 21:51:07.733170 25089 default_executor.cpp:713] Waiting for child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.d11330e3-4f3a-4686-be5f-935ec8f44111 of task '2e1b7db2-5f05-4474-bd5e-00c03468db71'
I1030 21:51:07.776757 25056 default_executor.cpp:191] Received ACKNOWLEDGED event
I1030 21:51:07.777101 25062 default_executor.cpp:191] Received ACKNOWLEDGED event
I1030 21:51:07.824290 25065 default_executor.cpp:191] Received KILL event
I1030 21:51:07.824533 25065 default_executor.cpp:1172] Received kill for task 'fce3ed1c-d93a-4b6f-8950-771a989b279b'
I1030 21:51:07.824579 25065 default_executor.cpp:1057] Killing task fce3ed1c-d93a-4b6f-8950-771a989b279b running in child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.6ee13669-0de9-41b6-bde9-9f581b3e9c2e with SIGTERM signal
I1030 21:51:07.824606 25065 default_executor.cpp:1079] Scheduling escalation to SIGKILL in 3secs from now
I1030 21:51:07.825533 25065 default_executor.cpp:191] Received KILL event
I1030 21:51:07.825597 25065 default_executor.cpp:1172] Received kill for task '2e1b7db2-5f05-4474-bd5e-00c03468db71'
I1030 21:51:07.825647 25065 default_executor.cpp:1057] Killing task 2e1b7db2-5f05-4474-bd5e-00c03468db71 running in child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.d11330e3-4f3a-4686-be5f-935ec8f44111 with SIGTERM signal
I1030 21:51:07.825690 25065 default_executor.cpp:1079] Scheduling escalation to SIGKILL in 3secs from now
I1030 21:51:07.957986 25083 default_executor.cpp:888] Child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.6ee13669-0de9-41b6-bde9-9f581b3e9c2e of task 'fce3ed1c-d93a-4b6f-8950-771a989b279b' completed in state TASK_KILLED: Command terminated with signal Terminated
I1030 21:51:07.958062 25083 default_executor.cpp:924] Killing task group containing tasks [ fce3ed1c-d93a-4b6f-8950-771a989b279b, 2e1b7db2-5f05-4474-bd5e-00c03468db71 ]
I1030 21:51:07.958566 25083 default_executor.cpp:888] Child container 9b58977b-8d1b-4a3d-a5af-624e44ba12f0.d11330e3-4f3a-4686-be5f-935ec8f44111 of task '2e1b7db2-5f05-4474-bd5e-00c03468db71' completed in state TASK_KILLED: Command terminated with signal Terminated
I1030 21:51:07.958626 25083 default_executor.cpp:1017] Terminating after 1secs
[ OK ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillMultipleTasks/0 (9200 ms)
Thanks,
Qian Zhang
Re: Review Request 62837: Added a test
`DefaultExecutorTest.KillMultipleTasks`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62837/#review187389
-----------------------------------------------------------
FAIL: The system cannot find the file specified.
Reviews applied: `['62806']`
Failed command: `C:\mesos\src\mesos-tests.exe --verbose --gtest_filter="-ContentType/MasterAPITest.EventAuthorizationFiltering/1"`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806/logs/mesos-tests-stdout.log):
```
[ RUN ] FaultToleranceTest.SchedulerReregisterAfterUnregistration
[ OK ] FaultToleranceTest.SchedulerReregisterAfterUnregistration (389 ms)
[ RUN ] FaultToleranceTest.SchedulerFailoverRetriedReregistration
[ OK ] FaultToleranceTest.SchedulerFailoverRetriedReregistration (389 ms)
[ RUN ] FaultToleranceTest.DisconnectedSchedulerLaunchLost
[ OK ] FaultToleranceTest.DisconnectedSchedulerLaunchLost (609 ms)
[ RUN ] FaultToleranceTest.DisconnectedSchedulerLaunchDropped
[ OK ] FaultToleranceTest.DisconnectedSchedulerLaunchDropped (596 ms)
[ RUN ] FaultToleranceTest.SchedulerFailoverStatusUpdate
[ OK ] FaultToleranceTest.SchedulerFailoverStatusUpdate (923 ms)
[ RUN ] FaultToleranceTest.ReregisterFrameworkExitedExecutor
[ OK ] FaultToleranceTest.ReregisterFrameworkExitedExecutor (1249 ms)
[ RUN ] FaultToleranceTest.ForwardStatusUpdateUnknownExecutor
[ OK ] FaultToleranceTest.ForwardStatusUpdateUnknownExecutor (822 ms)
[ RUN ] FaultToleranceTest.SchedulerFailoverExecutorToFrameworkMessage
[ OK ] FaultToleranceTest.SchedulerFailoverExecutorToFrameworkMessage (941 ms)
[ RUN ] FaultToleranceTest.SchedulerFailoverFrameworkToExecutorMessage
[ OK ] FaultToleranceTest.SchedulerFailoverFrameworkToExecutorMessage (1060 ms)
[ RUN ] FaultToleranceTest.IgnoreKillTaskFromUnregisteredFramework
[ OK ] FaultToleranceTest.IgnoreKillTaskFromUnregisteredFramework (939 ms)
[ RUN ] FaultToleranceTest.SchedulerExit
[ OK ] FaultToleranceTest.SchedulerExit (841 ms)
[ RUN ] FaultToleranceTest.SlaveReliableRegistration
[ OK ] FaultToleranceTest.SlaveReliableRegistration (788 ms)
[ RUN ] FaultToleranceTest.SlaveReregisterOnZKExpiration
[ OK ] FaultToleranceTest.SlaveReregisterOnZKExpiration (778 ms)
[ RUN ] FaultToleranceTest.FrameworkReregisterEmptyExecutor
[ OK ] FaultToleranceTest.FrameworkReregisterEmptyExecutor (1130 ms)
[ RUN ] FaultToleranceTest.SplitBrainMasters
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806/logs/mesos-tests-stderr.log):
```
I1006 17:26:12.991288 43216 master.cpp:8459] Removing framework ede9e20a-4e06-46fb-a22c-7e8013f03fa7-0000 (default) at scheduler-3a38ff4a-a81c-4c5b-9c40-38d63a94afd2@10.3.1.5:61771
I1006 17:26:12.991288 43216 master.cpp:3299] Deactivating framework ede9e20a-4e06-46fb-a22c-7e8013f03fa7-0000 (default) at scheduler-3a38ff4a-a81c-4c5b-9c40-38d63a94afd2@10.3.1.5:61771
I1006 17:26:12.992297 46984 hierarchical.cpp:412] Deactivated framework ede9e20a-4e06-46fb-a22c-7e8013f03fa7-0000
I1006 17:26:12.995283 43216 master.cpp:9389] Removing offer 60f5153f-ffdc-4156-8383-39cf5a6b25f8-O0
I1006 17:26:12.998283 46248 slave.cpp:869] Agent terminating
I1006 17:26:13.004289 21464 hierarchical.cpp:355] Removed framework ede9e20a-4e06-46fb-a22c-7e8013f03fa7-0000
I1006 17:26:13.007899 39284 master.cpp:1303] Agent ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 at slave(37)@10.3.1.5:61771 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I1006 17:26:13.008906 39284 master.cpp:3336] Disconnecting agent ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 at slave(37)@10.3.1.5:61771 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1006 17:26:13.008906 39284 master.cpp:3355] Deactivating agent ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 at slave(37)@10.3.1.5:61771 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1006 17:26:13.009905 46484 hierarchical.cpp:690] Agent ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 deactivated
I1006 17:26:13.038906 46248 master.cpp:1145] Master terminating
I1006 17:26:13.040907 21464 hierarchical.cpp:626] Removed agent ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0
I1006 17:26:13.151911 46248 cluster.cpp:162] Creating default 'local' authorizer
I1006 17:26:13.184912 44660 master.cpp:445] Master 8c8fa538-3ba3-4608-8e12-2ba9b5151087 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) started on 10.3.1.5:61771
I1006 17:26:13.184912 44660 master.cpp:447] Flags at startup: --acls="" --agent_ping_timeout="15secs" --agent_reregister_timeout="10mins" --allocation_interval="1secs" --allocator="HierarchicalDRF" --authenticate_agents="true" --authenticate_frameworks="true" --authenticate_http_frameworks="true" --authenticate_http_readonly="true" --authenticate_http_readwrite="true" --authenticators="crammd5" --authorizers="local" --credentials="C:\Users\mesos\AppData\Local\Temp\2\BVZ2va\credentials" --filter_gpu_resources="true" --framework_sorter="drf" --help="false" --hostname_lookup="true" --http_authenticators="basic" --http_framework_authenticators="basic" --initialize_driver_logging="true" --log_auto_initialize="true" --logbufsecs="0" --logging_level="INFO" --max_agent_ping_timeouts="5" --max_completed_frameworks="50" --max_completed_tasks_per_framework="1000" --max_unreachable_tasks_per_framework="1000" --port="5050" --quiet="false" --recovery_agent_removal_limit="100%" --registry="in_memor
y" --registry_fetch_timeout="1mins" --registry_gc_interval="15mins" --registry_max_agent_age="2weeks" --registry_max_agent_count="102400" --registry_store_timeout="100secs" --registry_strict="false" --root_submissions="true" --user_sorter="drf" --version="false" --webui_dir="/webui" --work_dir="C:\Users\mesos\AppData\Local\Temp\2\BVZ2va\master" --zk_session_timeout="10secs"
I1006 17:26:13.223922 44660 master.cpp:496] Master only allowing authenticated frameworks to register
I1006 17:26:13.223922 44660 master.cpp:502] Master only allowing authenticated agents to register
I1006 17:26:13.223922 44660 master.cpp:508] Master only allowing authenticated HTTP frameworks to register
I1006 17:26:13.223922 44660 credentials.hpp:37] Loading credentials for authentication from 'C:\Users\mesos\AppData\Local\Temp\2\BVZ2va\credentials'
I1006 17:26:13.235913 44660 master.cpp:552] Using default 'crammd5' authenticator
I1006 17:26:13.236914 44660 http.cpp:1045] Creating default 'basic' HTTP authenticator for realm 'mesos-master-readonly'
I1006 17:26:13.237915 44660 http.cpp:1045] Creating default 'basic' HTTP authenticator for realm 'mesos-master-readwrite'
I1006 17:26:13.238914 44660 http.cpp:1045] Creating default 'basic' HTTP authenticator for realm 'mesos-master-scheduler'
I1006 17:26:13.239914 44660 master.cpp:631] Authorization enabled
I1006 17:26:13.270947 45764 master.cpp:2198] Elected as the leading master!
I1006 17:26:13.270947 45764 master.cpp:1687] Recovering from registrar
I1006 17:26:13.273921 39284 registrar.cpp:391] Successfully fetched the registry (0B) in 1.97504ms
I1006 17:26:13.273921 39284 registrar.cpp:495] Applied 1 operations in 0ns; attempting to update the registry
I1006 17:26:13.275921 21464 registrar.cpp:552] Successfully updated the registry in 999936ns
I1006 17:26:13.276916 21464 registrar.cpp:424] Success```
- Mesos Reviewbot Windows
On Oct. 9, 2017, 2:28 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62837/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2017, 2:28 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-8051
> https://issues.apache.org/jira/browse/MESOS-8051
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `DefaultExecutorTest.KillMultipleTasks`.
>
>
> Diffs
> -----
>
> src/tests/default_executor_tests.cpp 2b4c643b8fb2fc8f2a5e98984ae1c267f66885d1
>
>
> Diff: https://reviews.apache.org/r/62837/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>