You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "szehon-ho (via GitHub)" <gi...@apache.org> on 2023/05/16 22:00:39 UTC
[GitHub] [iceberg] szehon-ho opened a new issue, #7625: Harmonize RewriteData, DeleteFilesSparkAction
szehon-ho opened a new issue, #7625:
URL: https://github.com/apache/iceberg/issues/7625
### Feature Request / Improvement
We did some a few code fixups to RewriteDeleteFileSparkAction that can be applied as well to RewriteDataFileSparkAction https://github.com/apache/iceberg/pull/7565#pullrequestreview-1427730581
### Query engine
Spark
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] dramaticlly commented on issue #7625: Harmonize RewriteData, DeleteFilesSparkAction
Posted by "dramaticlly (via GitHub)" <gi...@apache.org>.
dramaticlly commented on issue #7625:
URL: https://github.com/apache/iceberg/issues/7625#issuecomment-1553780683
> I fixed for rewrite data files via #7630. And in the issue summary, `DeleteFilesSparkAction` is mentioned. Which one did you mean `DeleteOrphanFilesSparkAction` or `DeleteReachableFilesSparkAction`?. I didn't find the same pattern for optimization in those actions.
I think the issue asked to harmonize both `RewriteDataFilesSparkAction` and `Rewrite(Position)DeleteFilesSparkAction` based on feedback given in #7565. Delete Orphan and ReachableFiles shall not be relevant here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] szehon-ho commented on issue #7625: Harmonize RewriteData, DeleteFilesSparkAction
Posted by "szehon-ho (via GitHub)" <gi...@apache.org>.
szehon-ho commented on issue #7625:
URL: https://github.com/apache/iceberg/issues/7625#issuecomment-1550410909
If anyone has cycles to take a look, feel free, else I can do this later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] szehon-ho closed issue #7625: Harmonize RewriteData, DeleteFilesSparkAction
Posted by "szehon-ho (via GitHub)" <gi...@apache.org>.
szehon-ho closed issue #7625: Harmonize RewriteData, DeleteFilesSparkAction
URL: https://github.com/apache/iceberg/issues/7625
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] szehon-ho commented on issue #7625: Harmonize RewriteData, DeleteFilesSparkAction
Posted by "szehon-ho (via GitHub)" <gi...@apache.org>.
szehon-ho commented on issue #7625:
URL: https://github.com/apache/iceberg/issues/7625#issuecomment-1553834222
Ugh im sorry guys, i made the issue name wrong, should be RewritePositionDeleteFilesSparkAction. Looked at that word too much this year :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] ajantha-bhat commented on issue #7625: Harmonize RewriteData, DeleteFilesSparkAction
Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on issue #7625:
URL: https://github.com/apache/iceberg/issues/7625#issuecomment-1550771972
@szehon-ho: I can work on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] ajantha-bhat commented on issue #7625: Harmonize RewriteData, DeleteFilesSparkAction
Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on issue #7625:
URL: https://github.com/apache/iceberg/issues/7625#issuecomment-1551346361
I fixed for rewrite data files via #7630.
And in the issue summary, `DeleteFilesSparkAction` is mentioned. Which one did you mean `DeleteOrphanFilesSparkAction` or `DeleteReachableFilesSparkAction`. I didn't find the same pattern for optimization in those actions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] szehon-ho commented on issue #7625: Harmonize RewriteData, DeleteFilesSparkAction
Posted by "szehon-ho (via GitHub)" <gi...@apache.org>.
szehon-ho commented on issue #7625:
URL: https://github.com/apache/iceberg/issues/7625#issuecomment-1550984567
Yea, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org