You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2021/09/02 17:02:21 UTC
[GitHub] [daffodil] stevedlawrence opened a new pull request #630: Resolve Apache Conscious Language Checker findings
stevedlawrence opened a new pull request #630:
URL: https://github.com/apache/daffodil/pull/630
- Change references to Daffodil "main" branch
- Fix test quotes/strings and typos to avoid false positives
- Links to 3rd party repos are changed to 'main' where possible, or to a
commit hash or tag where not, again to minimize false positives
Findings that are not resolved:
- Dependency license text that contains "his or her"--we probably
shouldn't modify text from other licenses
- False positive found in "Saxon-HE" dependency
DAFFODIL-2557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] stevedlawrence commented on pull request #630: Resolve Apache Conscious Language Checker findings
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on pull request #630:
URL: https://github.com/apache/daffodil/pull/630#issuecomment-911969104
Seems reasonable. Will update with instructions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] stevedlawrence commented on a change in pull request #630: Resolve Apache Conscious Language Checker findings
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on a change in pull request #630:
URL: https://github.com/apache/daffodil/pull/630#discussion_r701290900
##########
File path: daffodil-test/src/test/resources/org/apache/daffodil/section23/dfdl_functions/Functions.tdml
##########
@@ -562,10 +562,10 @@
<xs:element name="e_lowercase2" type="xs:string" dfdl:inputValueCalc="{ fn:lower-case('TeSt LoWeR') }" />
<xs:element name="e_lowercase3" type="xs:string" dfdl:inputValueCalc="{ fn:lower-case('') }" />
- <xs:element name="e_contains1" type="xs:boolean" dfdl:inputValueCalc="{ fn:contains('The quick brown fox.', 'quick') }" />
Review comment:
Yeah, the tool definitely needs some refining to reduce false positives. It wouldn't surprise me if we continue to see them from time to time. But the fact that this codebase represents many years of development and there were only a handful of things that needed to be changed says this likely won't be something that will require many changes from our current development.
Note that in this particular case, the false positive was a a test that took off the `T` from `The `, which resulted in 'he'. Instead of changing just that one test, I decided to just change all tests using `the quick brown fox` so they were consistent. So this was pretty rare case, and could have been a much smaller change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] tuxji commented on pull request #630: Resolve Apache Conscious Language Checker findings
Posted by GitBox <gi...@apache.org>.
tuxji commented on pull request #630:
URL: https://github.com/apache/daffodil/pull/630#issuecomment-911953567
Should we amend this PR's commit message to include those instructions as well?
The default branch has been renamed! The `master` branch is now named `main`.
If you have a local clone, you can update it by running:
```sh
git branch -m master main
git fetch origin
git branch -u origin/main main
git remote set-head origin -a
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] mbeckerle commented on a change in pull request #630: Resolve Apache Conscious Language Checker findings
Posted by GitBox <gi...@apache.org>.
mbeckerle commented on a change in pull request #630:
URL: https://github.com/apache/daffodil/pull/630#discussion_r701279055
##########
File path: daffodil-test/src/test/resources/org/apache/daffodil/section23/dfdl_functions/Functions.tdml
##########
@@ -562,10 +562,10 @@
<xs:element name="e_lowercase2" type="xs:string" dfdl:inputValueCalc="{ fn:lower-case('TeSt LoWeR') }" />
<xs:element name="e_lowercase3" type="xs:string" dfdl:inputValueCalc="{ fn:lower-case('') }" />
- <xs:element name="e_contains1" type="xs:boolean" dfdl:inputValueCalc="{ fn:contains('The quick brown fox.', 'quick') }" />
Review comment:
This one surprised me. I have no objection to the change. I just wonder if I can be conscious enough about language to avoid things as common as this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] stevedlawrence merged pull request #630: Resolve Apache Conscious Language Checker findings
Posted by GitBox <gi...@apache.org>.
stevedlawrence merged pull request #630:
URL: https://github.com/apache/daffodil/pull/630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org