You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/03 14:19:19 UTC

[GitHub] [airflow] olchas opened a new issue #12061: Add example dag showing usage of `impersonation_chain` argument of Google operators

olchas opened a new issue #12061:
URL: https://github.com/apache/airflow/issues/12061


   <!--
   
   Welcome to Apache Airflow!  For a smooth issue process, try to answer the following questions.
   Don't worry if they're not all applicable; just try to include what you can :-)
   
   If you need to include code snippets or logs, please put them in fenced code
   blocks.  If they're super-long, please use the details tag like
   <details><summary>super-long log</summary> lots of stuff </details>
   
   Please delete these comment blocks before submitting the issue.
   
   -->
   
   **Description**
   
   This issue is about adding an example dag showing usage of `impersonation_chain` argument of Google operators. It should show both using this argument as a string and as a sequence.
   
   <!-- A short description of your feature -->
   
   **Use case / motivation**
   
   This is to provide users of Google operators with instructions on how to use [direct impersonation](https://cloud.google.com/iam/docs/understanding-service-accounts#directly_impersonating_a_service_account) with them.
   
   <!-- What do you want to happen?
   
   Rather than telling us how you might implement this solution, try to take a
   step back and describe what you are trying to achieve.
   
   -->
   
   **Related Issues**
   https://github.com/apache/airflow/issues/8803
   <!-- Is there currently another issue associated with this? -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] mik-laj commented on issue #12061: Add example dag showing usage of `impersonation_chain` argument of Google operators

Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #12061:
URL: https://github.com/apache/airflow/issues/12061#issuecomment-749845759


   You should create a new example dag. you just need to run it once and see if it works.  It can do anything, such as create and delete a dataset. In the next step I will add system tests to this example DAG, but it is extra effort. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] rightx2 commented on issue #12061: Add example dag showing usage of `impersonation_chain` argument of Google operators

Posted by GitBox <gi...@apache.org>.
rightx2 commented on issue #12061:
URL: https://github.com/apache/airflow/issues/12061#issuecomment-882388967


   Reeaaaaaally need it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] mik-laj commented on issue #12061: Add example dag showing usage of `impersonation_chain` argument of Google operators

Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #12061:
URL: https://github.com/apache/airflow/issues/12061#issuecomment-749290514


   @sharad-vm  Do you need help? I will be happy to help you.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] sharad-vm commented on issue #12061: Add example dag showing usage of `impersonation_chain` argument of Google operators

Posted by GitBox <gi...@apache.org>.
sharad-vm commented on issue #12061:
URL: https://github.com/apache/airflow/issues/12061#issuecomment-986914983


   @thomashutcheson-msm , @rightx2  - Apologies. I lost track of this one. I will circle back to this by Wednesday this week and give you all an update here. Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] rightx2 commented on issue #12061: Add example dag showing usage of `impersonation_chain` argument of Google operators

Posted by GitBox <gi...@apache.org>.
rightx2 commented on issue #12061:
URL: https://github.com/apache/airflow/issues/12061#issuecomment-882388967


   Reeaaaaaally need it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] sharad-vm commented on issue #12061: Add example dag showing usage of `impersonation_chain` argument of Google operators

Posted by GitBox <gi...@apache.org>.
sharad-vm commented on issue #12061:
URL: https://github.com/apache/airflow/issues/12061#issuecomment-749831660


   Actually @mik-laj, I might need some help. 
   I understand that the 'impersonation_chain' argument has been added to the files in airflow/providers/google/cloud/hooks/...
   
   I see example_dags here - airflow/airflow/providers/google/cloud/example_dags/...
   Is this where I add an example for all the 49 files changed?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] thomashutcheson-msm commented on issue #12061: Add example dag showing usage of `impersonation_chain` argument of Google operators

Posted by GitBox <gi...@apache.org>.
thomashutcheson-msm commented on issue #12061:
URL: https://github.com/apache/airflow/issues/12061#issuecomment-986836974


   Did the example dag get created, I would find this really useful right now ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] eladkal commented on issue #12061: Add example dag showing usage of `impersonation_chain` argument of Google operators

Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #12061:
URL: https://github.com/apache/airflow/issues/12061#issuecomment-821940880


   @sharad-vm are you working on this issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] mik-laj commented on issue #12061: Add example dag showing usage of `impersonation_chain` argument of Google operators

Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #12061:
URL: https://github.com/apache/airflow/issues/12061#issuecomment-724384592


   @sharad-vm I assigned you to this ticket.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] sharad-vm commented on issue #12061: Add example dag showing usage of `impersonation_chain` argument of Google operators

Posted by GitBox <gi...@apache.org>.
sharad-vm commented on issue #12061:
URL: https://github.com/apache/airflow/issues/12061#issuecomment-724045504


   I can take a shot at this. @eladkal, would you be able to assign this to me, please?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] sharad-vm commented on issue #12061: Add example dag showing usage of `impersonation_chain` argument of Google operators

Posted by GitBox <gi...@apache.org>.
sharad-vm commented on issue #12061:
URL: https://github.com/apache/airflow/issues/12061#issuecomment-750748637


   Thanks! Will open a PR this weekend.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] sharad-vm commented on issue #12061: Add example dag showing usage of `impersonation_chain` argument of Google operators

Posted by GitBox <gi...@apache.org>.
sharad-vm commented on issue #12061:
URL: https://github.com/apache/airflow/issues/12061#issuecomment-749352214


   Thanks for the follow-up and offering to help, @mik-laj!
   I will let you know in 24 hours. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org