[GitHub] [kafka] jsancio commented on a diff in pull request #13910: KAFKA-15109 Don't skip leader epoch bump for older MetadataVersions

["jsancio (via GitHub)" <gi...@apache.org>]

jsancio commented on code in PR #13910:
URL: https://github.com/apache/kafka/pull/13910#discussion_r1240397926


##########
metadata/src/test/java/org/apache/kafka/controller/PartitionChangeBuilderTest.java:
##########
@@ -207,7 +211,7 @@ public void testTriggerLeaderEpochBumpIfNeeded() {
             createFooBuilder()
                 .setTargetIsrWithBrokerStates(
                     AlterPartitionRequest.newIsrToSimpleNewIsrWithBrokerEpochs(Arrays.asList(2, 1, 3, 4)))
-                .setBumpLeaderEpochOnIsrShrink(true),
+                .enableBumpLeaderEpochOnIsrShrink(true),

Review Comment:
   Hmm. Shouldn't this test fail? Let's add a comment explaining what this test is doing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org