[GitHub] [incubator-kyuubi] SteNicholas commented on a change in pull request #899: Avoid RejectedExecutionException if engine is shutdown

[GitBox <gi...@apache.org>]

SteNicholas commented on a change in pull request #899:
URL: https://github.com/apache/incubator-kyuubi/pull/899#discussion_r808620379



##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/session/SessionManager.scala
##########
@@ -198,6 +198,8 @@ abstract class SessionManager(name: String) extends CompositeService(name) {
     }
   }
 
+  def isShutdown: Boolean = shutdown

Review comment:
       IMO, here is unnecessary. You could directly use the `shutdown` to check.

##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/session/SessionManager.scala
##########
@@ -198,6 +198,8 @@ abstract class SessionManager(name: String) extends CompositeService(name) {
     }
   }
 
+  def isShutdown: Boolean = shutdown

Review comment:
       IMO, here is unnecessary. You could directly use the `shutdown` to check.
   cc @pan3793.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org