You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2019/02/07 07:30:20 UTC

[GitHub] eolivelli commented on a change in pull request #1937: [bk-gc] Fix GC thread gets blocked

eolivelli commented on a change in pull request #1937: [bk-gc] Fix GC thread gets blocked
URL: https://github.com/apache/bookkeeper/pull/1937#discussion_r254569717
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java
 ##########
 @@ -431,6 +432,27 @@ public ServerConfiguration setVerifyMetadataOnGc(boolean verifyMetadataOnGC) {
         return this;
     }
 
+    /**
+     * Get zk-operation timeout in seconds used by GC while performing zk
 
 Review comment:
   If this is only for GC we should provide a more meaningful name.
   Can you change it please? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services