You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/21 06:42:34 UTC

[GitHub] [doris] jackwener commented on a diff in pull request #11066: [Refactor](Nereids) Remove expression type.

jackwener commented on code in PR #11066:
URL: https://github.com/apache/doris/pull/11066#discussion_r926307579


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/Regexp.java:
##########
@@ -30,19 +30,14 @@
 public class Regexp extends StringRegexPredicate {
 
     public Regexp(Expression left, Expression right) {
-        super(ExpressionType.REGEXP, left, right);
+        super(left, right, "regexp");
     }
 
     @Override
     public boolean nullable() throws UnboundException {
         return left().nullable();
     }
 
-    @Override

Review Comment:
   Why delete many `toString`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org