You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by venkat1m <gi...@git.apache.org> on 2016/02/08 19:48:05 UTC
[GitHub] incubator-trafodion pull request: Fix for REST Server pstack api
GitHub user venkat1m opened a pull request:
https://github.com/apache/incubator-trafodion/pull/311
Fix for REST Server pstack api
Fix for TRAFODION-1814 : REST Servers' pstack API does not return pstack information of process
https://issues.apache.org/jira/browse/TRAFODION-1814
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/venkat1m/incubator-trafodion TRAFODION-1814
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/311.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #311
----
commit 53a561c539fcea43e818e934f42fd338832e1ede
Author: Venkat Muthuswamy <ve...@esgyn.com>
Date: 2016-02-08T18:44:47Z
Fix for REST Server pstack api
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: Fix for REST Server pstack api
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/311#discussion_r52243757
--- Diff: core/rest/src/main/java/org/trafodion/rest/ServerResource.java ---
@@ -256,11 +246,13 @@ private JSONArray pstack(String program) throws IOException {
String line = scanner.nextLine();
if(line.contains("pstack-ing")) {
continue;
- } else if (line.contains("pstack")) {
- if(pstack == true) {
+ } else if (line.contains("pstack") || line.startsWith("--")) {
+ if (pstack == true && sb.length() > 0) {
--- End diff --
This change looks good to me. I gather that all the changes with the imports are just clean-ups unrelated to this change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: Fix for REST Server pstack api
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/311
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---