You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zipkin.apache.org by GitBox <gi...@apache.org> on 2019/05/28 22:20:22 UTC
[GitHub] [incubator-zipkin] abesto commented on a change in pull request
#2618: [zipin-lens] Fix #2615: Bundle Fontawesome into the app
abesto commented on a change in pull request #2618: [zipin-lens] Fix #2615: Bundle Fontawesome into the app
URL: https://github.com/apache/incubator-zipkin/pull/2618#discussion_r288325394
##########
File path: zipkin-lens/scss/main.scss
##########
@@ -15,10 +15,15 @@
// limitations under the License.
//
-@import '../node_modules/rc-calendar/assets/index.css';
-@import '../node_modules/rc-slider/assets/index.css';
-@import '../node_modules/rc-time-picker/assets/index.css';
-@import '../node_modules/react-table/react-table.css';
+@import '~rc-calendar/assets/index.css';
Review comment:
`~` is Webpack notation for "load from `node_modules`, wherever it is"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services