You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Abhishek Dasgupta <a1...@linux.vnet.ibm.com> on 2016/02/25 06:32:58 UTC
Re: Review Request 43715: Updated support/generate-endpoint-help.py to
include title.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43715/
-----------------------------------------------------------
(Updated Feb. 25, 2016, 5:32 a.m.)
Review request for mesos, Ben Mahler, Kevin Klues, and Neil Conway.
Summary (updated)
-----------------
Updated support/generate-endpoint-help.py to include title.
Repository: mesos
Description
-------
support/generate-endpoint-help.py is adding a title to every generated endpoint markdown file.
Diffs
-----
support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541
Diff: https://reviews.apache.org/r/43715/diff/
Testing
-------
This is the patch for support/generate-endpoint-help.py to include the generated files with titles.
Tested using "rake dev" on a live site.
Thanks,
Abhishek Dasgupta
Re: Review Request 43715: Updated support/generate-endpoint-help.py to
include title.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43715/#review121086
-----------------------------------------------------------
Ship it!
LGTM, but I didn't try to run the script to verify.
- Adam B
On Feb. 24, 2016, 9:32 p.m., Abhishek Dasgupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43715/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2016, 9:32 p.m.)
>
>
> Review request for mesos, Ben Mahler, Kevin Klues, and Neil Conway.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> support/generate-endpoint-help.py is adding a title to every generated endpoint markdown file.
>
>
> Diffs
> -----
>
> support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541
>
> Diff: https://reviews.apache.org/r/43715/diff/
>
>
> Testing
> -------
>
> This is the patch for support/generate-endpoint-help.py to include the generated files with titles.
> Tested using "rake dev" on a live site.
>
>
> Thanks,
>
> Abhishek Dasgupta
>
>