You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2014/04/02 17:41:03 UTC
Review Request 19927: Finalize 2.1 Stack definition for repo info file
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19927/
-----------------------------------------------------------
Review request for Ambari, Dmitro Lisnichenko, Mahadev Konar, and Sid Wagle.
Bugs: AMBARI-5304
https://issues.apache.org/jira/browse/AMBARI-5304
Repository: ambari
Description
-------
* Changes to support loading the latest url version
* Need to set the production url in the repo file for 2.1 (stackHome/repos/repoinfo.xml)
* Take care of base url being appended with the actual repo name.
* Use compatible OS base url for those OS that are not explicitly defined (per Jeff).
* Add test assertions for proper base url being loaded. These assertions are the test for the LatestRepoCallable class.
Diffs
-----
ambari-server/set-hdp-repo-url.sh e66d21e
ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java d1b5fdb
ambari-server/src/main/resources/stacks/HDP/2.1/repos/repoinfo.xml 0f5f61a
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 60936a1
ambari-server/src/test/resources/stacks/HDP/2.1.1/repos/hdp.json 8c47ae6
Diff: https://reviews.apache.org/r/19927/diff/
Testing
-------
Results :
Tests run: 1513, Failures: 0, Errors: 0, Skipped: 10
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13:54.360s
[INFO] Finished at: Wed Apr 02 11:03:40 EDT 2014
[INFO] Final Memory: 18M/123M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole
Re: Review Request 19927: Finalize 2.1 Stack definition for repo info file
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19927/#review39411
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On April 2, 2014, 9:02 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19927/
> -----------------------------------------------------------
>
> (Updated April 2, 2014, 9:02 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Mahadev Konar, and Sid Wagle.
>
>
> Bugs: AMBARI-5304
> https://issues.apache.org/jira/browse/AMBARI-5304
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Changes to support loading the latest url version
> * Need to set the production url in the repo file for 2.1 (stackHome/repos/repoinfo.xml)
> * Take care of base url being appended with the actual repo name.
> * Use compatible OS base url for those OS that are not explicitly defined (per Jeff).
> * Add test assertions for proper base url being loaded. These assertions are the test for the LatestRepoCallable class.
>
>
> Diffs
> -----
>
> ambari-server/pom.xml ff6cd76
> ambari-server/set-hdp-repo-url.sh e66d21e
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java d1b5fdb
> ambari-server/src/main/resources/stacks/HDP/2.1/repos/repoinfo.xml 0f5f61a
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 60936a1
> ambari-server/src/test/resources/stacks/HDP/2.1.1/repos/hdp.json 8c47ae6
>
> Diff: https://reviews.apache.org/r/19927/diff/
>
>
> Testing
> -------
>
>
> Results :
>
> Tests run: 1513, Failures: 0, Errors: 0, Skipped: 10
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:54.360s
> [INFO] Finished at: Wed Apr 02 11:03:40 EDT 2014
> [INFO] Final Memory: 18M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 19927: Finalize 2.1 Stack definition for repo info file
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19927/
-----------------------------------------------------------
(Updated April 2, 2014, 5:02 p.m.)
Review request for Ambari, Dmitro Lisnichenko, Mahadev Konar, and Sid Wagle.
Changes
-------
Updated patch to make the latest url a possible parameter at build time to facilitate testing (thanks Mahadev!).
Bugs: AMBARI-5304
https://issues.apache.org/jira/browse/AMBARI-5304
Repository: ambari
Description
-------
* Changes to support loading the latest url version
* Need to set the production url in the repo file for 2.1 (stackHome/repos/repoinfo.xml)
* Take care of base url being appended with the actual repo name.
* Use compatible OS base url for those OS that are not explicitly defined (per Jeff).
* Add test assertions for proper base url being loaded. These assertions are the test for the LatestRepoCallable class.
Diffs (updated)
-----
ambari-server/pom.xml ff6cd76
ambari-server/set-hdp-repo-url.sh e66d21e
ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java d1b5fdb
ambari-server/src/main/resources/stacks/HDP/2.1/repos/repoinfo.xml 0f5f61a
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 60936a1
ambari-server/src/test/resources/stacks/HDP/2.1.1/repos/hdp.json 8c47ae6
Diff: https://reviews.apache.org/r/19927/diff/
Testing
-------
Results :
Tests run: 1513, Failures: 0, Errors: 0, Skipped: 10
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13:54.360s
[INFO] Finished at: Wed Apr 02 11:03:40 EDT 2014
[INFO] Final Memory: 18M/123M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole
Re: Review Request 19927: Finalize 2.1 Stack definition for repo info file
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19927/#review39298
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On April 2, 2014, 3:40 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19927/
> -----------------------------------------------------------
>
> (Updated April 2, 2014, 3:40 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Mahadev Konar, and Sid Wagle.
>
>
> Bugs: AMBARI-5304
> https://issues.apache.org/jira/browse/AMBARI-5304
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Changes to support loading the latest url version
> * Need to set the production url in the repo file for 2.1 (stackHome/repos/repoinfo.xml)
> * Take care of base url being appended with the actual repo name.
> * Use compatible OS base url for those OS that are not explicitly defined (per Jeff).
> * Add test assertions for proper base url being loaded. These assertions are the test for the LatestRepoCallable class.
>
>
> Diffs
> -----
>
> ambari-server/set-hdp-repo-url.sh e66d21e
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java d1b5fdb
> ambari-server/src/main/resources/stacks/HDP/2.1/repos/repoinfo.xml 0f5f61a
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 60936a1
> ambari-server/src/test/resources/stacks/HDP/2.1.1/repos/hdp.json 8c47ae6
>
> Diff: https://reviews.apache.org/r/19927/diff/
>
>
> Testing
> -------
>
>
> Results :
>
> Tests run: 1513, Failures: 0, Errors: 0, Skipped: 10
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:54.360s
> [INFO] Finished at: Wed Apr 02 11:03:40 EDT 2014
> [INFO] Final Memory: 18M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>