You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metamodel.apache.org by Kasper Sørensen <i....@gmail.com> on 2014/12/04 19:46:06 UTC

Review Request 28707: METAMODEL-100: Fixed comparison of columns based on col number

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28707/
-----------------------------------------------------------

Review request for MetaModel.


Bugs: METAMODEL-100
    https://issues.apache.org/jira/browse/METAMODEL-100


Repository: metamodel


Description
-------

My proposed fix for METAMODEL-100


Diffs
-----

  core/src/main/java/org/apache/metamodel/schema/AbstractColumn.java 8f276f5 
  core/src/test/java/org/apache/metamodel/QueryPostprocessDataContextTest.java 3b2be2f 

Diff: https://reviews.apache.org/r/28707/diff/


Testing
-------

Unittest added to show the issue.


Thanks,

Kasper Sørensen


Re: Review Request 28707: METAMODEL-100: Fixed comparison of columns based on col number

Posted by Tomasz Guzialek <to...@guzialek.info>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28707/#review63978
-----------------------------------------------------------

Ship it!


Ship It!

- Tomasz Guzialek


On Dec. 4, 2014, 6:46 p.m., Kasper Sørensen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28707/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2014, 6:46 p.m.)
> 
> 
> Review request for MetaModel.
> 
> 
> Bugs: METAMODEL-100
>     https://issues.apache.org/jira/browse/METAMODEL-100
> 
> 
> Repository: metamodel
> 
> 
> Description
> -------
> 
> My proposed fix for METAMODEL-100
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/metamodel/schema/AbstractColumn.java 8f276f5 
>   core/src/test/java/org/apache/metamodel/QueryPostprocessDataContextTest.java 3b2be2f 
> 
> Diff: https://reviews.apache.org/r/28707/diff/
> 
> 
> Testing
> -------
> 
> Unittest added to show the issue.
> 
> 
> Thanks,
> 
> Kasper Sørensen
> 
>