You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/11/04 10:11:42 UTC
[GitHub] [spark] dhirennavani opened a new pull request #34484: [SPARK-37207][PySpark] Add isEmpty method for the Python DataFrame API
dhirennavani opened a new pull request #34484:
URL: https://github.com/apache/spark/pull/34484
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Add isEmpty method for the Python DataFrame API
### Why are the changes needed?
Python Scala compatibility
### Does this PR introduce _any_ user-facing change?
Is Empty method would in in data frame api
### How was this patch tested?
Unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961085163
**[Test build #144901 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144901/testReport)** for PR 34484 at commit [`ed17e96`](https://github.com/apache/spark/commit/ed17e963519ab1d565e9ccad261ea9fbd4f59e12).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961359913
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961290488
**[Test build #144905 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144905/testReport)** for PR 34484 at commit [`eddce84`](https://github.com/apache/spark/commit/eddce8494c2a45553b224cc43ac1de7b647d2edc).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961308672
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49376/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961595327
**[Test build #144914 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144914/testReport)** for PR 34484 at commit [`6877c70`](https://github.com/apache/spark/commit/6877c7052826276b2ff844a6828e5e585499f3ba).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961679940
**[Test build #144922 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144922/testReport)** for PR 34484 at commit [`f092312`](https://github.com/apache/spark/commit/f092312b501b88470416c718fdfbe6db38dee443).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-962744936
Late LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961276118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #34484:
URL: https://github.com/apache/spark/pull/34484#discussion_r743355642
##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -473,6 +473,23 @@ def isStreaming(self) -> bool:
"""
return self._jdf.isStreaming()
+ def isEmpty(self) -> bool:
+ """Returns ``True`` if this :class:`DataFrame` is empty.
+
+ .. versionadded:: 3.3.0
+
+ Examples
Review comment:
```suggestion
Examples
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961166077
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144901/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961603574
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49385/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #34484:
URL: https://github.com/apache/spark/pull/34484#discussion_r743325893
##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -473,6 +473,23 @@ def isStreaming(self) -> bool:
"""
return self._jdf.isStreaming()
+ def isEmpty(self) -> bool:
+ """Returns ``True`` if this :class:`DataFrame` is empty.
+
+ .. versionadded:: 3.3.0
+
+ Examples
+ --------
+ >>> df_empty = spark.createDataFrame([], 'a STRING')
+ >>> df_non_empty = spark.createDataFrame([("a")], 'STRING')
+
Review comment:
No blank lines is necessary. Otherwise, the example section in the document build from the docstring is split.
Please confirm the layout of the document by `make html` in `python/docs`.
See also http://spark.apache.org/docs/latest/api/python/development/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961584849
ok to test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #34484:
URL: https://github.com/apache/spark/pull/34484#discussion_r743355642
##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -473,6 +473,23 @@ def isStreaming(self) -> bool:
"""
return self._jdf.isStreaming()
+ def isEmpty(self) -> bool:
+ """Returns ``True`` if this :class:`DataFrame` is empty.
+
+ .. versionadded:: 3.3.0
+
+ Examples
Review comment:
```suggestion
Examples
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961401555
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49378/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961602223
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49383/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961085163
**[Test build #144901 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144901/testReport)** for PR 34484 at commit [`ed17e96`](https://github.com/apache/spark/commit/ed17e963519ab1d565e9ccad261ea9fbd4f59e12).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dhirennavani commented on a change in pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
dhirennavani commented on a change in pull request #34484:
URL: https://github.com/apache/spark/pull/34484#discussion_r743081666
##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -473,6 +473,13 @@ def isStreaming(self) -> bool:
"""
return self._jdf.isStreaming()
+ def isEmpty(self) -> bool:
+ """Returns ``True`` if this :class:`DataFrame` is empty.
Review comment:
Done
##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -473,6 +473,23 @@ def isStreaming(self) -> bool:
"""
return self._jdf.isStreaming()
+ def isEmpty(self) -> bool:
+ """Returns ``True`` if this :class:`DataFrame` is empty.
+
+ .. versionadded:: 3.3.0
+
+ Examples
Review comment:
Fixed
##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -473,6 +473,23 @@ def isStreaming(self) -> bool:
"""
return self._jdf.isStreaming()
+ def isEmpty(self) -> bool:
+ """Returns ``True`` if this :class:`DataFrame` is empty.
+
+ .. versionadded:: 3.3.0
+
+ Examples
+ --------
+ >>> df_empty = spark.createDataFrame([], 'a STRING')
+ >>> df_non_empty = spark.createDataFrame([("a")], 'STRING')
+
Review comment:
Done. Thanks I am kinda new to this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961309206
@dhirennavani Now that we have a doctest for `isEmpty` instead of UT, could you modify the `How was this patch tested?` section in the description?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961604859
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144914/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dhirennavani commented on a change in pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
dhirennavani commented on a change in pull request #34484:
URL: https://github.com/apache/spark/pull/34484#discussion_r743081666
##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -473,6 +473,13 @@ def isStreaming(self) -> bool:
"""
return self._jdf.isStreaming()
+ def isEmpty(self) -> bool:
+ """Returns ``True`` if this :class:`DataFrame` is empty.
Review comment:
Done
##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -473,6 +473,23 @@ def isStreaming(self) -> bool:
"""
return self._jdf.isStreaming()
+ def isEmpty(self) -> bool:
+ """Returns ``True`` if this :class:`DataFrame` is empty.
+
+ .. versionadded:: 3.3.0
+
+ Examples
Review comment:
Fixed
##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -473,6 +473,23 @@ def isStreaming(self) -> bool:
"""
return self._jdf.isStreaming()
+ def isEmpty(self) -> bool:
+ """Returns ``True`` if this :class:`DataFrame` is empty.
+
+ .. versionadded:: 3.3.0
+
+ Examples
+ --------
+ >>> df_empty = spark.createDataFrame([], 'a STRING')
+ >>> df_non_empty = spark.createDataFrame([("a")], 'STRING')
+
Review comment:
Done. Thanks I am kinda new to this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961585664
**[Test build #144914 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144914/testReport)** for PR 34484 at commit [`6877c70`](https://github.com/apache/spark/commit/6877c7052826276b2ff844a6828e5e585499f3ba).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961276118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-962614438
Merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #34484:
URL: https://github.com/apache/spark/pull/34484#discussion_r743325893
##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -473,6 +473,23 @@ def isStreaming(self) -> bool:
"""
return self._jdf.isStreaming()
+ def isEmpty(self) -> bool:
+ """Returns ``True`` if this :class:`DataFrame` is empty.
+
+ .. versionadded:: 3.3.0
+
+ Examples
+ --------
+ >>> df_empty = spark.createDataFrame([], 'a STRING')
+ >>> df_non_empty = spark.createDataFrame([("a")], 'STRING')
+
Review comment:
No blank lines are necessary. Otherwise, the example section in the document built from the docstring is split.
Please confirm the layout of the document by `make html` in `python/docs`.
See also http://spark.apache.org/docs/latest/api/python/development/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961584849
ok to test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961615720
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49383/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961685644
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144922/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-960636894
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961276118
**[Test build #144905 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144905/testReport)** for PR 34484 at commit [`eddce84`](https://github.com/apache/spark/commit/eddce8494c2a45553b224cc43ac1de7b647d2edc).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961318625
**[Test build #144908 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144908/testReport)** for PR 34484 at commit [`6877c70`](https://github.com/apache/spark/commit/6877c7052826276b2ff844a6828e5e585499f3ba).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961380188
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49378/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #34484:
URL: https://github.com/apache/spark/pull/34484#discussion_r743325893
##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -473,6 +473,23 @@ def isStreaming(self) -> bool:
"""
return self._jdf.isStreaming()
+ def isEmpty(self) -> bool:
+ """Returns ``True`` if this :class:`DataFrame` is empty.
+
+ .. versionadded:: 3.3.0
+
+ Examples
+ --------
+ >>> df_empty = spark.createDataFrame([], 'a STRING')
+ >>> df_non_empty = spark.createDataFrame([("a")], 'STRING')
+
Review comment:
No blank lines necessary. Otherwise, the example section in the document build from the docstring is split.
Please confirm the layout of the document by `make html` in `python/docs`.
See also http://spark.apache.org/docs/latest/api/python/development/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961667167
**[Test build #144922 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144922/testReport)** for PR 34484 at commit [`f092312`](https://github.com/apache/spark/commit/f092312b501b88470416c718fdfbe6db38dee443).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961718379
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49392/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961139306
**[Test build #144901 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144901/testReport)** for PR 34484 at commit [`ed17e96`](https://github.com/apache/spark/commit/ed17e963519ab1d565e9ccad261ea9fbd4f59e12).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961584849
ok to test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961309206
@dhirennavani Now that we have a doctest for `isEmpty` instead of UT, could you modify the `How was this patch tested?` section in the description?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #34484:
URL: https://github.com/apache/spark/pull/34484#discussion_r743325893
##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -473,6 +473,23 @@ def isStreaming(self) -> bool:
"""
return self._jdf.isStreaming()
+ def isEmpty(self) -> bool:
+ """Returns ``True`` if this :class:`DataFrame` is empty.
+
+ .. versionadded:: 3.3.0
+
+ Examples
+ --------
+ >>> df_empty = spark.createDataFrame([], 'a STRING')
+ >>> df_non_empty = spark.createDataFrame([("a")], 'STRING')
+
Review comment:
No blank lines are necessary. Otherwise, the example section in the document build from the docstring is split.
Please confirm the layout of the document by `make html` in `python/docs`.
See also http://spark.apache.org/docs/latest/api/python/development/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961686382
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49392/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dhirennavani commented on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
dhirennavani commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961319643
> @dhirennavani Now that we have a doctest for `isEmpty` instead of UT, could you modify the `How was this patch tested?` section in the description?
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961220363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dhirennavani commented on a change in pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
dhirennavani commented on a change in pull request #34484:
URL: https://github.com/apache/spark/pull/34484#discussion_r743081666
##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -473,6 +473,13 @@ def isStreaming(self) -> bool:
"""
return self._jdf.isStreaming()
+ def isEmpty(self) -> bool:
+ """Returns ``True`` if this :class:`DataFrame` is empty.
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961318625
**[Test build #144908 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144908/testReport)** for PR 34484 at commit [`6877c70`](https://github.com/apache/spark/commit/6877c7052826276b2ff844a6828e5e585499f3ba).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961340040
**[Test build #144908 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144908/testReport)** for PR 34484 at commit [`6877c70`](https://github.com/apache/spark/commit/6877c7052826276b2ff844a6828e5e585499f3ba).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961276118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dhirennavani commented on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
dhirennavani commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961319643
> @dhirennavani Now that we have a doctest for `isEmpty` instead of UT, could you modify the `How was this patch tested?` section in the description?
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34484: [SPARK-37207][PySpark] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-960636894
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dhirennavani commented on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
dhirennavani commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961319643
> @dhirennavani Now that we have a doctest for `isEmpty` instead of UT, could you modify the `How was this patch tested?` section in the description?
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961585664
**[Test build #144914 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144914/testReport)** for PR 34484 at commit [`6877c70`](https://github.com/apache/spark/commit/6877c7052826276b2ff844a6828e5e585499f3ba).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #34484:
URL: https://github.com/apache/spark/pull/34484#discussion_r743325893
##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -473,6 +473,23 @@ def isStreaming(self) -> bool:
"""
return self._jdf.isStreaming()
+ def isEmpty(self) -> bool:
+ """Returns ``True`` if this :class:`DataFrame` is empty.
+
+ .. versionadded:: 3.3.0
+
+ Examples
+ --------
+ >>> df_empty = spark.createDataFrame([], 'a STRING')
+ >>> df_non_empty = spark.createDataFrame([("a")], 'STRING')
+
Review comment:
No blank lines necessary. Otherwise, the example section in the document build from the docstring is split.
Please confirm the layout of the document by `make html` in `python/docs`.
See also http://spark.apache.org/docs/latest/api/python/development/index.html
##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -473,6 +473,23 @@ def isStreaming(self) -> bool:
"""
return self._jdf.isStreaming()
+ def isEmpty(self) -> bool:
+ """Returns ``True`` if this :class:`DataFrame` is empty.
+
+ .. versionadded:: 3.3.0
+
+ Examples
+ --------
+ >>> df_empty = spark.createDataFrame([], 'a STRING')
+ >>> df_non_empty = spark.createDataFrame([("a")], 'STRING')
+
Review comment:
No blank lines is necessary. Otherwise, the example section in the document build from the docstring is split.
Please confirm the layout of the document by `make html` in `python/docs`.
See also http://spark.apache.org/docs/latest/api/python/development/index.html
##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -473,6 +473,23 @@ def isStreaming(self) -> bool:
"""
return self._jdf.isStreaming()
+ def isEmpty(self) -> bool:
+ """Returns ``True`` if this :class:`DataFrame` is empty.
+
+ .. versionadded:: 3.3.0
+
+ Examples
+ --------
+ >>> df_empty = spark.createDataFrame([], 'a STRING')
+ >>> df_non_empty = spark.createDataFrame([("a")], 'STRING')
+
Review comment:
No blank lines are necessary. Otherwise, the example section in the document build from the docstring is split.
Please confirm the layout of the document by `make html` in `python/docs`.
See also http://spark.apache.org/docs/latest/api/python/development/index.html
##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -473,6 +473,23 @@ def isStreaming(self) -> bool:
"""
return self._jdf.isStreaming()
+ def isEmpty(self) -> bool:
+ """Returns ``True`` if this :class:`DataFrame` is empty.
+
+ .. versionadded:: 3.3.0
+
+ Examples
+ --------
+ >>> df_empty = spark.createDataFrame([], 'a STRING')
+ >>> df_non_empty = spark.createDataFrame([("a")], 'STRING')
+
Review comment:
No blank lines are necessary. Otherwise, the example section in the document built from the docstring is split.
Please confirm the layout of the document by `make html` in `python/docs`.
See also http://spark.apache.org/docs/latest/api/python/development/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #34484:
URL: https://github.com/apache/spark/pull/34484#discussion_r743355642
##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -473,6 +473,23 @@ def isStreaming(self) -> bool:
"""
return self._jdf.isStreaming()
+ def isEmpty(self) -> bool:
+ """Returns ``True`` if this :class:`DataFrame` is empty.
+
+ .. versionadded:: 3.3.0
+
+ Examples
Review comment:
```suggestion
Examples
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961157173
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49371/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961309206
@dhirennavani Now that we have a doctest for `isEmpty` instead of UT, could you modify the `How was this patch tested?` section in the description?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961276118
**[Test build #144905 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144905/testReport)** for PR 34484 at commit [`eddce84`](https://github.com/apache/spark/commit/eddce8494c2a45553b224cc43ac1de7b647d2edc).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961623716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dhirennavani commented on a change in pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
dhirennavani commented on a change in pull request #34484:
URL: https://github.com/apache/spark/pull/34484#discussion_r743423805
##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -473,6 +473,23 @@ def isStreaming(self) -> bool:
"""
return self._jdf.isStreaming()
+ def isEmpty(self) -> bool:
+ """Returns ``True`` if this :class:`DataFrame` is empty.
+
+ .. versionadded:: 3.3.0
+
+ Examples
+ --------
+ >>> df_empty = spark.createDataFrame([], 'a STRING')
+ >>> df_non_empty = spark.createDataFrame([("a")], 'STRING')
+
Review comment:
Done. Thanks I am kinda new to this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #34484:
URL: https://github.com/apache/spark/pull/34484#discussion_r743325893
##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -473,6 +473,23 @@ def isStreaming(self) -> bool:
"""
return self._jdf.isStreaming()
+ def isEmpty(self) -> bool:
+ """Returns ``True`` if this :class:`DataFrame` is empty.
+
+ .. versionadded:: 3.3.0
+
+ Examples
+ --------
+ >>> df_empty = spark.createDataFrame([], 'a STRING')
+ >>> df_non_empty = spark.createDataFrame([("a")], 'STRING')
+
Review comment:
No blank lines necessary. Otherwise, the example section in the document build from the docstring is split.
Please confirm the layout of the document by `make html` in `python/docs`.
See also http://spark.apache.org/docs/latest/api/python/development/index.html
##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -473,6 +473,23 @@ def isStreaming(self) -> bool:
"""
return self._jdf.isStreaming()
+ def isEmpty(self) -> bool:
+ """Returns ``True`` if this :class:`DataFrame` is empty.
+
+ .. versionadded:: 3.3.0
+
+ Examples
+ --------
+ >>> df_empty = spark.createDataFrame([], 'a STRING')
+ >>> df_non_empty = spark.createDataFrame([("a")], 'STRING')
+
Review comment:
No blank lines is necessary. Otherwise, the example section in the document build from the docstring is split.
Please confirm the layout of the document by `make html` in `python/docs`.
See also http://spark.apache.org/docs/latest/api/python/development/index.html
##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -473,6 +473,23 @@ def isStreaming(self) -> bool:
"""
return self._jdf.isStreaming()
+ def isEmpty(self) -> bool:
+ """Returns ``True`` if this :class:`DataFrame` is empty.
+
+ .. versionadded:: 3.3.0
+
+ Examples
+ --------
+ >>> df_empty = spark.createDataFrame([], 'a STRING')
+ >>> df_non_empty = spark.createDataFrame([("a")], 'STRING')
+
Review comment:
No blank lines are necessary. Otherwise, the example section in the document build from the docstring is split.
Please confirm the layout of the document by `make html` in `python/docs`.
See also http://spark.apache.org/docs/latest/api/python/development/index.html
##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -473,6 +473,23 @@ def isStreaming(self) -> bool:
"""
return self._jdf.isStreaming()
+ def isEmpty(self) -> bool:
+ """Returns ``True`` if this :class:`DataFrame` is empty.
+
+ .. versionadded:: 3.3.0
+
+ Examples
+ --------
+ >>> df_empty = spark.createDataFrame([], 'a STRING')
+ >>> df_non_empty = spark.createDataFrame([("a")], 'STRING')
+
Review comment:
No blank lines are necessary. Otherwise, the example section in the document built from the docstring is split.
Please confirm the layout of the document by `make html` in `python/docs`.
See also http://spark.apache.org/docs/latest/api/python/development/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961667167
**[Test build #144922 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144922/testReport)** for PR 34484 at commit [`f092312`](https://github.com/apache/spark/commit/f092312b501b88470416c718fdfbe6db38dee443).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #34484: [SPARK-37207][PySpark] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #34484:
URL: https://github.com/apache/spark/pull/34484#discussion_r742896256
##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -473,6 +473,13 @@ def isStreaming(self) -> bool:
"""
return self._jdf.isStreaming()
+ def isEmpty(self) -> bool:
+ """Returns ``True`` if this :class:`DataFrame` is empty.
Review comment:
Could you add `Examples` section?
Then, I think we don't need additional tests for `isEmpty` in `test_dataframe.py`. The doctet is enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961195748
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49371/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961316862
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961220363
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49371/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #34484: [SPARK-37207][PySpark] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961066692
ok to test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961351390
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49378/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961621393
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49385/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dhirennavani commented on a change in pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
dhirennavani commented on a change in pull request #34484:
URL: https://github.com/apache/spark/pull/34484#discussion_r743423628
##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -473,6 +473,23 @@ def isStreaming(self) -> bool:
"""
return self._jdf.isStreaming()
+ def isEmpty(self) -> bool:
+ """Returns ``True`` if this :class:`DataFrame` is empty.
+
+ .. versionadded:: 3.3.0
+
+ Examples
Review comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961316862
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144905/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961339363
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49376/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34484:
URL: https://github.com/apache/spark/pull/34484#issuecomment-961718352
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49392/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #34484: [SPARK-37207][SQL][PYTHON] Add isEmpty method for the Python DataFrame API
Posted by GitBox <gi...@apache.org>.
srowen closed pull request #34484:
URL: https://github.com/apache/spark/pull/34484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org