You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Stephan Erb <se...@apache.org> on 2017/01/16 14:44:25 UTC
Review Request 55578: Log process sampling failures with debug
severity
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55578/
-----------------------------------------------------------
Review request for Aurora and Joshua Cohen.
Bugs: AURORA-1541
https://issues.apache.org/jira/browse/AURORA-1541
Repository: aurora
Description
-------
The observer's logs consist of lots of warnings about being unable to find PIDs. This is expected when running with the PID isolator, or when tasks when the checkpoint is out of date (e.g. if processes were killed by the OOM).
W0116 14:42:54.694221 3253 process_collector_psutil.py:75] Error during process sampling: psutil.NoSuchProcess process no longer exists (pid=27727)
W0116 14:42:54.717905 3253 process_collector_psutil.py:42] Error during process sampling [pid=10960]: psutil.NoSuchProcess process no longer exists (pid=10960)
W0116 14:42:54.718089 3253 process_collector_psutil.py:75] Error during process sampling: psutil.NoSuchProcess process no longer exists (pid=10960)
W0116 14:42:54.718245 3253 process_collector_psutil.py:42] Error during process sampling [pid=10026]: psutil.NoSuchProcess process no longer exists (pid=10026)
W0116 14:42:54.718334 3253 process_collector_psutil.py:75] Error during process sampling: psutil.NoSuchProcess process no longer exists (pid=10026)
This change adopts the proposal of David Robinson to decrease the severity level to debug.
Diffs
-----
src/main/python/apache/thermos/monitoring/process_collector_psutil.py 4a1b159637ae18113aa7f4d10a0864be0fd1e920
Diff: https://reviews.apache.org/r/55578/diff/
Testing
-------
./pants test.pytest src/{main,test}/python:: -- -v
Thanks,
Stephan Erb
Re: Review Request 55578: Log process sampling failures with debug
severity
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55578/#review161913
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On Jan. 16, 2017, 6:44 a.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55578/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2017, 6:44 a.m.)
>
>
> Review request for Aurora and Joshua Cohen.
>
>
> Bugs: AURORA-1541
> https://issues.apache.org/jira/browse/AURORA-1541
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The observer's logs consist of lots of warnings about being unable to find PIDs. This is expected when running with the PID isolator, or when tasks when the checkpoint is out of date (e.g. if processes were killed by the OOM).
>
> W0116 14:42:54.694221 3253 process_collector_psutil.py:75] Error during process sampling: psutil.NoSuchProcess process no longer exists (pid=27727)
> W0116 14:42:54.717905 3253 process_collector_psutil.py:42] Error during process sampling [pid=10960]: psutil.NoSuchProcess process no longer exists (pid=10960)
> W0116 14:42:54.718089 3253 process_collector_psutil.py:75] Error during process sampling: psutil.NoSuchProcess process no longer exists (pid=10960)
> W0116 14:42:54.718245 3253 process_collector_psutil.py:42] Error during process sampling [pid=10026]: psutil.NoSuchProcess process no longer exists (pid=10026)
> W0116 14:42:54.718334 3253 process_collector_psutil.py:75] Error during process sampling: psutil.NoSuchProcess process no longer exists (pid=10026)
>
> This change adopts the proposal of David Robinson to decrease the severity level to debug.
>
>
> Diffs
> -----
>
> src/main/python/apache/thermos/monitoring/process_collector_psutil.py 4a1b159637ae18113aa7f4d10a0864be0fd1e920
>
> Diff: https://reviews.apache.org/r/55578/diff/
>
>
> Testing
> -------
>
> ./pants test.pytest src/{main,test}/python:: -- -v
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 55578: Log process sampling failures with debug
severity
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55578/#review161934
-----------------------------------------------------------
Ship it!
Ship It!
- Joshua Cohen
On Jan. 16, 2017, 2:44 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55578/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2017, 2:44 p.m.)
>
>
> Review request for Aurora and Joshua Cohen.
>
>
> Bugs: AURORA-1541
> https://issues.apache.org/jira/browse/AURORA-1541
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The observer's logs consist of lots of warnings about being unable to find PIDs. This is expected when running with the PID isolator, or when tasks when the checkpoint is out of date (e.g. if processes were killed by the OOM).
>
> W0116 14:42:54.694221 3253 process_collector_psutil.py:75] Error during process sampling: psutil.NoSuchProcess process no longer exists (pid=27727)
> W0116 14:42:54.717905 3253 process_collector_psutil.py:42] Error during process sampling [pid=10960]: psutil.NoSuchProcess process no longer exists (pid=10960)
> W0116 14:42:54.718089 3253 process_collector_psutil.py:75] Error during process sampling: psutil.NoSuchProcess process no longer exists (pid=10960)
> W0116 14:42:54.718245 3253 process_collector_psutil.py:42] Error during process sampling [pid=10026]: psutil.NoSuchProcess process no longer exists (pid=10026)
> W0116 14:42:54.718334 3253 process_collector_psutil.py:75] Error during process sampling: psutil.NoSuchProcess process no longer exists (pid=10026)
>
> This change adopts the proposal of David Robinson to decrease the severity level to debug.
>
>
> Diffs
> -----
>
> src/main/python/apache/thermos/monitoring/process_collector_psutil.py 4a1b159637ae18113aa7f4d10a0864be0fd1e920
>
> Diff: https://reviews.apache.org/r/55578/diff/
>
>
> Testing
> -------
>
> ./pants test.pytest src/{main,test}/python:: -- -v
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 55578: Log process sampling failures with debug
severity
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55578/#review161739
-----------------------------------------------------------
Master (b75dfb8) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 16, 2017, 2:44 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55578/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2017, 2:44 p.m.)
>
>
> Review request for Aurora and Joshua Cohen.
>
>
> Bugs: AURORA-1541
> https://issues.apache.org/jira/browse/AURORA-1541
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The observer's logs consist of lots of warnings about being unable to find PIDs. This is expected when running with the PID isolator, or when tasks when the checkpoint is out of date (e.g. if processes were killed by the OOM).
>
> W0116 14:42:54.694221 3253 process_collector_psutil.py:75] Error during process sampling: psutil.NoSuchProcess process no longer exists (pid=27727)
> W0116 14:42:54.717905 3253 process_collector_psutil.py:42] Error during process sampling [pid=10960]: psutil.NoSuchProcess process no longer exists (pid=10960)
> W0116 14:42:54.718089 3253 process_collector_psutil.py:75] Error during process sampling: psutil.NoSuchProcess process no longer exists (pid=10960)
> W0116 14:42:54.718245 3253 process_collector_psutil.py:42] Error during process sampling [pid=10026]: psutil.NoSuchProcess process no longer exists (pid=10026)
> W0116 14:42:54.718334 3253 process_collector_psutil.py:75] Error during process sampling: psutil.NoSuchProcess process no longer exists (pid=10026)
>
> This change adopts the proposal of David Robinson to decrease the severity level to debug.
>
>
> Diffs
> -----
>
> src/main/python/apache/thermos/monitoring/process_collector_psutil.py 4a1b159637ae18113aa7f4d10a0864be0fd1e920
>
> Diff: https://reviews.apache.org/r/55578/diff/
>
>
> Testing
> -------
>
> ./pants test.pytest src/{main,test}/python:: -- -v
>
>
> Thanks,
>
> Stephan Erb
>
>