[jira] [Resolved] (KAFKA-1550) Patch review tool should use git format-patch to generate patch

["Joel Koshy (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/KAFKA-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joel Koshy resolved KAFKA-1550.
-------------------------------

    Resolution: Fixed

Committed to trunk.

> Patch review tool should use git format-patch to generate patch
> ---------------------------------------------------------------
>
>                 Key: KAFKA-1550
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1550
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Dong Lin
>            Assignee: Dong Lin
>            Priority: Minor
>         Attachments: KAFKA-1550.patch, KAFKA-1550_2014-07-22_11:41:57.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> 1) kafka-patch-review.py uses git-diff to generate patch for jira ticket. The resulting patch includes local uncommitted changes and also maybe different from the patch published to reviewboard.
> 2) kafka-patch-review.py will still update the jira ticket with the patch even if the reviewboard is not updated.



--
This message was sent by Atlassian JIRA
(v6.2#6252)