You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/08/02 11:24:25 UTC

[GitHub] [camel-k] orpiske commented on pull request #2540: Forcelly set QUARKUS_LOG_CONSOLE_JSON to false if the trait is not provided (GH issue #2539)

orpiske commented on pull request #2540:
URL: https://github.com/apache/camel-k/pull/2540#issuecomment-890947687


   > @orpiske would this env var lead to a warning if the json loggign extension is not on the classpath ?
   
   I believe the warning should go away in this case. I was looking in the code and we are already including the [quarkus-logging-json in the classpath](https://github.com/apache/camel-k/blob/main/pkg/trait/logging.go#L32) when the json logging is true.
   
   
   Now that we changed the default behavior if unset, I don't think we should get into a situation where it tries to log via json and it is not on the classpath. What do you think? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org