You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@submarine.apache.org by "Zhankun Tang (Jira)" <ji...@apache.org> on 2020/03/16 01:41:00 UTC
[jira] [Assigned] (SUBMARINE-429) Fix conflicts of java indentation
between ".editorconfig" and mvn checkstyle plugin
[ https://issues.apache.org/jira/browse/SUBMARINE-429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhankun Tang reassigned SUBMARINE-429:
--------------------------------------
Assignee: Zhankun Tang (was: Wanqiang Ji)
> Fix conflicts of java indentation between ".editorconfig" and mvn checkstyle plugin
> -----------------------------------------------------------------------------------
>
> Key: SUBMARINE-429
> URL: https://issues.apache.org/jira/browse/SUBMARINE-429
> Project: Apache Submarine
> Issue Type: Bug
> Components: CI/CD
> Reporter: Zhankun Tang
> Assignee: Zhankun Tang
> Priority: Major
>
> The ".editorconfig" enforced all the java indent size to 2 which will cause conflicts when maven check-style plugin does checking.
> [https://github.com/apache/submarine/commit/e3b5c5cda9c8cc59ddc8a2406fac4211c68b17cf]
> Since we have a more flexible check setting in the maven plugin. I suggest that we remove the java/scala style definition in ".editorconfig".
> Or if possible, we can provide different editor's configuration to enforce language style when using the recommended IDE.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org