You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2024/11/01 16:02:48 UTC
Re: [PR] Add config option `skip_physical_aggregate_schema_check ` [datafusion]
alamb commented on PR #13176:
URL: https://github.com/apache/datafusion/pull/13176#issuecomment-2452128438
> Looking at #13190 It seems that schema check is too strict (It should allow fulfilling nulllable contract with non-null data, but not the other way around).
>
> If we relax the check around this, how many problems would remain to be addressed?
It seems to me the check is finding real things (where the schema of the `ExecutionPlan` doesn't match the schema of the `LogicalPlan` from when it was created)
However, it also seems to me like maybe the discrepancy isn't a huge deal (so maybe it shouldn't be an error 🤔 )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org