You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/10/17 13:58:55 UTC
[GitHub] [commons-lang] nstdio opened a new pull request #630: [LANG-1609] Case-insensitive variants for startsWithAny and endsWithAny.
nstdio opened a new pull request #630:
URL: https://github.com/apache/commons-lang/pull/630
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] coveralls edited a comment on pull request #630: [LANG-1609] Case-insensitive variants for startsWithAny and endsWithAny.
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #630:
URL: https://github.com/apache/commons-lang/pull/630#issuecomment-711012742
[](https://coveralls.io/builds/34429388)
Coverage increased (+0.001%) to 94.69% when pulling **71880a181513be43489073c67ba4bcc512a3cbe8 on nstdio:LANG-1609** into **110b4c021e4901efab91499fedcdfb43c564ebdf on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] coveralls edited a comment on pull request #630: [LANG-1609] Case-insensitive variants for startsWithAny and endsWithAny.
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #630:
URL: https://github.com/apache/commons-lang/pull/630#issuecomment-711012742
[](https://coveralls.io/builds/34560007)
Coverage increased (+0.3%) to 94.948% when pulling **41e89258a7541c3f9f2ea2720a1a4a58f7ee027e on nstdio:LANG-1609** into **110b4c021e4901efab91499fedcdfb43c564ebdf on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] HubertWo commented on a change in pull request #630: [LANG-1609] Case-insensitive variants for startsWithAny and endsWithAny.
Posted by GitBox <gi...@apache.org>.
HubertWo commented on a change in pull request #630:
URL: https://github.com/apache/commons-lang/pull/630#discussion_r512085862
##########
File path: src/main/java/org/apache/commons/lang3/StringUtils.java
##########
@@ -8101,17 +8131,47 @@ private static boolean startsWith(final CharSequence str, final CharSequence pre
* @since 3.0 Changed signature from startsWithAny(String, String[]) to startsWithAny(CharSequence, CharSequence...)
*/
public static boolean startsWithAny(final CharSequence sequence, final CharSequence... searchStrings) {
+ return startsWithAny(sequence, searchStrings, false);
+ }
+
+ private static boolean startsWithAny(final CharSequence sequence, final CharSequence[] searchStrings,
+ boolean ignoreCase) {
Review comment:
Please declare ```ignoreCase``` argument as ```final```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #630: [LANG-1609] Case-insensitive variants for startsWithAny and endsWithAny.
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #630:
URL: https://github.com/apache/commons-lang/pull/630#issuecomment-718738987
I should be able to take a look tonight (EST)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] coveralls commented on pull request #630: [LANG-1609] Case-insensitive variants for startsWithAny and endsWithAny.
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #630:
URL: https://github.com/apache/commons-lang/pull/630#issuecomment-711012742
[](https://coveralls.io/builds/34251170)
Coverage decreased (-0.005%) to 94.701% when pulling **fe7c5d04f6fa9cbe89097f3e8c1aaf561f6e7dbd on nstdio:LANG-1609** into **43c80576cfe661b6f832ec7db51ab0077711f0ed on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory edited a comment on pull request #630: [LANG-1609] Case-insensitive variants for startsWithAny and endsWithAny.
Posted by GitBox <gi...@apache.org>.
garydgregory edited a comment on pull request #630:
URL: https://github.com/apache/commons-lang/pull/630#issuecomment-718738987
I should be able to take a look tonight (GMT-4)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org