[GitHub] [guacamole-client] m-khan-glyptodon commented on a change in pull request #419: GUACAMOLE-302: Incorrect password field focus

[GitBox <gi...@apache.org>]

m-khan-glyptodon commented on a change in pull request #419: GUACAMOLE-302: Incorrect password field focus
URL: https://github.com/apache/guacamole-client/pull/419#discussion_r296903205
 
 

 ##########
 File path: guacamole/src/main/webapp/app/form/templates/timeZoneField.html
 ##########
 @@ -3,12 +3,14 @@
     <!-- Available time zone regions -->
     <select class="time-zone-region"
             ng-disabled="disabled"
+            guac-focus="focused"   
             ng-model="region"
             ng-options="name for name in regions | orderBy: name"></select>
 
     <!-- Time zones within selected region -->
     <select class="time-zone"
             ng-disabled="disabled || !region"
+            guac-focus="focused"
 
 Review comment:
   What you point out is indeed correct and there was no legit reasoning behind this besides the fact that I was applying this `guac-focus` on every field template out there. I will make appropriate changes based on actual reasoning this time around.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services