[GitHub] [superset] AAfghahi commented on a change in pull request #17464: chore(sql_lab): Added Unit Test for stop query exception

[GitBox <gi...@apache.org>]

AAfghahi commented on a change in pull request #17464:
URL: https://github.com/apache/superset/pull/17464#discussion_r751489361



##########
File path: tests/integration_tests/core_tests.py
##########
@@ -1548,6 +1548,30 @@ def test_dashboard_injected_exceptions(self, mock_db_connection_mutator):
         data = self.get_resp(url)
         self.assertIn("Error message", data)
 
+    @mock.patch("superset.sql_lab.cancel_query")
+    def test_stop_query_no_cancel_query(self, mock_sql_lab_cancel_query):
+        """
+        Handles stop query when the DB engine spec does not
+        have a cancel query method.
+        """
+        form_data = {"client_id": "foo"}
+        query_mock = mock.Mock()
+        query_mock.sql = "SELECT *"
+        query_mock.database = 1
+        query_mock.schema = "superset"
+        query_mock.client_id = "foo"
+        query_mock.status = QueryStatus.RUNNING
+        self.login(username="admin")
+
+        with mock.patch("superset.views.core.db") as mock_superset_db:
+            mock_superset_db.session.query().filter_by().one().return_value = query_mock
+            mock_sql_lab_cancel_query.return_value = False
+            rv = self.client.post(
+                "/superset/stop_query/", data={"form_data": json.dumps(form_data)},
+            )
+
+        self.assertEqual(rv.status_code, 422)

Review comment:
       changed! I forgot about this. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org