You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Xiang Yang (Code Review)" <ge...@cloudera.org> on 2022/08/22 14:24:21 UTC
[native-toolchain-CR] IMPALA-11454: part-2: create kudu binaries symlinks to reduce package size.
Xiang Yang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18880
Change subject: IMPALA-11454: part-2: create kudu binaries symlinks to reduce package size.
......................................................................
IMPALA-11454: part-2: create kudu binaries symlinks to reduce package size.
The standard apache kudu binaries (kudu-master and kudu-tserver) only
exists in /sbin, however the toolchain packaging script will also copy
them to /bin, leading to larger package size.
This patch create symlinks for kudu-master and kudu-tserver under /bin,
to reduce package size and keep forward compatbility.
Testing:
- build kudu package, then check the output of '/bin/kudu-master --version'
and '/bin/kudu-tserver --version'.
Change-Id: Ibc1904be06f84acebf056a079dc1b6694032de87
---
M source/kudu/build.sh
1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/80/18880/1
--
To view, visit http://gerrit.cloudera.org:8080/18880
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibc1904be06f84acebf056a079dc1b6694032de87
Gerrit-Change-Number: 18880
Gerrit-PatchSet: 1
Gerrit-Owner: Xiang Yang <yx...@126.com>
[native-toolchain-CR] IMPALA-11454: part-2: create kudu binaries symlinks to reduce package size.
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18880 )
Change subject: IMPALA-11454: part-2: create kudu binaries symlinks to reduce package size.
......................................................................
IMPALA-11454: part-2: create kudu binaries symlinks to reduce package size.
The standard apache kudu binaries (kudu-master and kudu-tserver) only
exists in /sbin, however the toolchain packaging script will also copy
them to /bin, leading to larger package size.
This patch create symlinks for kudu-master and kudu-tserver under /bin,
to reduce package size and keep forward compatbility.
Testing:
- build kudu package, then check the output of '/bin/kudu-master --version'
and '/bin/kudu-tserver --version'.
Change-Id: Ibc1904be06f84acebf056a079dc1b6694032de87
Reviewed-on: http://gerrit.cloudera.org:8080/18880
Reviewed-by: Quanlong Huang <hu...@gmail.com>
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Joe McDonnell <jo...@cloudera.com>
---
M source/kudu/build.sh
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Quanlong Huang: Looks good to me, but someone else must approve
Wenzhe Zhou: Looks good to me, but someone else must approve
Joe McDonnell: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18880
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc1904be06f84acebf056a079dc1b6694032de87
Gerrit-Change-Number: 18880
Gerrit-PatchSet: 2
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiang Yang <yx...@126.com>
[native-toolchain-CR] IMPALA-11454: part-2: create kudu binaries symlinks to reduce package size.
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18880 )
Change subject: IMPALA-11454: part-2: create kudu binaries symlinks to reduce package size.
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18880
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc1904be06f84acebf056a079dc1b6694032de87
Gerrit-Change-Number: 18880
Gerrit-PatchSet: 1
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiang Yang <yx...@126.com>
Gerrit-Comment-Date: Wed, 24 Aug 2022 16:02:45 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-11454: part-2: create kudu binaries symlinks to reduce package size.
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18880 )
Change subject: IMPALA-11454: part-2: create kudu binaries symlinks to reduce package size.
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18880
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc1904be06f84acebf056a079dc1b6694032de87
Gerrit-Change-Number: 18880
Gerrit-PatchSet: 1
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiang Yang <yx...@126.com>
Gerrit-Comment-Date: Tue, 23 Aug 2022 14:26:12 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-11454: part-2: create kudu binaries symlinks to reduce package size.
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18880 )
Change subject: IMPALA-11454: part-2: create kudu binaries symlinks to reduce package size.
......................................................................
Patch Set 1: Code-Review+2
The toolchain build succeeded, and I put together this Impala side change with the new toolchain build (207-21f1a0057a). That change passed our core tests.
So, this is good to go. When the Impala patch is ready to go, we'll merge them both at the same time.
--
To view, visit http://gerrit.cloudera.org:8080/18880
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc1904be06f84acebf056a079dc1b6694032de87
Gerrit-Change-Number: 18880
Gerrit-PatchSet: 1
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiang Yang <yx...@126.com>
Gerrit-Comment-Date: Wed, 24 Aug 2022 05:37:10 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-11454: part-2: create kudu binaries symlinks to reduce package size.
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18880 )
Change subject: IMPALA-11454: part-2: create kudu binaries symlinks to reduce package size.
......................................................................
Patch Set 1:
I'm running our toolchain build job, and I'll try out the resulting toolchain with Impala. I'll let you know how it goes.
Codewise, this looks good.
--
To view, visit http://gerrit.cloudera.org:8080/18880
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc1904be06f84acebf056a079dc1b6694032de87
Gerrit-Change-Number: 18880
Gerrit-PatchSet: 1
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiang Yang <yx...@126.com>
Gerrit-Comment-Date: Tue, 23 Aug 2022 03:35:30 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-11454: part-2: create kudu binaries symlinks to reduce package size.
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18880 )
Change subject: IMPALA-11454: part-2: create kudu binaries symlinks to reduce package size.
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18880
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc1904be06f84acebf056a079dc1b6694032de87
Gerrit-Change-Number: 18880
Gerrit-PatchSet: 1
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiang Yang <yx...@126.com>
Gerrit-Comment-Date: Tue, 23 Aug 2022 00:11:29 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-11454: part-2: create kudu binaries symlinks to reduce package size.
Posted by "Xiang Yang (Code Review)" <ge...@cloudera.org>.
Xiang Yang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18880 )
Change subject: IMPALA-11454: part-2: create kudu binaries symlinks to reduce package size.
......................................................................
Patch Set 1:
Hi joe, wenzhe, quanlong, can you help me to review this issue? thanks.
--
To view, visit http://gerrit.cloudera.org:8080/18880
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc1904be06f84acebf056a079dc1b6694032de87
Gerrit-Change-Number: 18880
Gerrit-PatchSet: 1
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiang Yang <yx...@126.com>
Gerrit-Comment-Date: Mon, 22 Aug 2022 14:27:13 +0000
Gerrit-HasComments: No