You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "asia-zengtao (via GitHub)" <gi...@apache.org> on 2023/06/29 01:59:22 UTC

[GitHub] [shardingsphere] asia-zengtao opened a new pull request, #26680: Code performance optimization and database connection closure optimiz…

asia-zengtao opened a new pull request, #26680:
URL: https://github.com/apache/shardingsphere/pull/26680

   …ation
   
   The current implementation iterates over the created connections and closes them every time an exception is caught. This approach is inefficient, it is recommended to handle the exception after the loop ends and use the closeConnections() method to close the connections.
   
   Fixes #ISSUSE_ID.
   
   Changes proposed in this pull request:
     -
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [ ] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] TeslaCN commented on pull request #26680: Code performance optimization and database connection closure optimiz…

Posted by "TeslaCN (via GitHub)" <gi...@apache.org>.
TeslaCN commented on PR #26680:
URL: https://github.com/apache/shardingsphere/pull/26680#issuecomment-1643355454

   Close due to no response.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] TeslaCN closed pull request #26680: Code performance optimization and database connection closure optimiz…

Posted by "TeslaCN (via GitHub)" <gi...@apache.org>.
TeslaCN closed pull request #26680: Code performance optimization and database connection closure optimiz…
URL: https://github.com/apache/shardingsphere/pull/26680


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] TeslaCN commented on pull request #26680: Code performance optimization and database connection closure optimiz…

Posted by "TeslaCN (via GitHub)" <gi...@apache.org>.
TeslaCN commented on PR #26680:
URL: https://github.com/apache/shardingsphere/pull/26680#issuecomment-1623688919

   The loop would be broken after exception occurred. I can't see the difference of these changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org