[GitHub] [airflow] ashb commented on a change in pull request #8377: Use python client in BQ hook create_empty_table method

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #8377: Use python client in BQ hook create_empty_table method
URL: https://github.com/apache/airflow/pull/8377#discussion_r409038254
 
 

 ##########
 File path: airflow/providers/google/cloud/hooks/bigquery.py
 ##########
 @@ -227,45 +236,43 @@ def create_empty_table(self,  # pylint: disable=too-many-arguments
         :type num_retries: int
         :return: None
         """
-        service = self.get_service()
-
-        project_id = project_id if project_id is not None else self.project_id
+        if num_retries:
+            warnings.warn("Parameter `num_retries` is deprecated", DeprecationWarning)
 
 Review comment:
   Is it now just ignored? (Because it can never fail?)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services