You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openwhisk.apache.org by David P Grove <gr...@us.ibm.com> on 2017/09/14 11:21:45 UTC
reviews needed for kube PRs
Hi,
I'd appreciate it if someone with commit privileges could review and
merge assuming they are acceptable Dan's 3 outstanding PRs against the kube
repo. I'd like to maintain a reasonable rate of forward progress on this
effort.
thanks,
--dave
[1] https://github.com/apache/incubator-openwhisk-deploy-kube/pull/54
[2] https://github.com/apache/incubator-openwhisk-deploy-kube/pull/52
[3] https://github.com/apache/incubator-openwhisk-deploy-kube/pull/51
Re: reviews needed for kube PRs
Posted by Carlos Santana <cs...@gmail.com>.
David you can also have someone that doesn't have write access to review
PRs,
When they go to the "Files Changes" you can leave your review there.
That's what we have be doing with some of the PRs in the core repo having
folks that are not committers yet review the PR, and if there are tests and
they are passing then merging is just a click of a button.
It looks like this PRs are from Dan, and you reviewed them so they are good
to do.
On Thu, Sep 14, 2017 at 7:22 AM David P Grove <gr...@us.ibm.com> wrote:
>
>
> Hi,
>
> I'd appreciate it if someone with commit privileges could review
> and
> merge assuming they are acceptable Dan's 3 outstanding PRs against the kube
> repo. I'd like to maintain a reasonable rate of forward progress on this
> effort.
>
> thanks,
>
> --dave
>
> [1] https://github.com/apache/incubator-openwhisk-deploy-kube/pull/54
> [2] https://github.com/apache/incubator-openwhisk-deploy-kube/pull/52
> [3] https://github.com/apache/incubator-openwhisk-deploy-kube/pull/51
>