[GitHub] [kvrocks] infdahai commented on a diff in pull request #1517: Add support of new command: ZINTER / ZINTERCARD

["infdahai (via GitHub)" <gi...@apache.org>]

infdahai commented on code in PR #1517:
URL: https://github.com/apache/kvrocks/pull/1517#discussion_r1243219359


##########
src/commands/cmd_zset.cc:
##########
@@ -1340,6 +1469,8 @@ REDIS_REGISTER_COMMANDS(MakeCmdAttr<CommandZAdd>("zadd", -4, "write", 1, 1, 1),
                         MakeCmdAttr<CommandZCount>("zcount", 4, "read-only", 1, 1, 1),
                         MakeCmdAttr<CommandZIncrBy>("zincrby", 4, "write", 1, 1, 1),
                         MakeCmdAttr<CommandZInterStore>("zinterstore", -4, "write", 1, 1, 1),
+                        MakeCmdAttr<CommandZInter>("zinter", -3, "read-only", 1, 1, 1),

Review Comment:
   It seems the keyrange should be processed with `numkeys_`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org