You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/10 03:34:18 UTC
[GitHub] [airflow] zachliu opened a new pull request #22137: bugfix
zachliu opened a new pull request #22137:
URL: https://github.com/apache/airflow/pull/22137
:bug: fix for https://github.com/apache/airflow/pull/22002
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] zachliu commented on pull request #22137: bugfix
Posted by GitBox <gi...@apache.org>.
zachliu commented on pull request #22137:
URL: https://github.com/apache/airflow/pull/22137#issuecomment-1067060405
@potiuk now i have definitive proof that this works like 99% perfectly:
```
[2022-03-12, 07:20:05 EST] {{before.py:35}} INFO - Starting call to 'airflow.providers.amazon.aws.operators.ecs.EcsOperator._start_wait_check_task', this is the 1st time calling it.
[2022-03-12, 07:20:06 EST] {{ecs.py:371}} INFO - ECS Task started: ...
[2022-03-12, 07:20:06 EST] {{ecs.py:375}} INFO - ECS task ID is: a52de9c027c14052a9c93933a8dc0958
[2022-03-12, 07:20:06 EST] {{ecs.py:321}} INFO - Starting ECS Task Log Fetcher
[2022-03-12, 07:20:21 EST] {{base_aws.py:100}} INFO - Retrieving region_name from Connection.extra_config['region_name']
[2022-03-12, 07:23:37 EST] {{ecs.py:448}} INFO - ECS Task stopped, check status: ...
[2022-03-12, 07:23:37 EST] {{before.py:35}} INFO - Starting call to 'airflow.providers.amazon.aws.operators.ecs.EcsOperator._start_wait_check_task', this is the 1st time calling it.
[2022-03-12, 07:23:47 EST] {{before.py:35}} INFO - Starting call to 'airflow.providers.amazon.aws.operators.ecs.EcsOperator._start_wait_check_task', this is the 2nd time calling it.
[2022-03-12, 07:23:47 EST] {{ecs.py:371}} INFO - ECS Task started: ...
```
with the 1% imperfection being the duplicate log entry...
it is because in the `base_aws.py` we used the same logger for both `before` and `after`:
https://github.com/apache/airflow/blob/6fee5e0f983be3e1fdccd3e3c2879b0ace1d529c/airflow/providers/amazon/aws/hooks/base_aws.py#L592-L593
another simple PR coming right up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22137: bugfix
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22137:
URL: https://github.com/apache/airflow/pull/22137#issuecomment-1067062186
> another simple PR coming right up
**JUST** In time for the next provider's release :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #22137: bugfix
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #22137:
URL: https://github.com/apache/airflow/pull/22137#issuecomment-1064592614
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #22137: bugfix
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #22137:
URL: https://github.com/apache/airflow/pull/22137
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org