You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2016/02/25 20:17:43 UTC
Review Request 43904: Windows: Removed `rootfs` launcher flag,
preventing `chroot`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43904/
-----------------------------------------------------------
Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
Bugs: MESOS-4780
https://issues.apache.org/jira/browse/MESOS-4780
Repository: mesos
Description
-------
`chroot` is does not exist on Windows. Unfortunately, the launcher also
depends on it. In this commit, we remove Windows support for the
launcher flag `rootfs`, which controls whether we use `chroot` in the
launcher. This allows us to divest ourselves of `chroot` altogether on
Windows.
Diffs
-----
src/slave/containerizer/mesos/containerizer.cpp 129406abdff715e321f683911e404c46676b6daf
src/slave/containerizer/mesos/launch.hpp 7e29ca2b8bec1c20aef122472cff60f6003603ad
src/slave/containerizer/mesos/launch.cpp 6b3bf163e2a577e6318a4a62f96d6bfd98ef9ae9
Diff: https://reviews.apache.org/r/43904/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 43904: Windows: Removed `rootfs` launcher flag,
preventing `chroot`.
Posted by Daniel Pravat <dp...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43904/#review121103
-----------------------------------------------------------
Ship it!
Ship It!
- Daniel Pravat
On Feb. 25, 2016, 7:17 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43904/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2016, 7:17 p.m.)
>
>
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
>
>
> Bugs: MESOS-4780
> https://issues.apache.org/jira/browse/MESOS-4780
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `chroot` is does not exist on Windows. Unfortunately, the launcher also
> depends on it. In this commit, we remove Windows support for the
> launcher flag `rootfs`, which controls whether we use `chroot` in the
> launcher. This allows us to divest ourselves of `chroot` altogether on
> Windows.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 129406abdff715e321f683911e404c46676b6daf
> src/slave/containerizer/mesos/launch.hpp 7e29ca2b8bec1c20aef122472cff60f6003603ad
> src/slave/containerizer/mesos/launch.cpp 6b3bf163e2a577e6318a4a62f96d6bfd98ef9ae9
>
> Diff: https://reviews.apache.org/r/43904/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 43904: Windows: Removed `rootfs` launcher flag,
preventing `chroot`.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43904/#review121499
-----------------------------------------------------------
Ship it!
- Joris Van Remoortere
On Feb. 25, 2016, 7:17 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43904/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2016, 7:17 p.m.)
>
>
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
>
>
> Bugs: MESOS-4780
> https://issues.apache.org/jira/browse/MESOS-4780
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `chroot` is does not exist on Windows. Unfortunately, the launcher also
> depends on it. In this commit, we remove Windows support for the
> launcher flag `rootfs`, which controls whether we use `chroot` in the
> launcher. This allows us to divest ourselves of `chroot` altogether on
> Windows.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 129406abdff715e321f683911e404c46676b6daf
> src/slave/containerizer/mesos/launch.hpp 7e29ca2b8bec1c20aef122472cff60f6003603ad
> src/slave/containerizer/mesos/launch.cpp 6b3bf163e2a577e6318a4a62f96d6bfd98ef9ae9
>
> Diff: https://reviews.apache.org/r/43904/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 43904: Windows: Removed `rootfs` launcher flag,
preventing `chroot`.
Posted by Alex Naparu <al...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43904/#review120958
-----------------------------------------------------------
Ship it!
Ship It!
- Alex Naparu
On Feb. 25, 2016, 7:17 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43904/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2016, 7:17 p.m.)
>
>
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
>
>
> Bugs: MESOS-4780
> https://issues.apache.org/jira/browse/MESOS-4780
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `chroot` is does not exist on Windows. Unfortunately, the launcher also
> depends on it. In this commit, we remove Windows support for the
> launcher flag `rootfs`, which controls whether we use `chroot` in the
> launcher. This allows us to divest ourselves of `chroot` altogether on
> Windows.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 129406abdff715e321f683911e404c46676b6daf
> src/slave/containerizer/mesos/launch.hpp 7e29ca2b8bec1c20aef122472cff60f6003603ad
> src/slave/containerizer/mesos/launch.cpp 6b3bf163e2a577e6318a4a62f96d6bfd98ef9ae9
>
> Diff: https://reviews.apache.org/r/43904/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>