You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/12/19 03:56:47 UTC
[GitHub] [rocketmq] xiaoyifang opened a new issue, #5734: [code discussion] Is the existence of this code necessary
xiaoyifang opened a new issue, #5734:
URL: https://github.com/apache/rocketmq/issues/5734
https://github.com/apache/rocketmq/blob/fac311206f53a6e001f736e5b654ea8baf4eb93b/store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java#L2470-L2477
I think This section's purpose is to wait at most 50*100 millionseconds for for `ReputMessageService` to dispatch the message.
The question is that is it neccessary?
1, If commitlog *must be dispatched* completely before shutdown ,then 5 seconds may not be enough.
2, If commitlog does not need to dispatched completely before shutdown ,then there is no necessary to execute this section of code.
any of the above cases , this section code's existence is in doubt.
Wish someone can give me a hint .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [code discussion] Is the existence of this code necessary [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #5734: [code discussion] Is the existence of this code necessary
URL: https://github.com/apache/rocketmq/issues/5734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [code discussion] Is the existence of this code necessary [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #5734:
URL: https://github.com/apache/rocketmq/issues/5734#issuecomment-1867071029
This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [code discussion] Is the existence of this code necessary [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #5734:
URL: https://github.com/apache/rocketmq/issues/5734#issuecomment-1868618229
This issue was closed because it has been inactive for 3 days since being marked as stale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org