You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "mthmulders (via GitHub)" <gi...@apache.org> on 2024/10/12 15:09:30 UTC
[PR] [MNG-8301] Can't build a project without modelVersion=4.1.0 but with 4.1.0 (beta-4) XSD [maven-integration-testing]
mthmulders opened a new pull request, #386:
URL: https://github.com/apache/maven-integration-testing/pull/386
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MNG-8301] Can't build a project without modelVersion=4.1.0 but with 4.1.0 (beta-4) XSD [maven-integration-testing]
Posted by "DidierLoiseau (via GitHub)" <gi...@apache.org>.
DidierLoiseau commented on code in PR #386:
URL: https://github.com/apache/maven-integration-testing/pull/386#discussion_r1798191158
##########
core-it-suite/src/test/resources/mng-8301-project-without-modelversion/module-a/pom.xml:
##########
@@ -0,0 +1,10 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.1.0 https://maven.apache.org/xsd/maven-4.1.0-beta-4.xsd">
Review Comment:
`xmlns` does not match `schemaLocation`
```suggestion
<project xmlns="http://maven.apache.org/POM/4.1.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.1.0 https://maven.apache.org/xsd/maven-4.1.0-beta-4.xsd">
```
##########
core-it-suite/src/test/resources/mng-8301-project-without-modelversion/module-b/pom.xml:
##########
@@ -0,0 +1,17 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.1.0 https://maven.apache.org/xsd/maven-4.1.0-beta-4.xsd">
+
+ <parent>
+ <groupId>org.apache.maven.its.mng8301</groupId>
+ <artifactId>m4womv</artifactId>
+ </parent>
+
+ <artifactId>module-b</artifactId>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.maven.repro</groupId>
Review Comment:
It’s the wrong `groupId`
```suggestion
<groupId>org.apache.maven.its.mng8301</groupId>
```
##########
core-it-suite/src/test/resources/mng-8301-project-without-modelversion/module-b/pom.xml:
##########
@@ -0,0 +1,17 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.1.0 https://maven.apache.org/xsd/maven-4.1.0-beta-4.xsd">
Review Comment:
```suggestion
<project xmlns="http://maven.apache.org/POM/4.1.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.1.0 https://maven.apache.org/xsd/maven-4.1.0-beta-4.xsd">
```
##########
core-it-suite/src/test/resources/mng-8301-project-without-modelversion/pom.xml:
##########
@@ -0,0 +1,46 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.1.0 https://maven.apache.org/xsd/maven-4.1.0-beta-4.xsd">
Review Comment:
```suggestion
<project xmlns="http://maven.apache.org/POM/4.1.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.1.0 https://maven.apache.org/xsd/maven-4.1.0-beta-4.xsd">
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MNG-8301] Can't build a project without modelVersion=4.1.0 but with 4.1.0 (beta-4) XSD [maven-integration-testing]
Posted by "mthmulders (via GitHub)" <gi...@apache.org>.
mthmulders commented on PR #386:
URL: https://github.com/apache/maven-integration-testing/pull/386#issuecomment-2408622765
Note that the above pipeline succeeds, because it runs with Maven 3.9.7. When run with 4.0.0-beta-5-SNAPSHOT, it fails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MNG-8301] Can't build a project without modelVersion=4.1.0 but with 4.1.0 (beta-4) XSD [maven-integration-testing]
Posted by "mthmulders (via GitHub)" <gi...@apache.org>.
mthmulders closed pull request #386: [MNG-8301] Can't build a project without modelVersion=4.1.0 but with 4.1.0 (beta-4) XSD
URL: https://github.com/apache/maven-integration-testing/pull/386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org