You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2023/01/06 00:16:19 UTC
[GitHub] [trafficcontrol] ocket8888 opened a new pull request, #7268: Fix edge cases for DSR creation, update, and deletion
ocket8888 opened a new pull request, #7268:
URL: https://github.com/apache/trafficcontrol/pull/7268
There are currently two problems with DSRs in the legacy APIv3 that this PR fixes.
- Creating or deleting a DSR using APIv3 will work as intended, but returns an incorrect response body. It will erroneously use an APIv4 structure in the response.
- Creating or updating a DSR in APIv3 without the required `deliveryservice` property triggers a `500 Internal Server Error`, response. It should instead complain that the required field was not present.
<hr/>
## Which Traffic Control components are affected by this PR?
- Traffic Ops
## What is the best way to verify this PR?
Make sure the provided tests pass. You can test manually by just doing the things outlined above that caused the issue.
## If this is a bugfix, which Traffic Control versions contained the bug?
- master
## PR submission checklist
- [x] This PR has tests
- [x] This PR doesn't need documentation
- [x] This PR doesn't need a CHANGELOG.md entry
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7268: Fix edge cases for DSR creation, update, and deletion
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #7268:
URL: https://github.com/apache/trafficcontrol/pull/7268#issuecomment-1372965877
# [Codecov](https://codecov.io/gh/apache/trafficcontrol/pull/7268?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7268](https://codecov.io/gh/apache/trafficcontrol/pull/7268?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f37b6e4) into [master](https://codecov.io/gh/apache/trafficcontrol/commit/c4444af63e97be99d1f25dfb292ccffddf2f5004?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c4444af) will **increase** coverage by `0.06%`.
> The diff coverage is `88.28%`.
```diff
@@ Coverage Diff @@
## master #7268 +/- ##
============================================
+ Coverage 28.23% 28.29% +0.06%
Complexity 98 98
============================================
Files 617 616 -1
Lines 69576 69649 +73
Branches 90 90
============================================
+ Hits 19642 19708 +66
- Misses 48120 48126 +6
- Partials 1814 1815 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| golib_unit | `53.16% <91.02%> (+0.27%)` | :arrow_up: |
| grove_unit | `4.60% <ø> (ø)` | |
| t3c_generate_unit | `24.96% <ø> (ø)` | |
| traffic_monitor_unit | `20.43% <ø> (ø)` | |
| traffic_ops_unit | `19.67% <0.00%> (-0.01%)` | :arrow_down: |
| traffic_stats_unit | `10.41% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/trafficcontrol/pull/7268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...fic\_ops\_golang/deliveryservice/request/requests.go](https://codecov.io/gh/apache/trafficcontrol/pull/7268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19vcHMvdHJhZmZpY19vcHNfZ29sYW5nL2RlbGl2ZXJ5c2VydmljZS9yZXF1ZXN0L3JlcXVlc3RzLmdv) | `0.00% <0.00%> (ø)` | |
| [...fic\_ops\_golang/deliveryservice/request/validate.go](https://codecov.io/gh/apache/trafficcontrol/pull/7268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19vcHMvdHJhZmZpY19vcHNfZ29sYW5nL2RlbGl2ZXJ5c2VydmljZS9yZXF1ZXN0L3ZhbGlkYXRlLmdv) | `0.00% <0.00%> (ø)` | |
| [lib/go-tc/deliveryservice\_requests.go](https://codecov.io/gh/apache/trafficcontrol/pull/7268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL2dvLXRjL2RlbGl2ZXJ5c2VydmljZV9yZXF1ZXN0cy5nbw==) | `42.64% <68.29%> (+1.77%)` | :arrow_up: |
| [lib/go-tc/users.go](https://codecov.io/gh/apache/trafficcontrol/pull/7268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL2dvLXRjL3VzZXJzLmdv) | `42.32% <77.27%> (ø)` | |
| [lib/go-tc/deliveryservices.go](https://codecov.io/gh/apache/trafficcontrol/pull/7268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL2dvLXRjL2RlbGl2ZXJ5c2VydmljZXMuZ28=) | `89.02% <99.46%> (+2.08%)` | :arrow_up: |
| [lib/go-util/ptr.go](https://codecov.io/gh/apache/trafficcontrol/pull/7268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL2dvLXV0aWwvcHRyLmdv) | `100.00% <100.00%> (+9.09%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] srijeet0406 merged pull request #7268: Fix edge cases for DSR creation, update, and deletion
Posted by GitBox <gi...@apache.org>.
srijeet0406 merged PR #7268:
URL: https://github.com/apache/trafficcontrol/pull/7268
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on pull request #7268: Fix edge cases for DSR creation, update, and deletion
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on PR #7268:
URL: https://github.com/apache/trafficcontrol/pull/7268#issuecomment-1373860110
Originally I had added a TO Go client integration test case to make sure the response contained a `deliveryService` property, but our client drops the response so checking that is impossible without either a breaking change to the client, or adding functionality to a client of deprecated API. Neither of which I'm willing to do.
I really wish I had realized that earlier, because the only reason I modified code in `lib/` was to enable that test, which is now unnecessary. But I'm leaving it in as it's a change that was requested in one of my PRs last year.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org