New home for EncryptInterceptor.BaseEncryptionManager and friends

[Christopher Schultz <ch...@christopherschultz.net>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

All,

I'd like to refactor a bit and move BaseEncryptionManager and
associated code out of the EncryptInterceptor class. Where would be a
good place to put it?

Some potential candidates:

org/apache/catalina/util
org/apache/catalina/security
org/apache/tomcat/util
org/apache/tomcat/util/security

Or perhaps a new package.

I'm a little unclear when to decide between org.apache.catalina and
org.apache.tomcat in general.

I think it will only be the following classes that are moved, so maybe
a new package isn't appropriate:

BaseEncryptionManager
GCMEncryptionManager

I may decide to create an interface for EncryptionManager, but I don't
see it as strictly necessary at this point.

- -chris
-----BEGIN PGP SIGNATURE-----
Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/

iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAl7sxXcACgkQHPApP6U8
pFiimxAAjO02A+5RN+Ywqj4/+zeksVjAb7Riv3zRunnWk90N51lwdqC4klpLYcrg
92wt+gAsN/jLmGX+tBgc2dACYaWHDEX3QBf6JLIzrlXrisPGnVPimsm1bPKUtViB
EPDk2aIfwpxknNde+PBs5xR2Og9e9BS9Aib6DrgFunOGA6WIpHccdOLz/OmCBXDp
d6y3rZkyRluekMn7+jCoMyC0bpsAdvTZTH4y1+mgKhXsoP3QpkcoZxpbEldUBPQN
JhsJG7ELC6htm5otM38/3/gevSV/1jJe85u5l9CD0Bbvna0ivJaMm4eLqfLY9YFh
bX/XTWKSxheQ3iLI/5+W3n+Ef7y9f5KpbCu4cq+PJFifDjzV8Sormr0DyEp0wpca
chKb+YaiUWHlRKvAqm4blohNLrGZ7Zi1hi0yaA0sUXwyC9sDqxu/0sKXuF1UYHxx
45eexi+kQMMpyxfSjEsFqC2VOPr3psorpxd0ijstYDVCb47hutgFowwvzkZvRU1A
utaqj2R8dswLQ8jp5Ebc671iRH+ABPEpQWZYwV6jHK+G3lNRTGtj5eOMek9gMrW+
h676ghEnO1Y3eXx+wsSDTNiF788/2Vfney5gu+VbRBOThq3UZjTbYOeqxGGDnp/G
YbXXUGz4+/7FnyN94YRNq2jyNqLhJMPNB27WT3wc46+/CB3iXqA=
=JvsT
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

Re: New home for EncryptInterceptor.BaseEncryptionManager and friends

[Mark Thomas <ma...@apache.org>]

On 19/06/2020 15:02, Christopher Schultz wrote:
> All,
> 
> I'd like to refactor a bit and move BaseEncryptionManager and
> associated code out of the EncryptInterceptor class. Where would be a
> good place to put it?
> 
> Some potential candidates:
> 
> org/apache/catalina/util
> org/apache/catalina/security
> org/apache/tomcat/util
> org/apache/tomcat/util/security
> 
> Or perhaps a new package.
> 
> I'm a little unclear when to decide between org.apache.catalina and
> org.apache.tomcat in general.

Packages under org.apache.catalina are only visible to other packages
under org.apache.catalina.

Packages under org.apache.tomcat.util are visible to most/all Tomcat
packages.

So, it depends which code is going to be using it or if you think other
components might need it over time.

It is actually a little tricker than that. I usually recommend looking
at the POM files to see what the dependencies are meant to be.

> I think it will only be the following classes that are moved, so maybe
> a new package isn't appropriate:
> 
> BaseEncryptionManager
> GCMEncryptionManager
> 
> I may decide to create an interface for EncryptionManager, but I don't
> see it as strictly necessary at this point.

Tribes is a special case. It currently only depends on JULI. It has
copies of several utility classes to keep that dependency to a minimum.

Those two classes are so small, I'd be tempted to go with the copying
option.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org