[GitHub] [spark] cloud-fan commented on a change in pull request #35643: [SPARK-38312][CORE] Use error class in GraphiteSink

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #35643:
URL: https://github.com/apache/spark/pull/35643#discussion_r813674375



##########
File path: core/src/test/scala/org/apache/spark/metrics/sink/GraphiteSinkSuite.scala
##########
@@ -79,4 +79,42 @@ class GraphiteSinkSuite extends SparkFunSuite {
     assert(metricKeys.equals(filteredMetricKeys),
       "Should contain only metrics matches regex filter")
   }
+
+  test("GraphiteSink without host") {

Review comment:
       shall we have one big test suite for spark core errors? like `SparkCoreErrorSuite`? We have several of them in sql, such as `QueryCompilationErrorsSuite`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org