You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2009/05/18 20:16:45 UTC
[jira] Created: (ZOOKEEPER-410) address all findbugs warnings in
client/server classes
address all findbugs warnings in client/server classes
------------------------------------------------------
Key: ZOOKEEPER-410
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-410
Project: Zookeeper
Issue Type: Sub-task
Reporter: Patrick Hunt
Assignee: Patrick Hunt
Fix For: 3.2.0
trunk/src/java/main/org/apache/zookeeper/ClientCnxn.java
trunk/src/java/main/org/apache/zookeeper/ZooKeeperMain.java
trunk/src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java
trunk/src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java
trunk/src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java
trunk/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java
trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-410) address all findbugs warnings in
client/server classes
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711890#action_12711890 ]
Hudson commented on ZOOKEEPER-410:
----------------------------------
Integrated in ZooKeeper-trunk #321 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/321/])
> address all findbugs warnings in client/server classes
> ------------------------------------------------------
>
> Key: ZOOKEEPER-410
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-410
> Project: Zookeeper
> Issue Type: Sub-task
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-410.patch
>
>
> trunk/src/java/main/org/apache/zookeeper/ClientCnxn.java
> trunk/src/java/main/org/apache/zookeeper/ZooKeeperMain.java
> trunk/src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java
> trunk/src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java
> trunk/src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java
> trunk/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java
> trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-410) address all findbugs warnings in
client/server classes
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-410:
------------------------------------
Status: Open (was: Patch Available)
excellent job pat. my only problem with the patch is that in FinalRequestProcessor you have changed the behavior for the case where the expected xid is greater than the actual one seen. if the incoming xid is lower than expected you lose the outstanding change, which may be the next one in the pipe, which will result in another warning and skip, and so on.
> address all findbugs warnings in client/server classes
> ------------------------------------------------------
>
> Key: ZOOKEEPER-410
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-410
> Project: Zookeeper
> Issue Type: Sub-task
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-410.patch
>
>
> trunk/src/java/main/org/apache/zookeeper/ClientCnxn.java
> trunk/src/java/main/org/apache/zookeeper/ZooKeeperMain.java
> trunk/src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java
> trunk/src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java
> trunk/src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java
> trunk/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java
> trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (ZOOKEEPER-410) address all findbugs warnings in
client/server classes
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed resolved ZOOKEEPER-410.
-------------------------------------
Resolution: Fixed
Committed revision 776806.
> address all findbugs warnings in client/server classes
> ------------------------------------------------------
>
> Key: ZOOKEEPER-410
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-410
> Project: Zookeeper
> Issue Type: Sub-task
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-410.patch
>
>
> trunk/src/java/main/org/apache/zookeeper/ClientCnxn.java
> trunk/src/java/main/org/apache/zookeeper/ZooKeeperMain.java
> trunk/src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java
> trunk/src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java
> trunk/src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java
> trunk/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java
> trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-410) address all findbugs warnings in
client/server classes
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-410:
-----------------------------------
Status: Patch Available (was: Open)
> address all findbugs warnings in client/server classes
> ------------------------------------------------------
>
> Key: ZOOKEEPER-410
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-410
> Project: Zookeeper
> Issue Type: Sub-task
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-410.patch
>
>
> trunk/src/java/main/org/apache/zookeeper/ClientCnxn.java
> trunk/src/java/main/org/apache/zookeeper/ZooKeeperMain.java
> trunk/src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java
> trunk/src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java
> trunk/src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java
> trunk/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java
> trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-410) address all findbugs warnings in
client/server classes
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711260#action_12711260 ]
Patrick Hunt commented on ZOOKEEPER-410:
----------------------------------------
Ben, I don't think that's the case re finalreqprocessor - I was pretty careful with that change, and I'm reviewing
it now and I don't think anything changed. I moved the remove up a bit, but otw the behavior is unchanged.
Can you take another look?
> address all findbugs warnings in client/server classes
> ------------------------------------------------------
>
> Key: ZOOKEEPER-410
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-410
> Project: Zookeeper
> Issue Type: Sub-task
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-410.patch
>
>
> trunk/src/java/main/org/apache/zookeeper/ClientCnxn.java
> trunk/src/java/main/org/apache/zookeeper/ZooKeeperMain.java
> trunk/src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java
> trunk/src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java
> trunk/src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java
> trunk/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java
> trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-410) address all findbugs warnings in
client/server classes
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-410:
------------------------------------
Hadoop Flags: [Reviewed]
+1 you're right. you didn't change the behavior. (i think there used to be a return in the if case, but that is a separate issue)
> address all findbugs warnings in client/server classes
> ------------------------------------------------------
>
> Key: ZOOKEEPER-410
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-410
> Project: Zookeeper
> Issue Type: Sub-task
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-410.patch
>
>
> trunk/src/java/main/org/apache/zookeeper/ClientCnxn.java
> trunk/src/java/main/org/apache/zookeeper/ZooKeeperMain.java
> trunk/src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java
> trunk/src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java
> trunk/src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java
> trunk/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java
> trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-410) address all findbugs warnings in
client/server classes
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-410:
-----------------------------------
Attachment: ZOOKEEPER-410.patch
I added a few exclusions, with comment. In particular I think we should allow
*Main classes (ie command line tools) to call system exit as necessary (from code
in *Main)
Please review the movement of start() calls in particular.
Also carefully review the locking changes in nioservercnxn (which doesn't seem to silence
findbugs, but it seems like it should)
> address all findbugs warnings in client/server classes
> ------------------------------------------------------
>
> Key: ZOOKEEPER-410
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-410
> Project: Zookeeper
> Issue Type: Sub-task
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-410.patch
>
>
> trunk/src/java/main/org/apache/zookeeper/ClientCnxn.java
> trunk/src/java/main/org/apache/zookeeper/ZooKeeperMain.java
> trunk/src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java
> trunk/src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java
> trunk/src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java
> trunk/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java
> trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.