[GitHub] [arrow-rs] alamb commented on a diff in pull request #4402: Further BooleanBuffer Constructors

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #4402:
URL: https://github.com/apache/arrow-rs/pull/4402#discussion_r1226646645


##########
arrow-arith/src/boolean.rs:
##########
@@ -314,7 +312,7 @@ pub fn not(left: &BooleanArray) -> Result<BooleanArray, ArrowError> {
 /// ```
 pub fn is_null(input: &dyn Array) -> Result<BooleanArray, ArrowError> {
     let values = match input.nulls() {
-        None => NullBuffer::new_null(input.len()).into_inner(),
+        None => BooleanBuffer::new_unset(input.len()),

Review Comment:
   This is very clever



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org