You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Oleksiy Sayankin <ol...@gmail.com> on 2018/02/16 14:13:12 UTC

Review Request 65686: HIVE-18728 Secure webHCat with SSL

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65686/
-----------------------------------------------------------

Review request for hive, Lefty Leverenz, Lefty Leverenz, Rui Li, Lenni Kuff, Szehon Ho, and Szehon Ho.


Repository: hive-git


Description
-------

Initiall commit


Diffs
-----

  hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/AppConfig.java 1fd9e47 
  hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/Main.java d183b2e 


Diff: https://reviews.apache.org/r/65686/diff/1/


Testing
-------


Thanks,

Oleksiy Sayankin


Re: Review Request 65686: HIVE-18728 Secure webHCat with SSL

Posted by Oleksiy Sayankin <ol...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65686/
-----------------------------------------------------------

(Updated March 21, 2018, 12:57 p.m.)


Review request for hive, Lefty Leverenz, Lefty Leverenz, Rui Li, Lenni Kuff, Szehon Ho, and Szehon Ho.


Changes
-------

Fixed code style issues


Repository: hive-git


Description
-------

Initiall commit


Diffs (updated)
-----

  hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/AppConfig.java 1fd9e47dde 
  hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/Main.java d183b2e61b 


Diff: https://reviews.apache.org/r/65686/diff/3/

Changes: https://reviews.apache.org/r/65686/diff/2-3/


Testing
-------


Thanks,

Oleksiy Sayankin


Re: Review Request 65686: HIVE-18728 Secure webHCat with SSL

Posted by Lefty Leverenz <le...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65686/#review197767
-----------------------------------------------------------




hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/AppConfig.java
Lines 113-117 (patched)
<https://reviews.apache.org/r/65686/#comment278047>

    These configs look fine to me.  After the patch is committed they will need to be documented in  https://cwiki.apache.org/confluence/display/Hive/WebHCat+Configure#WebHCatConfigure-ConfigurationVariables. 
    HIVE-18728's description has the documentation.


- Lefty Leverenz


On Feb. 16, 2018, 2:19 p.m., Oleksiy Sayankin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65686/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2018, 2:19 p.m.)
> 
> 
> Review request for hive, Lefty Leverenz, Lefty Leverenz, Rui Li, Lenni Kuff, Szehon Ho, and Szehon Ho.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Initiall commit
> 
> 
> Diffs
> -----
> 
>   hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/AppConfig.java 1fd9e47 
>   hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/Main.java d183b2e 
> 
> 
> Diff: https://reviews.apache.org/r/65686/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Oleksiy Sayankin
> 
>


Re: Review Request 65686: HIVE-18728 Secure webHCat with SSL

Posted by Oleksiy Sayankin <ol...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65686/
-----------------------------------------------------------

(Updated Feb. 16, 2018, 4:19 p.m.)


Review request for hive, Lefty Leverenz, Lefty Leverenz, Rui Li, Lenni Kuff, Szehon Ho, and Szehon Ho.


Changes
-------

Fixed build error


Repository: hive-git


Description
-------

Initiall commit


Diffs (updated)
-----

  hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/AppConfig.java 1fd9e47 
  hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/Main.java d183b2e 


Diff: https://reviews.apache.org/r/65686/diff/2/

Changes: https://reviews.apache.org/r/65686/diff/1-2/


Testing
-------


Thanks,

Oleksiy Sayankin