You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "adith-os (via GitHub)" <gi...@apache.org> on 2026/05/09 16:03:36 UTC

[PR] [SPARK-55294][PYTHON] Add support for PyArrow-backed dtypes in pandas API [spark]

adith-os opened a new pull request, #55783:
URL: https://github.com/apache/spark/pull/55783

   
   
   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
     8. If you want to add or modify an error type or message, please read the guideline first in
        'common/utils/src/main/resources/error/README.md'.
   -->
   
   ### What changes were proposed in this pull request?
   
   
   This PR adds support for PyArrow-backed dtypes (e.g., bool[pyarrow]) in PySpark's pandas API. The changes include:
   - Type detection and conversion: Added is_pyarrow_backed_dtype() function to detect PyArrow-backed dtypes and enhanced as_spark_type() to convert them to appropriate Spark types.
   - Dtype preservation: Enhanced spark_type_to_pandas_dtype() with a use_arrow_dtypes parameter to preserve PyArrow dtypes when converting from Spark types back to pandas dtypes.
   - Propagation through operations: Updated comparison operators in data_type_ops/base.py to preserve PyArrow dtypes in results, and propagated the use_arrow_dtypes parameter through InternalField.from_struct_field() and related code paths.
   
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   
   
   ### Why are the changes needed?
   
   Starting with pandas 3.0, when PyArrow is installed, pandas automatically uses PyArrow-backed dtypes for string columns. Without this PR, PySpark's pandas API loses dtype information when working with PyArrow-backed dtypes
   
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes. Users working with PyArrow-backed dtypes will now see their dtypes preserved through PySpark operations
   Before the PR:
   ```
   >>> 26/05/09 19:25:26 WARN GarbageCollectionMetrics: To enable non-built-in garbage collector(s) List(scavenge), users should configure it(them) to spark.eventLog.gcMetrics.youngGenerationGarbageCollectors or spark.eventLog.gcMetrics.oldGenerationGarbageCollectors
   26/05/09 19:25:26 WARN GarbageCollectionMetrics: To enable non-built-in garbage collector(s) List(global, scavenge), users should configure it(them) to spark.eventLog.gcMetrics.youngGenerationGarbageCollectors or spark.eventLog.gcMetrics.oldGenerationGarbageCollectors
   import warnings
   >>> warnings.filterwarnings('ignore')
   >>> 
   >>> import pandas as pd
   >>> print(f"pandas: {pd.__version__}")
   pandas: 3.0.2
   >>> 
   >>> import pyspark.pandas as ps
   >>> s1 = ps.Series(['a', 'b', 'c'], dtype='string')
   >>> s2 = ps.Series(['a', 'x', 'c'], dtype='string')
   >>> result = s1 == s2
   >>> print(f"result dtype: {result.dtype}")
   result dtype: boolean
   >>> print(result)
   0     True                                                                      
   1    False
   2     True
   dtype: boolean
   >>> 
   ```
   After the PR:
   ```
   >>> 26/05/09 19:19:05 WARN GarbageCollectionMetrics: To enable non-built-in garbage collector(s) List(scavenge), users should configure it(them) to spark.eventLog.gcMetrics.youngGenerationGarbageCollectors or spark.eventLog.gcMetrics.oldGenerationGarbageCollectors
   26/05/09 19:19:05 WARN GarbageCollectionMetrics: To enable non-built-in garbage collector(s) List(global, scavenge), users should configure it(them) to spark.eventLog.gcMetrics.youngGenerationGarbageCollectors or spark.eventLog.gcMetrics.oldGenerationGarbageCollectors
   
   >>> import warnings
   >>> warnings.filterwarnings('ignore')
   >>> 
   >>> import pandas as pd
   >>> print(f"pandas: {pd.__version__}")
   pandas: 3.0.2
   >>> 
   >>> import pyspark.pandas as ps
   >>> s1 = ps.Series(['a', 'b', 'c'], dtype='string')
   s2 = ps.Series(['a', 'x', 'c'], dtype='string')
   result = s1 == s2
   print(f"result dtype: {result.dtype}")
   print(result)
   
   >>> s2 = ps.Series(['a', 'x', 'c'], dtype='string')
   >>> result = s1 == s2
   >>> print(f"result dtype: {result.dtype}")
   result dtype: bool[pyarrow]
   >>> print(result)
   0     True
   1    False
   2     True
   dtype: bool[pyarrow]
   >>> 
   ```
   <!--
   Note that it means *any* user-facing change including all aspects such as new features, bug fixes, or other behavior changes. Documentation-only updates are not considered user-facing changes.
   
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   
   
   ### How was this patch tested?
   
   New tests in python/pyspark/pandas/tests/test_typedef.py:
   - test_as_spark_type_pyarrow_dtypes() - Tests conversion to Spark types
   - test_spark_type_to_pandas_dtype_with_arrow_flag() - Tests conversion back to pandas dtypes
   - test_is_str_dtype_with_pyarrow() - Tests string dtype detection
   - test_is_pyarrow_backed_dtype() - Tests PyArrow dtype detection
   
   Integration test in python/pyspark/pandas/tests/data_type_ops/test_string_ops.py:
   - test_pyarrow_backed_string_comparisons() - Tests dtype preservation in comparison operations
   
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
   -->
   
   
   ### Was this patch authored or co-authored using generative AI tooling?
   <!--
   If generative AI tooling has been used in the process of authoring this patch, please include the
   phrase: 'Generated-by: ' followed by the name of the tool and its version.
   If no, write 'No'.
   Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
   -->
   Yes. Generated-by: GPT 5.5


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-55294][PYTHON] Add support for PyArrow-backed dtypes in pandas API [spark]

Posted by "adith-os (via GitHub)" <gi...@apache.org>.
adith-os closed pull request #55783: [SPARK-55294][PYTHON] Add support for PyArrow-backed dtypes in pandas API
URL: https://github.com/apache/spark/pull/55783


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-55294][PYTHON] Add support for PyArrow-backed dtypes in pandas API [spark]

Posted by "gaogaotiantian (via GitHub)" <gi...@apache.org>.
gaogaotiantian commented on PR #55783:
URL: https://github.com/apache/spark/pull/55783#issuecomment-4433986488

   Honestly, I'm a bit conservative when a new contributor making complex changes with LLM to support pandas 3. Our CI does not check pandas 3 (the nightly CI simply fails and can not be used against a certain PR). I've had a few cases where people just feed my description to LLM and generate some patch that of course passes the CI because we do not test pandas 3, while the code may not even work properly.
   
   At this point, it's very difficult and time consuming to validate the patch and the approach. We have very limited resources on many different matters. I would say that we deprioritize supporting pandas 3, especially from new contributors with LLM, so that we can keep everything else going. In the future, when we have enough resources to deal with it, we can put more effort into it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-55294][PYTHON] Add support for PyArrow-backed dtypes in pandas API [spark]

Posted by "adith-os (via GitHub)" <gi...@apache.org>.
adith-os commented on PR #55783:
URL: https://github.com/apache/spark/pull/55783#issuecomment-4453825584

   I completely understand your concern, and appreciate the context. My goal is to contribute meaningfully to the project and since this is relatively complex change, I’m closing this PR. 
   I’d still really like to contribute to the project, so if there are any issues that currently need help and are suitable for new contributors, I’d definitely be happy to pick them up.
   Thank you once again for the review and for clearly explaining why this PR may not be suitable at this time🙂 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-55294][PYTHON] Add support for PyArrow-backed dtypes in pandas API [spark]

Posted by "devin-petersohn (via GitHub)" <gi...@apache.org>.
devin-petersohn commented on code in PR #55783:
URL: https://github.com/apache/spark/pull/55783#discussion_r3226918846


##########
python/pyspark/pandas/typedef/typehints.py:
##########
@@ -329,14 +374,31 @@ def spark_type_to_pandas_dtype(
 def is_str_dtype(tpe: Dtype) -> bool:
     if LooseVersion(pd.__version__) < "3.0.0":
         return False
+    if extension_arrow_dtypes_available and isinstance(tpe, ArrowDtype):
+        pyarrow_type = tpe.pyarrow_dtype
+        if pa.types.is_string(pyarrow_type) or pa.types.is_large_string(pyarrow_type):
+            return True
     if extension_object_dtypes_available:
         return isinstance(tpe, StringDtype) and tpe.na_value is np.nan
     return False
 
 
+def is_pyarrow_backed_dtype(tpe: Dtype) -> bool:
+    if extension_arrow_dtypes_available and isinstance(tpe, ArrowDtype):
+        return True
+
+    if extension_object_dtypes_available and isinstance(tpe, StringDtype):
+        storage = getattr(tpe, "storage", None)
+        return isinstance(storage, str) and storage.startswith("pyarrow") and tpe.na_value is pd.NA

Review Comment:
   `StringDtype.storage` is part of the API. This feels overly defensive.



##########
python/pyspark/pandas/typedef/typehints.py:
##########
@@ -246,6 +254,24 @@ def as_spark_type(
                 return types.FloatType()
             elif isinstance(tpe, Float64Dtype) or (isinstance(tpe, str) and tpe == "Float64"):
                 return types.DoubleType()
+        if extension_arrow_dtypes_available and isinstance(tpe, ArrowDtype):
+            pyarrow_type = tpe.pyarrow_dtype
+            if pa.types.is_string(pyarrow_type) or pa.types.is_large_string(pyarrow_type):

Review Comment:
   Can we just reuse existing functionality?
   
   https://github.com/apache/spark/blob/1360e5c7fa38df1dac55476aba983aa6012b62c4/python/pyspark/sql/pandas/types.py#L347-L350



##########
python/pyspark/pandas/data_type_ops/base.py:
##########
@@ -531,7 +544,22 @@ def ne(self, left: IndexOpsLike, right: Any) -> SeriesOrIndex:
         _sanitize_list_like(right)
 
         if _should_return_all_false(left, right):
-            left_scol = left._with_new_scol(F.lit(True))
+            use_extension_dtypes = handle_dtype_as_extension_dtype(left.dtype) or (
+                isinstance(right, IndexOpsMixin) and handle_dtype_as_extension_dtype(right.dtype)
+            )
+            use_arrow_dtypes = is_pyarrow_backed_dtype(left.dtype) or (
+                isinstance(right, IndexOpsMixin) and is_pyarrow_backed_dtype(right.dtype)
+            )
+            field = left._internal.data_fields[0].copy(
+                dtype=spark_type_to_pandas_dtype(
+                    BooleanType(),
+                    use_extension_dtypes=use_extension_dtypes,
+                    use_arrow_dtypes=use_arrow_dtypes,
+                ),
+                spark_type=BooleanType(),
+                nullable=False,
+            )
+            left_scol = left._with_new_scol(F.lit(True), field=field)

Review Comment:
   This looks identical to the code block above. Should be a helper if it's this many lines IMO



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-55294][PYTHON] Add support for PyArrow-backed dtypes in pandas API [spark]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #55783:
URL: https://github.com/apache/spark/pull/55783#issuecomment-4416447292

   cc @devin-petersohn too


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-55294][PYTHON] Add support for PyArrow-backed dtypes in pandas API [spark]

Posted by "gaogaotiantian (via GitHub)" <gi...@apache.org>.
gaogaotiantian commented on PR #55783:
URL: https://github.com/apache/spark/pull/55783#issuecomment-4453875525

   @adith-os , thanks for understanding. My suggestion is to work on something simple and easy to validate first. Make sure you (not just your LLM) fully understand the problem and the solution. If someone brought a discussion about your PR, you can explain the tradeoffs and the decisions you made for that change.
   
   Open source world is like this - everyone probabably needs to build some reputation first, to prove that they are trustworthy and capable, before making really big changes to the project. I remember that you submitted a PR for type hints, to reduce some unnecessary type ignores - that would be a good example. (And if I did remember correctly, that proves my point about reputation :) )


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-55294][PYTHON] Add support for PyArrow-backed dtypes in pandas API [spark]

Posted by "adith-os (via GitHub)" <gi...@apache.org>.
adith-os commented on PR #55783:
URL: https://github.com/apache/spark/pull/55783#issuecomment-4413391887

   Hi @gaogaotiantian, Could you please review the PR when you get a chance and let me know whether this approach matches your expectations, or if you had a different direction in mind? Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org