You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by mcgilman <gi...@git.apache.org> on 2016/07/25 20:51:24 UTC

[GitHub] nifi pull request #720: Introduce data resource for authorizing Provenance a...

GitHub user mcgilman opened a pull request:

    https://github.com/apache/nifi/pull/720

    Introduce data resource for authorizing Provenance and Queue interactions

    NIFI-2346:
    - Introducing data resource for authorizing provenance events and queue listing.
    - Authorizing entire proxy chain for data resource and data transfer resource.
    
    NIFI-2338:
    - Ensuring that replay authorization only happens once.
    
    - Allowing users with access to policies for a component to be able to access all policies for that component.
    -- Includes the component, data, data transfers, and policies.
    - Fixing drop request completion to update the correct queued field.
    - Fixing access control check for listing and emptying queues.
    - Reseting selected policy when re-opening the policy management page.
    - Fixing button/link visibility for available actions in policy management page.
    - Fixing policy issues with policy removal when the underlying component is deleted.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mcgilman/nifi NIFI-2346

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/720.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #720
    
----
commit fe7213f7264cd5a97dc78ca1cbbb947f0ed3506f
Author: Matt Gilman <ma...@gmail.com>
Date:   2016-07-25T20:47:22Z

    NIFI-2346:
    - Introducing data resource for authorizing provenance events and queue listing.
    - Authorizing entire proxy chain for data resource and data transfer resource.
    NIFI-2338:
    - Ensuring that replay authorization only happens once.
    
    - Allowing users with access to policies for a component to be able to access all policies for that component.
    -- Includes the component, data, data transfers, and policies.
    - Fixing drop request completion to update the correct queued field.
    - Fixing access control check for listing and emptying queues.
    - Reseting selected policy when re-opening the policy management page.
    - Fixing button/link visibility for available actions in policy management page.
    - Fixing policy issues with policy removal when the underlying component is deleted.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #720: Introduce data resource for authorizing Provenance and Queu...

Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:

    https://github.com/apache/nifi/pull/720
  
    @markap14 Good catch. We also need to do this for site to site data transfers. Will update the seeding.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #720: Introduce data resource for authorizing Provenance and Queu...

Posted by markap14 <gi...@git.apache.org>.
Github user markap14 commented on the issue:

    https://github.com/apache/nifi/pull/720
  
    Things look good on here, but I noticed that the seeding of the authorizations.xml file does not include the DN's of the hosts in my authorizers.xml file, but it did include my 'admin dn' from the authorizers.xml file (for the 'view data' and 'modify data' policies of the root group).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #720: Introduce data resource for authorizing Provenance and Queu...

Posted by markap14 <gi...@git.apache.org>.
Github user markap14 commented on the issue:

    https://github.com/apache/nifi/pull/720
  
    Code looks good now. Unit tests are good. Tested functionality and all appears to work as expected. +1 merged to master. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #720: Introduce data resource for authorizing Provenance a...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/nifi/pull/720


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #720: Introduce data resource for authorizing Provenance and Queu...

Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:

    https://github.com/apache/nifi/pull/720
  
    @markap14 PR has been updated to address the comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---