You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2016/11/10 15:04:29 UTC

[kudu-CR] [java] Fix bug in RegexpKuduOperationsProducer 

Will Berkeley has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5032

Change subject: [java] Fix bug in RegexpKuduOperationsProducer
......................................................................

[java] Fix bug in RegexpKuduOperationsProducer

I've been experimenting with using FindBugs. It's not ready, but it
found a bug in an error path of the regexp OperationsProducer that
I want to fix quickly.

Change-Id: I1807790fad39ed0d3b22e0e94e06858dd8abceda
---
M java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducer.java
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/5032/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5032
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1807790fad39ed0d3b22e0e94e06858dd8abceda
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>

[kudu-CR] [java] Fix bug in RegexpKuduOperationsProducer

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.

Change subject: [java] Fix bug in RegexpKuduOperationsProducer
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5032
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1807790fad39ed0d3b22e0e94e06858dd8abceda
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No

[kudu-CR] [java] Fix bug in RegexpKuduOperationsProducer

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has submitted this change and it was merged.

Change subject: [java] Fix bug in RegexpKuduOperationsProducer
......................................................................


[java] Fix bug in RegexpKuduOperationsProducer

I've been experimenting with using FindBugs. It's not ready, but it
found a bug in an error path of the regexp OperationsProducer that
I want to fix quickly.

Change-Id: I1807790fad39ed0d3b22e0e94e06858dd8abceda
Reviewed-on: http://gerrit.cloudera.org:8080/5032
Reviewed-by: Mike Percy <mp...@apache.org>
Tested-by: Kudu Jenkins
---
M java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducer.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Mike Percy: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5032
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1807790fad39ed0d3b22e0e94e06858dd8abceda
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>