You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/12/23 14:44:04 UTC

[GitHub] [tvm] merrymercy commented on a change in pull request #7143: [AutoScheduler] Python based measure callbacks

merrymercy commented on a change in pull request #7143:
URL: https://github.com/apache/tvm/pull/7143#discussion_r547991726



##########
File path: tests/python/relay/test_auto_scheduler_tuning.py
##########
@@ -23,6 +23,15 @@
 from test_auto_scheduler_task_extraction import get_network
 
 
+class CustomMeasureCallback(auto_scheduler.measure.PythonBasedMeasureCallback):

Review comment:
       It is better to move this test to here (https://github.com/apache/tvm/blob/e51bcdd1ed99fc813454c68911f8032c852f48b4/tests/python/unittest/test_auto_scheduler_search_policy.py#L71).
   
   Because this measure callback is not related to relay. We should not put it under `tests/python/relay/`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org