[GitHub] [airflow] syun64 commented on pull request #34335: fix default value for new column as autogenerate SQL was missing default 0

["syun64 (via GitHub)" <gi...@apache.org>]

syun64 commented on PR #34335:
URL: https://github.com/apache/airflow/pull/34335#issuecomment-1717584624

   Hi @abhishekbhakat thank you for flagging this. 
   
   I noticed my PR was merged with a failing CI on MSSQL, but I thought that might have been related to the recent vote from the community to [remove MSSQL as a supported backend](https://lists.apache.org/thread/pgcgmhf6560k8jbsmz8nlyoxosvltph2). Interestingly, the [CI tests for airflow db migrate on PostgreSQL](https://github.com/apache/airflow/actions/runs/6146576336/job/16676594561?pr=34126) passed on the PR, and I wonder if that's because we are migrating an empty airflow DB in the CI: no records means no null values on the new column.
   
   Given that we will be dropping support for MSSQSL (possibly by 2.8.0) I wonder if it would be safe to just disregard the failing tests on MSSQL, with the assumption that it will be removed in 2.8.0?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org