You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Jonas Anden <jo...@aptilo.com> on 2003/04/30 10:40:28 UTC

Patch for bugzilla #19312

Fixes recursive calls to log() in StandardWrapperValve.java.

See http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19312

- --cut-- -
Index: StandardWrapperValve.java
===================================================================
RCS file:
/home/cvspublic/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardWrapperValve.java,v
retrieving revision 1.35
diff -p -u -r1.35 StandardWrapperValve.java
--- StandardWrapperValve.java	6 Feb 2003 22:06:33 -0000	1.35
+++ StandardWrapperValve.java	30 Apr 2003 08:36:55 -0000
@@ -518,8 +518,9 @@ final class StandardWrapperValve
             String containerName = null;
             if (container != null)
                 containerName = container.getName();
-            log( "StandardWrapperValve[" + containerName
-                       + "]: " + message, throwable);
+            System.out.println( "StandardWrapperValve[" + containerName
+                       + "]: " + message );
+            throwable.printStackTrace(System.out);
         }
 
     }
- --cut-- -



---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Re: Patch for bugzilla #19312

Posted by Jonas Anden <jo...@aptilo.com>.
> As you may have noticed, I'm working on the bugs right now, and your bug 
> was already on my list.

I've noticed you have checked in a lot of patches, yes. But I haven't
seen any activity on my bugzilla report, so I thought I'd help as much
as I can by providing a correctly formatted patch against the latest
CVS.

  // J


---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Re: Patch for bugzilla #19312

Posted by Remy Maucherat <re...@apache.org>.
Jonas Anden wrote:
> Fixes recursive calls to log() in StandardWrapperValve.java.
> 
> See http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19312
> 
> - --cut-- -
> Index: StandardWrapperValve.java
> ===================================================================
> RCS file:
> /home/cvspublic/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardWrapperValve.java,v
> retrieving revision 1.35
> diff -p -u -r1.35 StandardWrapperValve.java
> --- StandardWrapperValve.java	6 Feb 2003 22:06:33 -0000	1.35
> +++ StandardWrapperValve.java	30 Apr 2003 08:36:55 -0000
> @@ -518,8 +518,9 @@ final class StandardWrapperValve
>              String containerName = null;
>              if (container != null)
>                  containerName = container.getName();
> -            log( "StandardWrapperValve[" + containerName
> -                       + "]: " + message, throwable);
> +            System.out.println( "StandardWrapperValve[" + containerName
> +                       + "]: " + message );
> +            throwable.printStackTrace(System.out);
>          }
>  
>      }
> - --cut-- -

As you may have noticed, I'm working on the bugs right now, and your bug 
was already on my list.

Remy


---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org