[GitHub] [ozone] siddhantsangwan commented on pull request #2892: HDDS-5927. Improve defaults in ContainerBalancerConfiguration

[GitBox <gi...@apache.org>]

siddhantsangwan commented on pull request #2892:
URL: https://github.com/apache/ozone/pull/2892#issuecomment-987638410


   Hey @lokeshj1703 @JacksonYao287
   We can discuss the balancer defaults here. I've made some initial changes:
   
   1. Changed `idleIterations` to `iterations` to make it clear that this configuration means the number of iterations that balancer will run for.
   2. Changed `maxSizeEnteringTarget` and `maxSizeLeavingSource` to allow the size of five containers, by default.
   
   Proposed changes:
   1. Change the definitions of configurations from ratio to percentage to make them more intuitive. For example, threshold can be "A percentage in the range of 0 to 100..."
   2. Make the default for `maxSizeToMovePerIteration` something like `maxDatanodesRatioToInvolvePerIteration * number of healthy, in service DNs * maxSizeEnteringTarget`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org