You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Keith Wall (JIRA)" <ji...@apache.org> on 2015/10/16 15:01:06 UTC

[jira] [Updated] (QPID-6784) Client may send frames that are too large and broker does wrong frame size validation for AMQP 0-91

     [ https://issues.apache.org/jira/browse/QPID-6784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Keith Wall updated QPID-6784:
-----------------------------
    Summary: Client may send frames that are too large and broker does wrong frame size validation for AMQP 0-91  (was: [Java Broker, Java Client] Client sends too large frames and broker does wrong frame size validation on 0-9)

> Client may send frames that are too large and broker does wrong frame size validation for AMQP 0-91
> ---------------------------------------------------------------------------------------------------
>
>                 Key: QPID-6784
>                 URL: https://issues.apache.org/jira/browse/QPID-6784
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker, Java Client
>    Affects Versions: 0.17, 0.32
>            Reporter: Lorenz Quack
>            Assignee: Keith Wall
>             Fix For: qpid-java-6.0
>
>
> The Client does not include the frame attributes (except for 1 byte) in its calculation of the AMQP Frame size thus creating frames which are 7 bytes too large. This happens in {{org.apache.qpid.client.BasicMessageProducer_0_8#calculateContentBodyFrameCount}} and maybe other places.
> The broker on the other end does an incorrect validation (in {{AMQDecoder#decodable}} at least) where it does not take any of the attributes into account thus accepting too large frames.
> Besides not being compliant with the spec this causes problems in {{NonBlockingConnectionPlainDelegate#processData}} where the frame does not fit into a single networkBuffer.
> I did not investigate other protocol versions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org