[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #10379: cmake:replace custom_patch_target with PATCH_COMMAND

["xiaoxiang781216 (via GitHub)" <gi...@apache.org>]

xiaoxiang781216 commented on code in PR #10379:
URL: https://github.com/apache/nuttx/pull/10379#discussion_r1303739206


##########
libs/libxx/libcxx.cmake:
##########
@@ -18,10 +18,28 @@
 #
 # ##############################################################################
 
-if(NOT EXISTS ${CMAKE_CURRENT_LIST_DIR}/libcxx/.git)
+if(NOT EXISTS ${CMAKE_CURRENT_LIST_DIR}/libcxx)
 
   set(LIBCXX_VERSION 12.0.0)
 
+  set(LIBCXX_PATCH_COMMAND
+      patch -p0 -d ${CMAKE_CURRENT_LIST_DIR} <
+      ${CMAKE_CURRENT_LIST_DIR}/0001-Remove-the-locale-fallback-for-NuttX.patch

Review Comment:
   can we merge into one line?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org